Commit Graph

1221 Commits

Author SHA1 Message Date
Andrew Tridgell fc28cd4fa2 GCS_MAVLink: fixed a ftp duplicate reply
this fixes a bug in burst replies where the duplicate reply may have
the wrong offset. This causes the "paramftp bad type" error
2020-05-14 09:53:42 +10:00
Peter Barker 5100c9fb8c GCS_Common: whitelist AUTOPILOT_VERSION for in_delay_callback sending
GCSs may request this very early on in the boot process, particularly
for SITL.

If we try to send it during a delay callback then we end up dropping it
at the moment - but we'd already sent the ack in response to the
request.
2020-05-11 15:22:38 +10:00
Andrew Tridgell 87c2858bde GCS_MAVLink: give banner on param download with ftp
thanks to Peter for noticing
2020-05-10 15:10:21 +10:00
Andy Piper da166b256d GCS_MAVLink: add messages to Spektrum telemetry if it is enabled 2020-05-05 09:23:15 +10:00
Peter Barker 81454c7a40 GCS_MAVLink: create and use INTERNAL_ERROR macro so we get line numbers 2020-04-30 13:21:36 +10:00
Andrew Tridgell 7571e616de GCS_MAVLink: handle session timeout due to lost packets
and fixed handling of losing last pkt in a burst
2020-04-29 07:36:55 +10:00
Andrew Tridgell 65e790a48c GCS_MAVLink: invalidate param count on set of ENABLE param 2020-04-29 07:36:55 +10:00
Andrew Tridgell 7cd901fa5b GCS_MAVLink: enable ftp without filesystem
allows for @PARAM and @SYS
2020-04-29 07:36:55 +10:00
Andrew Tridgell 6811d79b6f GCS_MAVLink: define GCS_SEND_TEXT() globally
used to avoid linking GCS in AP_Periph
2020-04-29 07:36:55 +10:00
Peter Barker 26b88823f4 GCS_MAVLink: correct out-of-space-to-send call in HAVE_PAYLOAD_SPACE 2020-04-27 15:30:30 +10:00
Peter Barker 8b0b644c11 GCS_MAVLink: correct check for payload space for COMMAND_ACK 2020-04-27 15:30:30 +10:00
Peter Barker 668e0d0e65 GCS_MAVLink: check for empty replies queue first thing in send_ftp_replies
Will save us a little time on average
2020-04-27 15:30:30 +10:00
Randy Mackay 6f8176c71e GCS_MAVLink: remove ahrs3 2020-04-22 14:11:17 +09:00
Peter Barker 8b9281eaa1 GCS_MAVLink: log number of times message not sent due to no space 2020-04-17 22:21:14 +10:00
Peter Barker 41ada7f8f4 GCS_MAVLink: document the payload-space macros 2020-04-17 10:20:49 +10:00
Randy Mackay c39fef6c56 GCS_MAVLink: pass vision-position-estimate reset_counter to AP_VisualOdom handler 2020-04-14 10:28:03 +10:00
Randy Mackay 9769f08fd9 GCS_MAVLink: visual odometry build fixes 2020-04-09 19:41:08 +09:00
Randy Mackay a9c1eb5af4 GCS_MAVLink: fill in sys_status vision position bits 2020-04-09 19:41:08 +09:00
Randy Mackay a1ddd55ea5 GCS_MAVlink: AP_integrate of rename to handle_vision_position_delta_msg 2020-04-09 19:41:08 +09:00
Randy Mackay 728e8b45a9 GCS_MAVLink: use AP_VisualOdom to handle vision-position-estimate messages 2020-04-09 19:41:08 +09:00
Siddharth Purohit b0cbbb4bea GCS_Common: fix unannotated fall-through between switch labels 2020-04-01 17:10:36 +11:00
Andrew Tridgell 21e93dae34 GCS_MAVLink: send only old value for readonly param set
this prevents a condition where the GCS can display the wrong value if
the 2nd PARAM_VALUE is lost

Note that groundstations can tell the set failed due to readonly in
the following ways:

 1) look for the statustext: Param write denied (PARAMNAME)

 2) see that the value came back with the old value, with index of
   65535

 3) can repeat the send, looking for (1) and (2)

Michael has proposed we add a PARAM_VALUE mavlink2 flags
extension. That would be nice, but we should still make this change to
fix the issue with mavlink 1.0
2020-03-31 11:19:58 +11:00
Peter Barker 55d37e5d0e GCS_MAVLink: correct slowing down of waypoint re-requests
These re-requests shouldn't be slowed down by a factor of 20.

This was a left-over from when we did these in terms of 20ms intervals
(50Hz loop rate)
2020-03-31 11:15:04 +11:00
Peter Barker ca7fcc093c GCS_MAVLink: correct return type on get_stream_slowdown_ms
Only used in one place.  On slow links may have caused us to re-request
a waypoint too often.  "Too often" is still >1s intervals.
2020-03-31 11:15:04 +11:00
Peter Barker 0b756547be GCS_MAVLink: add stream_slowdown to MAV message 2020-03-31 11:13:11 +11:00
Peter Barker 7028f1adba GCS_MAVLink: GCS_FTP: remove redundant more_pending variable
This is taken care of by the "break" statements
2020-03-31 10:38:13 +11:00
Peter Barker a09ac895e9 GCS_MAVLink: remove dead assignment
This value is never used
2020-03-31 10:38:13 +11:00
Michael du Breuil 18baf18041 GCS_MAVLink: Remove redundant assignment to the command
This is done internally by the conversion to mission_item_int_t
2020-03-31 10:35:49 +11:00
Randy Mackay ecf5abc1f2 GCS_MAVLink: minor format fix 2020-03-30 20:20:08 +09:00
Andrew Tridgell e7fdf8fad1 GCS_MAVLink: reduced delay between ftp packets 2020-03-28 15:28:03 +11:00
Andrew Tridgell 5c9ae33151 GCS_MAVLink: support variable sized packets in burst read
this allows packet size to be tailored to the transport
2020-03-28 15:28:03 +11:00
Andrew Tridgell 8a84dbc19e GCS_MAVLink: slow down telemetry during ftp 2020-03-28 15:28:03 +11:00
Andrew Tridgell c1d4a5bd35 GCS_MAVLINK: prevent closedir() with nullptr 2020-03-28 15:28:03 +11:00
Andrew Tridgell 28082774b6 GCS_MAVLink: use new DirHandle for directory listings 2020-03-28 15:28:03 +11:00
Peter Barker 97b07d9c84 GCS_MAVLink: add option to get the autopilot to hard-fault itself 2020-03-19 16:03:58 +11:00
Andrew Tridgell 39fc324854 GCS_MAVLink: convert to new get_rpm() API 2020-03-12 08:36:40 +11:00
Andrew Tridgell aaf828c9d4 GCS_MAVLink: consider NO_CHANGE as success for bootloader flash
this prevents GCS users from seeing "update failed"
2020-03-11 16:30:06 +11:00
Peter Barker ebfa910774 GCS_MAVLink: GCS_Dummy: add missing CR to console output of statustexts
send_text and friends don't expect the caller to add the CR; the GCS
will add one.  Since we're jsut emitting to console, add one ourselves.
2020-03-10 19:07:08 +11:00
Rishabh f3e66055e5 GCS_MAVLink: Alert GCS if user tries calibration while vehicle is armed 2020-03-03 11:37:19 +11:00
Peter Barker fbe2e75b9f GCS_MAVLink: divide time allowed to send messages fairly 2020-02-27 08:49:59 +11:00
Peter Barker 727c12c388 GCS_MAVLink: move initialisation of serial and gcs to AP_Vehicle 2020-02-25 11:50:55 +11:00
Peter Barker e2c9f6a8a1 GCS_MAVLink: add flags to MAV dataflash log
holds various pieces of simple information about a link
2020-02-25 10:59:22 +11:00
Peter Barker f8f4ed7ee0 GCS_MAVLink: log disarm method 2020-02-22 12:16:29 +11:00
Andrew Tridgell 20ea1a3dc7 GCS_MAVLink: don't send statustext from other than main thread
This fixes high stack usage in the RCIN thread when it notifies the
GCS of a new RCIN protocol. The problem is severe when signing is
enabled, as signing adds over 500 bytes to stack cost of sending a
mavlink msg

fixes issue #13615
2020-02-20 10:39:29 +11:00
Michael du Breuil 1f8c030eba GCS_MAVLink: Allow scripting to start/stop the REPL 2020-02-18 17:23:22 -07:00
Michael du Breuil 296c014d14 GCS_MAVLink: Fix excess trimming of autopilot version 2020-02-19 09:10:02 +11:00
Andrew Tridgell 32ecd904bd GCS_MAVLink: use MAV_SYS_STATUS_PREARM_CHECK
this allows GCS to continually display prearm check status
2020-02-18 15:16:02 +11:00
Matt Lawrence c84dcd9bf8 GCS_Mavlink: Add routing for GoPro heartbeat 2020-02-18 11:13:27 +11:00
Peter Barker 87a31c6409 GCS_MAVLink: don't recalculate max parameter count if not streaming params 2020-02-18 10:33:41 +11:00
Peter Hall b1742b4e19 GCS_Mavlink: constrain battery current to avoid wrap 2020-02-12 08:04:39 +11:00
Andrew Tridgell f7eba43cb8 GCS_MAVLink: raise ftp stack size to 3072 from 1024
this prevents memory corruption on directory listing
2020-02-11 13:32:17 +11:00
Peter Hall ba811052f8 GCS_Mavlink: report on fence limiting 2020-02-04 10:24:33 +09:00
Randy Mackay 7a5f57f940 GCS_MAVLink: send rc output mode banner to GCS 2020-02-04 12:23:33 +11:00
Peter Barker 1650979a2b GCS_MAVLink: add support for MAV_CMD_DEBUG_TRAP 2020-01-29 10:27:01 +11:00
Andrew Tridgell 0e7ddebd15 GCS_MAVLink: fix for updated mavlink extensions 2020-01-29 08:16:59 +11:00
Peter Barker e248bdfb16 GCS_MAVLink: split statustexts into 50-byte chunks using mav2 extensions 2020-01-28 19:56:38 +11:00
Peter Barker 8fc64ccbe9 GCS_MAVLink: allow NavEKFs to be compiled out 2020-01-21 11:53:18 +11:00
Peter Barker a9f62f196e GCS_MAVLink: consolidate places we snprintf statustexts 2020-01-14 10:38:43 +11:00
Andrew Tridgell 8ae5dffd31 GCS_MAVLink: fixed valgrind error in mission upload
affects DO_JUMP
2020-01-11 08:29:34 +11:00
Randy Mackay 188fdfb1b8 GCS_MAVLink: send optflow message even if no height estimate 2020-01-06 11:36:43 +09:00
Andrew Tridgell 1b528137f7 GCS_MAVLINK: cope with AP_Frsky_Telem being created after init
may be created by the FPort backend
2020-01-02 09:52:57 +11:00
murata 91e09338ea GCS_MAVLInk: Judgment of non-existence value by PARAM_SET 2019-12-31 10:12:01 +11:00
Andrew Tridgell c6322c7c98 GCS_MAVLink: send abs throttle in VFR_HUD 2019-12-24 15:14:03 +11:00
Peter Barker 01710c035e GCS_MAVLink: handle proximity and rangefinder messages 2019-12-24 12:08:54 +11:00
Oliver Walters 5fa54f3986 GCS_MAVLink: added support for Piccolo CAN ESCs 2019-12-22 09:48:40 +11:00
Peter Barker d1bbe4f03b GCS_MAVLink: correct output when ROUTING_DEBUG is set
This is a define in the code itself, so rarely a problem
2019-12-20 10:00:07 +11:00
Andrew Tridgell dd73eac08c GCS_MAVLink: support MAV_CMD_FIXED_MAG_CAL_YAW 2019-12-18 17:20:37 +11:00
Peter Barker ebbcd00873 GCS_MAVLink: send statustext to all GCSs until update_send is called
until update_send it called we don't mark channels as streaming, so
send_statustext won't send to that channel.

Calculating the streaming mask could have been done as part of the init
call, but this fix may allow for information getting to the user in the
case that the streaming parameters are all zero, too.
2019-12-18 14:36:58 +11:00
Andrew Tridgell f8f591c7db GCS_MAVLink: fixed critical error on prefight cal ops 2019-12-13 09:30:48 +11:00
Randy Mackay 6d94d2b62f GCS_MAVLink: remove send-text re allocating for fence 2019-12-10 08:51:19 +11:00
Peter Barker b48da34c61 GCS_MAVLink: move setting of GPS SYS_STATUS bits up to base class 2019-12-05 13:02:19 +11:00
Andrew Tridgell 1eebae2346 GCS_MAVLink: use new SERIAL_CONTROL_SERIALn enums 2019-12-01 12:48:23 +11:00
Peter Barker 314ea32ede GCS_MAVLink: any internal error means MAV_STATE_CRITICAL 2019-11-27 14:27:53 +11:00
Marian Soban 6e961b55eb GCS_MAVLink: LTM telemetry support 2019-11-26 12:14:13 +11:00
Peter Barker a96a4c0510 GCS_MAVLink: correct encoding used for send_to_components
These have to be packed onto the channel - otherwise they may ge
tencoded as mavlink1 instead of mavlink2 (or vice-versa)
2019-11-26 12:10:12 +11:00
Michael du Breuil 7582a5b4a4 GCS_MAVLink: Send GPS logging as part of the logging status bits 2019-11-20 11:06:16 -07:00
Andrew Tridgell 2b27cd2ce9 Plane: Add EFI Support 2019-11-17 20:10:54 +11:00
Andrew Tridgell 00e3344321 GCS_MAVLink: add EFI_STATUS message 2019-11-17 20:10:54 +11:00
Peter Barker 7d2557b316 GCS_MAVLink: correct txspace return value issues
- checking of space in send_to_active_channels was incorrect - did not
take into account locked status of the channel

 - corrected return value on comm_get_txspace - took a uint32_t, cast it
to int16_t, checked it for zero, then cast it to uint16_t on return.
That's just... odd.
2019-11-12 16:33:12 +11:00
Peter Barker a893a5483c GCS_MAVLink: support sysid targetting 2019-11-12 07:52:22 +08:00
Peter Barker ac7111f1d1 GCS_MAVLink: adjust for renaming of RangeFinder files 2019-11-12 07:14:37 +08:00
Mark Whitehorn a25846b8a2 GCS_MAVLink: change in_sensor_config_error to in_config_error 2019-11-08 10:14:34 +11:00
Peter Barker 402f3ec09c GCS_MAVLink: honour coordinate altitude frames for DO_SET_ROI
Also use {} to construct the location.

Note the assumption that the frame is relative-to-home when we receive
the command via COMMAND (as opposed to COMMAND_LONG)

Note that this is a behavioural change as
2019-11-05 19:55:45 +11:00
Peter Barker 66d460c19b GCS_MAVLink: correct format in short-write panic message 2019-11-05 11:29:08 +11:00
Peter Barker b9dbfff0d0 GCS_MAVLink: announce capabilities compass-cal and param float for all vehicles 2019-11-05 11:26:23 +11:00
Andrew Tridgell 43da68ae59 GCS_MAVLink: added ftp_push_replies() 2019-11-02 22:52:06 +11:00
Andrew Tridgell 10ed848dd7 GCS_MAVLink: fixed comment 2019-11-02 22:52:06 +11:00
Andrew Tridgell 15fc3f3d75 GCS_MAVLink: fixed session handling for ftp 2019-11-02 22:52:06 +11:00
Andrew Tridgell 00549d13fa GCS_MAVLink: rename emit_dir_entry to gen_dir_entry
comment from Sid
2019-11-02 22:52:06 +11:00
Andrew Tridgell e5321b6201 GCS_MAVLink: fixes from my review 2019-11-02 22:52:06 +11:00
Michael du Breuil 6f538dd45a GCS_MAVLink: Initial FTP support 2019-11-02 22:52:06 +11:00
Peter Barker 4838ee6f58 GCS_MAVLink: check reply channel for space rather than current channel 2019-11-02 10:34:03 +11:00
Peter Barker 34eff6d1c6 GCS_MAVLink: adjust for proximity status namespace change 2019-10-31 11:58:15 +08:00
Peter Barker 5c3a0926a1 GCS_MAVLink: adjust for proximity rangefinder types changing namespacing 2019-10-31 11:58:15 +08:00
Randy Mackay 96616343ce GCS_MAVLink: mission item support more mav frames 2019-10-30 18:27:07 +08:00
Andrew Tridgell 4593697634 GCS_MAVLink: use new flash_bootloader() API 2019-10-25 21:36:55 +11:00
Michael du Breuil cb1b236439 GCS_MAVLink: Use the vehicle singleton to directly set the flight mode 2019-10-25 08:48:22 +08:00
Andrew Tridgell c03796d7de GCS_MAVLink: fixed uninitialised bytes in send_named_float()
this fixes an issue with mavproxy with python3
2019-10-17 13:50:35 +11:00
Randy Mackay 7ce2fb8783 GCS_Mavlink: handle_preflight_reboot made virtual 2019-10-15 07:41:44 +09:00
Andrew Tridgell 29e65a7294 GCS_MAVLink: supply IMU temperature in mavlink extensions 2019-10-10 13:23:03 +11:00