In file included from ../../libraries/SITL/SIM_last_letter.cpp:19:
../../libraries/SITL/SIM_last_letter.h:74:17: warning: private field
'frame_str' is not used [-Wunused-private-field]
const char *frame_str;
SITL: correct compiler warning
In file included from ../../libraries/SITL/SIM_Sprayer.cpp:19:
../../libraries/SITL/SIM_Sprayer.h:55:14: warning: private field
'start_time_us' is not used [-Wunused-private-field]
uint64_t start_time_us;
SITL: correct compiler warnings
In file included from ../../libraries/SITL/SIM_Gripper_Servo.cpp:19:
../../libraries/SITL/SIM_Gripper_Servo.h:56:10: warning: private field
'zero_report_done' is not used [-Wunused-private-field]
bool zero_report_done = false;
SITL: correct compiler warnings
In file included from ../../libraries/SITL/SIM_ADSB.cpp:19:
../../libraries/SITL/SIM_ADSB.h:49:28: warning: private field 'fdm' is
not used [-Wunused-private-field]
const struct sitl_fdm &fdm;
For the general case, pragma once is better replacement for of include
guards. One line instead of three, less scopes to close in the end of
the file, no chance to having the outdated names in the define symbol.
Remove unnecessary includes, reorder them in blocks separated by a blank
line
- Corresponding header file (if exists)
- System headers
- Other ArduPilot library headers
- "Local" headers (from the same library)
This commit changes the way libraries headers are included in source files:
- If the header is in the same directory the source belongs to, so the
notation '#include ""' is used with the path relative to the directory
containing the source.
- If the header is outside the directory containing the source, then we use
the notation '#include <>' with the path relative to libraries folder.
Some of the advantages of such approach:
- Only one search path for libraries headers.
- OSs like Windows may have a better lookup time.
Peter Barker
Mathieu OTHACEHE
Georacer
Caio Marcelo de Oliveira Filho
Gustavo Jose de Sousa
Andrew Tridgell