........
r79620 | brian.curtin | 2010-04-02 16:18:14 -0500 (Fri, 02 Apr 2010) | 9 lines
Implement #7347. Add CreateKeyEx, DeleteKeyEx, and update _winreg tests.
*ReflectionKey functions used to not be documented or tested, but they are
now sufficiently documented and tested on platforms where they apply.
Additionally, fixed a bug in QueryReflectionKey which was returning an
incorrect value.
All tests pass from XP through Windows 7, on 32 and 64-bit platforms.
........
r79624 | ezio.melotti | 2010-04-02 16:43:10 -0500 (Fri, 02 Apr 2010) | 1 line
Fix test_compiler.py that was using unittest.__file__ to find Lib/ (unittest is now a package).
........
r79625 | brian.curtin | 2010-04-02 16:51:37 -0500 (Fri, 02 Apr 2010) | 2 lines
Add a line about #7347 to Misc\News
........
r79633 | brian.curtin | 2010-04-02 18:26:06 -0500 (Fri, 02 Apr 2010) | 14 lines
Implement #1220212. Add os.kill support for Windows.
os.kill takes one of two newly added signals, CTRL_C_EVENT and
CTRL_BREAK_EVENT, or any integer value. The events are a special case
which work with subprocess console applications which implement a
special console control handler. Any other value but those two will
cause os.kill to use TerminateProcess, outright killing the process.
This change adds win_console_handler.py, which is a script to implement
SetConsoleCtrlHandler and applicable handler function, using ctypes.
subprocess also gets another attribute which is a necessary flag to
creationflags in Popen in order to send the CTRL events.
........
r79634 | brian.curtin | 2010-04-02 18:31:28 -0500 (Fri, 02 Apr 2010) | 2 lines
Add note about #1220212 (os.kill on Windows)
........
r79635 | benjamin.peterson | 2010-04-02 18:31:40 -0500 (Fri, 02 Apr 2010) | 1 line
set svn:eol-style on new file
........
r79636 | benjamin.peterson | 2010-04-02 18:59:41 -0500 (Fri, 02 Apr 2010) | 4 lines
always check _PyString_Resize for error
also normalize how this error is checked
........
r79637 | raymond.hettinger | 2010-04-02 19:39:26 -0500 (Fri, 02 Apr 2010) | 1 line
Clear cyclical references in list based OrderedDict.
........
r79639 | benjamin.peterson | 2010-04-02 19:57:33 -0500 (Fri, 02 Apr 2010) | 1 line
more _PyString_Resize error checking
........
r79640 | brian.curtin | 2010-04-02 19:59:32 -0500 (Fri, 02 Apr 2010) | 3 lines
Fix assertRaises usage on reflection functions which should raise
NotImplementedError on Windows XP and below.
........
r79650 | raymond.hettinger | 2010-04-02 22:14:28 -0500 (Fri, 02 Apr 2010) | 1 line
Improve clear() method. Keeps key/value refcnts >= 1 until final dict.clear() so that decrefs to zero won't trigger arbitrary code . Also runs a bit faster.
........
r79651 | raymond.hettinger | 2010-04-03 02:57:09 -0500 (Sat, 03 Apr 2010) | 1 line
Factor-out constant expressions
........
r79654 | victor.stinner | 2010-04-03 03:40:16 -0500 (Sat, 03 Apr 2010) | 5 lines
Issue #8227: Fix C API documentation, argument parsing
* 'z', 'z#', 'z*' does also accept Unicode
* unify types name: replace "string or Unicode objet" by "string or Unicode"
........
r79673 | brian.curtin | 2010-04-03 08:58:39 -0500 (Sat, 03 Apr 2010) | 2 lines
Add missing return statement in an error condition.
........
r79693 | benjamin.peterson | 2010-04-03 10:38:38 -0500 (Sat, 03 Apr 2010) | 1 line
wrap
........
r79695 | benjamin.peterson | 2010-04-03 10:40:29 -0500 (Sat, 03 Apr 2010) | 1 line
remove unneeded argument
........
r79697 | benjamin.peterson | 2010-04-03 10:44:56 -0500 (Sat, 03 Apr 2010) | 1 line
silence PyCObject warnings in bsddb
........
r79698 | benjamin.peterson | 2010-04-03 10:45:59 -0500 (Sat, 03 Apr 2010) | 1 line
spelling
........
r79704 | benjamin.peterson | 2010-04-03 10:58:15 -0500 (Sat, 03 Apr 2010) | 1 line
remove deprecation warnings silence attempting
........
r79706 | benjamin.peterson | 2010-04-03 11:06:42 -0500 (Sat, 03 Apr 2010) | 1 line
stop CObject deprecation warnings in test___all__
........
r79707 | mark.dickinson | 2010-04-03 11:41:20 -0500 (Sat, 03 Apr 2010) | 5 lines
Ensure 'module removed' warning messages contain the word 'module' or 'package'.
This should fix the test_py3kwarn failure on OS X. test_support.import_module
also requires this.
........
r79710 | mark.dickinson | 2010-04-03 11:54:02 -0500 (Sat, 03 Apr 2010) | 1 line
Replace backquotes with repr(), to silence a SyntaxWarning.
........
r79712 | raymond.hettinger | 2010-04-03 12:10:05 -0500 (Sat, 03 Apr 2010) | 1 line
Silence a compiler warning.
........
r79713 | raymond.hettinger | 2010-04-03 13:10:37 -0500 (Sat, 03 Apr 2010) | 1 line
Add count() method to collections.deque().
........
r79714 | mark.dickinson | 2010-04-03 13:17:54 -0500 (Sat, 03 Apr 2010) | 1 line
Silence DeprecationWarnings from uses of has_key and <> in plat-mac.
........
r79718 | antoine.pitrou | 2010-04-03 16:42:18 -0500 (Sat, 03 Apr 2010) | 3 lines
Remove useless (?) import from r79706
........
r79719 | benjamin.peterson | 2010-04-03 16:50:40 -0500 (Sat, 03 Apr 2010) | 1 line
import bsddb more robustly
........
r79722 | raymond.hettinger | 2010-04-03 17:34:15 -0500 (Sat, 03 Apr 2010) | 1 line
Expand test coverage for deque.count().
........
r79730 | raymond.hettinger | 2010-04-03 20:24:59 -0500 (Sat, 03 Apr 2010) | 1 line
Issue 5479: Add functools.total_ordering class decorator.
........
r79744 | raymond.hettinger | 2010-04-04 02:33:46 -0500 (Sun, 04 Apr 2010) | 1 line
Documentation nit
........
r79750 | raymond.hettinger | 2010-04-04 13:34:45 -0500 (Sun, 04 Apr 2010) | 1 line
Add functools.CmpToKey()
........
r79755 | raymond.hettinger | 2010-04-04 16:45:01 -0500 (Sun, 04 Apr 2010) | 6 lines
Add tests for cmp_to_key.
Adopt PEP 8 compliant function name.
Factor-out existing uses cmp_to_key.
Update documentation to use internal pointers instead of external resource.
........
r79760 | raymond.hettinger | 2010-04-04 17:24:03 -0500 (Sun, 04 Apr 2010) | 1 line
Add tests for functools.total_ordering.
........
r79769 | benjamin.peterson | 2010-04-04 18:23:22 -0500 (Sun, 04 Apr 2010) | 1 line
fix dis on new style classes #8310
........
r79808 | raymond.hettinger | 2010-04-05 13:53:43 -0500 (Mon, 05 Apr 2010) | 1 line
Classes that override __eq__ also need to define __hash__.
........
r79811 | brian.curtin | 2010-04-05 14:04:23 -0500 (Mon, 05 Apr 2010) | 7 lines
Fix a failing test on an apparently slow Windows buildbot.
On slower Windows machines, waiting 0.1 seconds can sometimes not be
enough for a subprocess to start and be ready to accept signals, causing
the test to fail. One buildbot is also choking on input()/EOFError so
that was changed to not depend on input.
........
r79890 | mark.dickinson | 2010-04-07 05:18:27 -0500 (Wed, 07 Apr 2010) | 4 lines
Use some more interesting test values for (unsigned) long long ctypes tests,
in the hope of getting more information about the test_ctypes failures
on Sparc (see issue #8314).
........
r80062 | r.david.murray | 2010-04-13 15:57:40 -0500 (Tue, 13 Apr 2010) | 2 lines
Issue #5277: Fix quote counting when parsing RFC 2231 encoded parameters.
........
r80065 | brian.curtin | 2010-04-13 21:24:24 -0500 (Tue, 13 Apr 2010) | 6 lines
Add a small sleep to let a subprocess start before terminating it.
David Bolen's buildbot isn't know for it's speed, and it seems that we
may have been trying to kill the subprocess before it was fully
initialized. I ran with this change on the bot itself and it seemed to work.
........
r80082 | georg.brandl | 2010-04-14 16:36:49 -0500 (Wed, 14 Apr 2010) | 1 line
#8370: fix module name in backported doc addition.
........
r80086 | brian.curtin | 2010-04-14 19:40:40 -0500 (Wed, 14 Apr 2010) | 9 lines
Fix os.kill tests to be more robust and work with slower machines.
Rather than depending on some sleep value, start up an interpreter
as a subprocess and communicate with it. Because subprocess pipes
can't be read from until EOF and I want to read from them before that,
use ctypes to peek by using PeekNamedPipe. Once the subprocess has
written the message, then it is ready to roll and accept signals.
After that, kill it.
........
r80171 | antoine.pitrou | 2010-04-18 06:16:24 -0500 (Sun, 18 Apr 2010) | 3 lines
Fix bootstrap after r80166
........
r80189 | victor.stinner | 2010-04-18 13:22:25 -0500 (Sun, 18 Apr 2010) | 1 line
Revert r80166 (and r80171), restore Lib/platform.py. subprocess cannot be used in platform.py
........
r80242 | ronald.oussoren | 2010-04-20 03:53:12 -0500 (Tue, 20 Apr 2010) | 8 lines
The PythonLauncher change is needed due
to changes in how the BASECFLAGS and CFLAGS
variables get filled by configure.
The Mac/Makefile.in change ensures that
pythonw gets build with the rigth deployment
targets.
........
r80243 | ronald.oussoren | 2010-04-20 03:54:48 -0500 (Tue, 20 Apr 2010) | 3 lines
This patch fixes the handling of a weak-linked
variable and should fix issue #8095.
........
r80374 | antoine.pitrou | 2010-04-22 12:44:41 -0500 (Thu, 22 Apr 2010) | 3 lines
Temporarily display OpenSSL version in verbose run -- trying to diagnose failure on Neal's buildbot.
........
r80411 | florent.xicluna | 2010-04-23 12:59:10 -0500 (Fri, 23 Apr 2010) | 2 lines
Remove ImportWarnings filters. They become obsolete after r79310, issue #8205.
........
r80412 | florent.xicluna | 2010-04-23 13:10:12 -0500 (Fri, 23 Apr 2010) | 2 lines
Fix the "regrtest -s" switch.
........
r80445 | brian.curtin | 2010-04-24 12:10:22 -0500 (Sat, 24 Apr 2010) | 2 lines
Fix#5774. Some _winreg functions are documented as taking kwargs but don't.
........
r80579 | nick.coghlan | 2010-04-28 09:34:30 -0500 (Wed, 28 Apr 2010) | 1 line
Also mention patch submitter's name in NEWS, not just in the commit message
........
r80580 | nick.coghlan | 2010-04-28 09:51:08 -0500 (Wed, 28 Apr 2010) | 1 line
Issue 8202: when using the -m command line switch, sys.argv[0] is now '-m' instead of '-c' while searching for the module to be executed
........
r80581 | nick.coghlan | 2010-04-28 09:53:59 -0500 (Wed, 28 Apr 2010) | 1 line
Add version changed note for -m tinkering with sys.argv[0] during the search process
........
r80700 | ronald.oussoren | 2010-05-02 04:55:57 -0500 (Sun, 02 May 2010) | 3 lines
Small update to r80698 to ensure that webbrowser.open
uses the default browser.
........
r80737 | brett.cannon | 2010-05-03 18:57:15 -0500 (Mon, 03 May 2010) | 4 lines
Fix two potential uninitialization errors and an unneeded assignment.
Found using Clang's static analyzer.
........
r80745 | brett.cannon | 2010-05-03 20:04:53 -0500 (Mon, 03 May 2010) | 5 lines
Mention the code clean-up thanks to Clang's static analyzer in Modules.
Was not applied to modules that will not compile under OS X, dbmmodule.c,
getaddrinfo.c, and getnameinfo.c.
........
r80752 | victor.stinner | 2010-05-04 06:35:36 -0500 (Tue, 04 May 2010) | 4 lines
_pyio: Fix TextIOWrapper constructor: os has no device_encoding() function
_io module doesn't call this function which was introduced in Python3.
........
r80794 | barry.warsaw | 2010-05-05 11:17:22 -0500 (Wed, 05 May 2010) | 1 line
NEWS
........
r80813 | brett.cannon | 2010-05-05 15:20:19 -0500 (Wed, 05 May 2010) | 4 lines
Remove three unneeded variable assignments.
Found using Clang's static analyzer.
........
r80814 | brett.cannon | 2010-05-05 15:24:30 -0500 (Wed, 05 May 2010) | 1 line
Partially revert the over-reaching r80813.
........
r80823 | brett.cannon | 2010-05-05 15:54:53 -0500 (Wed, 05 May 2010) | 1 line
Mention how Clang's static anaylzer was run over Objects/ and Python/.
........
r80963 | ronald.oussoren | 2010-05-08 03:44:37 -0500 (Sat, 08 May 2010) | 4 lines
Fix for issue #7724: make it possible to build using
the OSX 10.4u SDK on MacOSX 10.6 by honoring the specified
SDK when looking for files.
........
r80982 | antoine.pitrou | 2010-05-08 10:23:57 -0500 (Sat, 08 May 2010) | 3 lines
Revert r80963 - it broke compilation everywhere
........
r81012 | gregory.p.smith | 2010-05-08 18:38:49 -0500 (Sat, 08 May 2010) | 2 lines
Fixes [issue7245] Better Ctrl-C support in pdb.
........
r81013 | gregory.p.smith | 2010-05-08 20:20:20 -0500 (Sat, 08 May 2010) | 5 lines
Revert r81012. buildbot problems and its questionable of me to even
add this to trunk while we're on the way to 2.7rc1.
When fixed this can go into py3k first. Sorry.
........
r81030 | antoine.pitrou | 2010-05-09 10:15:11 -0500 (Sun, 09 May 2010) | 3 lines
Fixup indentation of PC/_msi.c
........
r81035 | antoine.pitrou | 2010-05-09 13:32:48 -0500 (Sun, 09 May 2010) | 3 lines
Remove spurious newlines, and add version number.
........
r81088 | brian.curtin | 2010-05-11 14:13:13 -0500 (Tue, 11 May 2010) | 13 lines
#8575 - Update and reorganize some _winreg contents.
I've removed the hopeful note about a future higher-level module since
it's been in there for quite a long time and nothing of the sort has
come up. There are a few places where markup was added to cross-reference
other sections, and many of the external links have been removed and now
point to newly created sections containing previously undocumented
information.
The Value Types section was created and it's contents were taken from
a function-specific area, since it applies to more than just that
function. It fits in better with the other newly documented constants.
........
r81140 | florent.xicluna | 2010-05-13 12:05:29 -0500 (Thu, 13 May 2010) | 3 lines
Add sensible information about the OS X platform to diagnose issue #8423:
test_pep277 fails on "x86 Tiger" buildbot but not on "PPC Tiger".
........
r81141 | florent.xicluna | 2010-05-13 13:16:06 -0500 (Thu, 13 May 2010) | 2 lines
Revert the additional OS X information (r81140). Keep the endianness information.
........
r81149 | florent.xicluna | 2010-05-13 16:40:01 -0500 (Thu, 13 May 2010) | 2 lines
Better test skipping, with message in the log.
........
r81150 | florent.xicluna | 2010-05-13 16:41:05 -0500 (Thu, 13 May 2010) | 2 lines
Improve test feedback to troubleshoot issue #8423 on OS X.
........
r81151 | florent.xicluna | 2010-05-13 18:46:48 -0500 (Thu, 13 May 2010) | 2 lines
Revert changeset r81150 which helped diagnose issue #8423 on some OS X buildbot.
........
r81275 | antoine.pitrou | 2010-05-17 14:56:59 -0500 (Mon, 17 May 2010) | 4 lines
Issue #7079: Fix a possible crash when closing a file object while using
it from another thread. Patch by Daniel Stutzbach.
........
r81484 | georg.brandl | 2010-05-22 16:26:21 -0500 (Sat, 22 May 2010) | 1 line
NEWS rewrap and punctuation consistency.
........
r81502 | georg.brandl | 2010-05-24 16:37:54 -0500 (Mon, 24 May 2010) | 1 line
#8616: update module name
........
r81517 | brian.curtin | 2010-05-25 10:06:15 -0500 (Tue, 25 May 2010) | 5 lines
Fix#2810 - handle the case where some registry calls return
ERROR_MORE_DATA, requiring another call to get the remaining data.
Patch by Daniel Stutzbach
........
r81561 | alexander.belopolsky | 2010-05-26 15:57:04 -0500 (Wed, 26 May 2010) | 1 line
Added Andrej Krpic. (Thanks for issue #7879 patch.)
........
r81705 | r.david.murray | 2010-06-04 14:51:06 -0500 (Fri, 04 Jun 2010) | 9 lines
#4487: have Charset check with codecs for possible aliases.
Previously, unexpected results occurred when email was passed, for example,
'utf8' as a charset name, since email would accept it but would *not* use
the 'utf-8' codec for it, even though Python itself recognises that as
an alias for utf-8. Now Charset checks with codecs for aliases as well
as its own internal table. Issue 8898 has been opened to change this
further in py3k so that all aliasing is routed through the codecs module.
........
r81847 | brian.curtin | 2010-06-08 16:15:06 -0500 (Tue, 08 Jun 2010) | 3 lines
Move a variable declration outside of a loop to match what was
done in r81843 for py3k.
........
r81919 | vinay.sajip | 2010-06-11 17:56:50 -0500 (Fri, 11 Jun 2010) | 1 line
Issue #8924: logging: Improved error handling for Unicode in exception text.
........
r81964 | nick.coghlan | 2010-06-13 01:50:39 -0500 (Sun, 13 Jun 2010) | 1 line
Revert r80580 due to some unintended side effects. See issue #8202 for details.
........
r82056 | florent.xicluna | 2010-06-17 15:30:56 -0500 (Thu, 17 Jun 2010) | 2 lines
Add few words about test.test_genericpath.CommonTest
........
r82136 | benjamin.peterson | 2010-06-21 10:56:45 -0500 (Mon, 21 Jun 2010) | 1 line
update pydoc-topics
........
r82137 | benjamin.peterson | 2010-06-21 10:57:57 -0500 (Mon, 21 Jun 2010) | 1 line
bump verson to 2.7rc2
........
r82142 | benjamin.peterson | 2010-06-21 12:28:30 -0500 (Mon, 21 Jun 2010) | 1 line
towards final release
........
r82149 | ronald.oussoren | 2010-06-22 04:18:28 -0500 (Tue, 22 Jun 2010) | 11 lines
Fix for issue8446:
* Don't import 'ic' in webbrowser, that module is no longer used
* Remove 'MacOS' from the list of modules that should emit a Py3kWarning on import.
This is needed because one of the earlier tests triggers and import of this
extension, and that causes a failure in test_py3kwarn (running test_py3kwarn
separately worked fine)
With these changes 'make tests' no longer says that test_py3kwarn fails.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82284 | ronald.oussoren | 2010-06-27 15:59:39 +0200 (Sun, 27 Jun 2010) | 4 lines
Fix for Issue8883: without this patch test_urllib will fail
when there is a bare IP address in the "Bypass proxy settings
for these Hosts & Domains" list on MacOSX.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82150 | ronald.oussoren | 2010-06-22 11:32:22 +0200 (Tue, 22 Jun 2010) | 12 lines
The code in _scproxy (a mac specific helper module to
detect proxy settings) had the wrong logic for detecting
if the checkbox 'Exclude simple hostnames' is checked. This
checkin fixes that.
As a result the test failure 'Issue8455' goes away on systems
where the checkbox is not checked.
I'm carefully avoiding saying that is fixes that issue,
test_urllib2_localnet assumes that system proxy settings are
empty (not just on OSX, see Issue8455 for details).
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82276 | ronald.oussoren | 2010-06-27 14:43:47 +0200 (Sun, 27 Jun 2010) | 5 lines
The uuid library on OSX 10.5 seems to contain the same bug as the one
on OSX 10.6, therefore don't use it there either.
This fixes issue8621.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82272 | ronald.oussoren | 2010-06-27 14:36:16 +0200 (Sun, 27 Jun 2010) | 8 lines
Two small fixes for the support for SDKs on MacOSX:
1) The code that checks if an path should be located in the SDK
explicitly excludes /usr/local. This fixes issue9046
2) The SDK variant for filtering "db_dirs_to_check" in setup.py
was not doing anything because of a missing assignment.
........
from the fact that OPT contains -Wall be default. This is annoying when
compilers like clang have thorough debugging information about things that
Python does extensively (e.g. -Wunused-value for unused return values caused by
a macro use).
........
r82246 | r.david.murray | 2010-06-26 14:39:50 -0400 (Sat, 26 Jun 2010) | 8 lines
#9085: email versions have gotten out of sync, 2.7 is actually 4.0.3.
In 2.5 the email version was bumped to 4.0.2 just before release but
after the maintenance branch was set up. The bump was not backported
to trunk, and 2.6 went out the door with a version number of 4.0.1.
I bumped this to 4.0.2 because of a behavior change, but that makes
it look the same as 2.5. So bump it again to 4.0.3.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82236 | alexander.belopolsky | 2010-06-25 22:05:19 -0400 (Fri, 25 Jun 2010) | 4 lines
Issue #9024: Fixed mark-up for PyDateTime_IMPORT macro and added that
it is typically used in module initialization function. Thanks Tim
Golden for the patch.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82233 | r.david.murray | 2010-06-25 20:06:44 -0400 (Fri, 25 Jun 2010) | 2 lines
#4640: add a test to optparse that proves issue is invalid.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82229 | benjamin.peterson | 2010-06-25 17:58:47 -0500 (Fri, 25 Jun 2010) | 1 line
mark implementation detail as such
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82225 | benjamin.peterson | 2010-06-25 15:34:01 -0500 (Fri, 25 Jun 2010) | 1 line
mark implementation detail as such
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82221 | mark.dickinson | 2010-06-25 21:19:48 +0100 (Fri, 25 Jun 2010) | 1 line
Fix indentation of Python code example in C comment.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82210 | antoine.pitrou | 2010-06-25 02:03:21 +0200 (ven., 25 juin 2010) | 4 lines
Issue #9075: In the ssl module, remove the setting of a `debug` flag
on an OpenSSL structure.
........
........
r82191 | stefan.krah | 2010-06-24 11:33:05 +0200 (Thu, 24 Jun 2010) | 5 lines
Issue #9020: The Py_IS* macros from pyctype.h should generally only be
used with signed/unsigned char arguments. For integer arguments, EOF
has to be handled separately.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82169 | antoine.pitrou | 2010-06-22 23:42:05 +0200 (mar., 22 juin 2010) | 4 lines
Fix misindents in compile.c (for Benjamin).
Of course, whoever used the wrong indentation rules needs to be spanked.
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82165 | benjamin.peterson | 2010-06-22 15:26:20 -0500 (Tue, 22 Jun 2010) | 1 line
must force gc here
........
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82157 | benjamin.peterson | 2010-06-22 14:16:37 -0500 (Tue, 22 Jun 2010) | 1 line
remove INT_MAX assertions; they can fail with large Py_ssize_t #9058
........
Benjamin Peterson
Brett Cannon
Mark Dickinson
Ronald Oussoren
Georg Brandl
Alexander Belopolsky
Ezio Melotti
R. David Murray
Antoine Pitrou
Victor Stinner
Stefan Krah