Gregory P. Smith
9204e09178
fix a BytesWarning in my previous commit.
2014-06-15 20:16:01 -07:00
Gregory P. Smith
634aa68c2b
Isolate the subprocess test_close_fds_when_max_fd_is_lowered test so
...
that the rlimit calls happens in a child process rather than the
TestCase process to attempt to fix the gentoo buildbot's "Too many
open files" error.
2014-06-15 17:51:04 -07:00
Gregory P. Smith
d04f699498
Skip test_subprocess test_close_fds_when_max_fd_is_lowered on FreeBSD
...
when fdescfs is not mounted on /dev/fd.
2014-06-01 15:27:28 -07:00
Gregory P. Smith
8fed4deb44
Attempt to fix the "too many open files" errors on several of the
...
buildbots that the new test_close_fds_when_max_fd_is_lowered test causes.
It now leaves 10 more low fd's available.
2014-06-01 15:15:44 -07:00
Gregory P. Smith
ffd529cde1
Explicitly wait for the child instead of letting a destructor do it.
2014-06-01 13:46:54 -07:00
Gregory P. Smith
d4dcb70287
Don't restrict ourselves to a "max" fd when closing fds before exec()
...
when we have a way to get an actual list of all open fds from the OS.
Fixes issue #21618 : The subprocess module would ignore fds that were
inherited by the calling process and already higher than POSIX resource
limits would otherwise allow. On systems with a functioning /proc/self/fd
or /dev/fd interface the max is now ignored and all fds are closed.
2014-06-01 13:18:28 -07:00
Antoine Pitrou
c644e7c39f
Issue #21396 : Fix TextIOWrapper(..., write_through=True) to not force a flush() on the underlying binary stream.
...
Patch by akira.
2014-05-09 00:24:50 +02:00
Gregory P. Smith
ab2719f904
fix the test on windows which has different return codes from killed
...
children.
2014-04-23 08:38:36 -07:00
Gregory P. Smith
d65ba51e24
subprocess's Popen.wait() is now thread safe so that multiple threads
...
may be calling wait() or poll() on a Popen instance at the same time
without losing the Popen.returncode value. Fixes issue #21291 .
2014-04-23 00:27:17 -07:00
Gregory P. Smith
53dd8167ff
Fixes issue #15798 : subprocess.Popen() no longer fails if file
...
descriptor 0, 1 or 2 is closed. (correct fix for 3.4 this time)
2013-12-01 16:03:24 -08:00
Gregory P. Smith
54532c9742
Undo supposed fix for Issue #15798 until I understand why this is
...
causing test_multiprocessing_forkserver and test_multiprocessing_spawn
failures on head (3.4).
2013-12-01 00:13:35 -08:00
Gregory P. Smith
361e30c17a
Undo supposed fix for Issue #15798 until I understand why this is
...
causing test_multiprocessing_forkserver and test_multiprocessing_spawn
failures on head (3.4).
2013-12-01 00:12:24 -08:00
Gregory P. Smith
1c27e3c7fb
Fixes Issue #15798 - subprocess.Popen() no longer fails if file
...
descriptor 0, 1 or 2 is closed.
2013-11-30 19:04:00 -08:00
Gregory P. Smith
1eda9e7c30
Fixes Issue #15798 - subprocess.Popen() no longer fails if file
...
descriptor 0, 1 or 2 is closed.
2013-11-30 19:02:57 -08:00
Victor Stinner
5323fb0990
Issue #19637 : fix test_undecodable_env() of test_subprocess on AIX
...
On AIX, the C locale encoding uses the ISO-8859-1 encoding, not ASCII.
2013-11-19 23:46:06 +01:00
Charles-François Natali
3a4586a9f9
Issue #18923 : Update subprocess to use the new selectors module.
2013-11-08 19:56:59 +01:00
Tim Golden
ab7211f278
Issue #10197 Rework subprocess.get[status]output to use subprocess functionality and thus to work on Windows. Patch by Nick Coghlan.
2013-11-03 12:55:51 +00:00
Tim Golden
e004175c56
Issue #10197 Rework subprocess.get[status]output to use subprocess functionality and thus to work on Windows. Patch by Nick Coghlan.
2013-11-03 12:53:17 +00:00
Antoine Pitrou
fd4722cacf
Issue #9548 : Add a minimal "_bootlocale" module that is imported by the _io module instead of the full locale module.
2013-10-12 00:13:50 +02:00
Antoine Pitrou
77e904e6a6
Issue #18948 : improve SuppressCoreFiles to include Windows crash popup suppression, and use it in more tests.
...
Patch by Valerie Lambert and Zachary Ware.
2013-10-08 23:04:32 +02:00
Antoine Pitrou
b0478b3f5f
Issue #18623 : Factor out the _SuppressCoreFiles context manager into test.support.
...
Patch by Valerie Lambert.
2013-09-06 20:50:00 +02:00
Victor Stinner
f6fa22efe0
Issue #18571 : Merge duplicate test code
...
Merge test/subprocessdata/inherited.py into test/subprocessdata/fd_status.py
2013-09-01 10:22:41 +02:00
Antoine Pitrou
267964c837
Forward port new tests from Issue #18851 .
2013-08-31 00:12:37 +02:00
Antoine Pitrou
a8392717f1
Forward port new tests from Issue #18851 .
2013-08-30 23:38:13 +02:00
Gregory P. Smith
6cc50391a6
Fixes Issue #15507 : test_subprocess's test_send_signal could fail if the test
...
runner were run in an environment where the process inherited an ignore
setting for SIGINT. Restore the SIGINT handler to the desired
KeyboardInterrupt raising one during that test.
2013-08-29 13:39:44 -07:00
Gregory P. Smith
dee0434e2f
Fixes issue #15507 : test_subprocess's test_send_signal could fail if the test
...
runner were run in an environment where the process inherited an ignore
setting for SIGINT. Restore the SIGINT handler to the desired
KeyboardInterrupt raising one during that test.
2013-08-29 13:35:27 -07:00
Victor Stinner
daf455554b
Issue #18571 : Implementation of the PEP 446: file descriptors and file handles
...
are now created non-inheritable; add functions os.get/set_inheritable(),
os.get/set_handle_inheritable() and socket.socket.get/set_inheritable().
2013-08-28 00:53:59 +02:00
Charles-François Natali
a439b32cf0
Merge.
2013-08-25 18:28:44 +02:00
Charles-François Natali
249cdc39fc
Issue #18763 : subprocess: The file descriptors are now closed after calling the
...
preexec_fn callback, which may open file descriptors.
2013-08-25 18:24:45 +02:00
Ned Deily
582583bc41
Issue #17046 : merge from 3.3
2013-08-02 18:05:31 -07:00
Ned Deily
e92dfbfec8
Issue #17046 : Fix test_subprocess test_executable_without_cwd broken test case.
2013-08-02 18:02:21 -07:00
Antoine Pitrou
284e5ce67e
Fix the RLIMIT_CORE resource lowering logic in test_subprocess.
...
We must only lower the soft limit, since lowering the hard limit makes it impossible to raise it back at the end.
(this could prevent core dumps from being generated when the test suite crashes)
2013-08-02 00:08:51 +02:00
Richard Oudkerk
a35a128acc
Merge.
2013-06-10 16:31:39 +01:00
Richard Oudkerk
0e547b66dc
Issue #18174 : Fix fd leaks in tests.
2013-06-10 16:29:19 +01:00
Antoine Pitrou
dc49b2b88c
Try to make test more reliable (saw some sporadic failures on buildbots)
2013-05-19 15:55:40 +02:00
Antoine Pitrou
5b6616dee3
Try to make test more reliable (saw some sporadic failures on buildbots)
2013-05-19 15:55:59 +02:00
Serhiy Storchaka
fcd9f22238
Issue #16624 : `subprocess.check_output` now accepts an `input` argument,
...
allowing the subprocess's stdin to be provided as a (byte) string.
Patch by Zack Weinberg.
2013-04-22 20:20:54 +03:00
Gregory P. Smith
4a8ea9e2a6
Fixes issue #17488 : Change the subprocess.Popen bufsize parameter default value
...
from unbuffered (0) to buffering (-1) to match the behavior existing code
expects and match the behavior of the subprocess module in Python 2 to avoid
introducing hard to track down bugs.
2013-03-23 12:00:00 -07:00
Gregory P. Smith
a1b9ed32ee
Fixes issue #17488 : Change the subprocess.Popen bufsize parameter default value
...
from unbuffered (0) to buffering (-1) to match the behavior existing code
expects and match the behavior of the subprocess module in Python 2 to avoid
introducing hard to track down bugs.
2013-03-23 11:54:22 -07:00
Gregory P. Smith
a1ed539268
Fixes issue #17488 : Change the subprocess.Popen bufsize parameter default value
...
from unbuffered (0) to buffering (-1) to match the behavior existing code
expects and match the behavior of the subprocess module in Python 2 to avoid
introducing hard to track down bugs.
2013-03-23 11:44:25 -07:00
Ezio Melotti
c0417357d1
#11963 : merge with 3.3.
2013-03-11 06:03:05 +02:00
Ezio Melotti
3300878d8c
#11963 : merge with 3.2.
2013-03-11 05:59:55 +02:00
Ezio Melotti
42a541bd49
#11963 : remove human verification from test_parser and test_subprocess.
2013-03-11 05:53:34 +02:00
Serhiy Storchaka
b3f194d109
Issue #16903 : Popen.communicate() on Unix now accepts strings when
...
universal_newlines is true as on Windows.
2013-02-04 16:47:39 +02:00
Charles-François Natali
6c566b3ce9
Issue #16762 : Fix some test_subprocess failures on NetBSD and OpenBSD: kill()
...
returns ESRCH for a zombie process, which is not POSIX-compliant.
2013-01-12 16:55:31 +01:00
Charles-François Natali
dbc744ac74
Issue #16762 : Fix some test_subprocess failures on NetBSD and OpenBSD: kill()
...
returns ESRCH for a zombie process, which is not POSIX-compliant.
2013-01-12 16:54:45 +01:00
Charles-François Natali
53221e371d
Issue #16762 : Fix some test_subprocess failures on NetBSD and OpenBSD: kill()
...
returns ESRCH for a zombie process, which is not POSIX-compliant.
2013-01-12 16:52:20 +01:00
Andrew Svetlov
0c8ee7fc8b
fix test for subprocess ( #16644 )
2012-12-26 23:36:17 +02:00
Andrew Svetlov
b172697cd8
fix test for subprocess ( #16644 )
2012-12-26 23:34:54 +02:00
Andrew Svetlov
57a1233110
fix test for subprocess ( #16644 )
2012-12-26 23:31:45 +02:00
Andrew Svetlov
3438fa496d
Get rig of EnvironmentError ( #16705 )
2012-12-17 23:35:18 +02:00
Gregory P. Smith
65ee6ece2d
Refactor test_preexec_errpipe to not create an uncollectable reference cycle.
2012-11-11 10:12:40 -08:00
Gregory P. Smith
859035d2ef
Refactor test_preexec_errpipe to not create an uncollectable reference cycle.
2012-11-11 10:00:49 -08:00
Gregory P. Smith
e27faac45f
Refactor test_preexec_errpipe to not create an uncollectable reference cycle.
2012-11-11 09:59:27 -08:00
Gregory P. Smith
c2c4cb624b
Fixes issue #16140 : The subprocess module no longer double closes its
...
child subprocess.PIPE parent file descriptors on child error prior to
exec().
This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
2012-11-11 01:41:49 -08:00
Gregory P. Smith
c8ac03d936
Fixes issue #16140 : The subprocess module no longer double closes its
...
child subprocess.PIPE parent file descriptors on child error prior to
exec().
This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
2012-11-11 01:38:18 -08:00
Gregory P. Smith
12489d98e6
Fixes issue #16140 : The subprocess module no longer double closes its
...
child subprocess.PIPE parent file descriptors on child error prior to
exec().
This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
2012-11-11 01:37:02 -08:00
Gregory P. Smith
8d07c264e4
Raise our own SubprocessError rather than a RuntimeError in when dealing with
...
odd rare errors coming from the subprocess module.
2012-11-10 23:53:47 -08:00
Gregory P. Smith
561cbc4e7b
Fixes issue #16327 : The subprocess module no longer leaks file descriptors
...
used for stdin/stdout/stderr pipes to the child when fork() fails.
2012-11-10 22:33:23 -08:00
Gregory P. Smith
3d8e776cd9
Fixes issue #16327 : The subprocess module no longer leaks file descriptors
...
used for stdin/stdout/stderr pipes to the child when fork() fails.
2012-11-10 22:32:22 -08:00
Gregory P. Smith
a10ddb8a55
Fixes Issue #16114 : The subprocess module no longer provides a
...
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.
2012-10-10 03:44:47 -07:00
Gregory P. Smith
5591b02a4c
Fixes Issue #16114 : The subprocess module no longer provides a
...
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.
It now keeps track of if the child got as far as preexec and reports it if
not back to the parent via a special "noexec" error message value in
the error pipe so that the cwd can be blamed for a failed chdir
instead of the exec of the executable being blamed instead.
The executable is also always reported accurately when exec fails.
Unittests enhanced to cover these cases.
2012-10-10 03:34:47 -07:00
Chris Jerdonek
86b0fb23e5
Issue #16170 : Remove Linux skip from test_subprocess's test_executable test.
2012-10-09 13:17:49 -07:00
Chris Jerdonek
2d051b8eaf
Issue #16115 : Skip a newly added subprocess.Popen() test on Linux.
2012-10-08 17:53:46 -07:00
Chris Jerdonek
776cb199bc
Issue #16115 : Improve testing of the executable argument to subprocess.Popen().
2012-10-08 15:56:43 -07:00
Andrew Svetlov
a2028733ef
revert accidental inclusion of subprocess tests
2012-10-06 18:45:47 +03:00
Andrew Svetlov
b2209ccfa0
revert accidental inclusion of subprocess tests
2012-10-06 18:45:24 +03:00
Andrew Svetlov
5061a34283
Issue #16025 : Minor corrections to the zipfile documentation.
...
Patch by Serhiy Storchaka.
2012-10-06 18:10:01 +03:00
Andrew Svetlov
afbf90c993
Issue #16025 : Minor corrections to the zipfile documentation.
...
Patch by Serhiy Storchaka.
2012-10-06 18:02:05 +03:00
Andrew Svetlov
1a53c0cbf5
Issue #16115 : Add test for check that executable arg to Popen() takes precedence over args[0] arg\n \n Patch by Kushal Das
2012-10-05 22:52:15 +03:00
Chris Jerdonek
9a6ada8026
Issue #15533 : Merge update from 3.2.
2012-09-30 09:46:04 -07:00
Chris Jerdonek
c2cd626497
Issue #15533 : Skip test_cwd_with_relative_*() tests on Windows pending resolution of issue.
2012-09-30 09:45:00 -07:00
Chris Jerdonek
28714c8c26
Issue #15533 : Merge fix from 3.2.
2012-09-30 02:15:37 -07:00
Chris Jerdonek
ec3ea94251
Issue #15533 : Clarify docs and add tests for subprocess.Popen()'s cwd argument.
2012-09-30 00:10:28 -07:00
Andrew Svetlov
a19de803e4
Issue #15595 : Fix subprocess.Popen(universal_newlines=True)
...
for certain locales (utf-16 and utf-32 family).
Patch by Chris Jerdonek.
2012-08-19 22:20:03 +03:00
Andrew Svetlov
828607170d
Issue #15595 : Fix subprocess.Popen(universal_newlines=True)
...
for certain locales (utf-16 and utf-32 family).
Patch by Chris Jerdonek.
2012-08-19 22:13:41 +03:00
Andrew Svetlov
47ec25d2f6
Brush subprocess tests a bit.
2012-08-19 16:25:37 +03:00
Andrew Svetlov
943c5b31b6
Fix subprocess test broken on Windows
2012-08-16 20:17:47 +03:00
Andrew Svetlov
5395d2f07d
Add yet another test for subprocess.Popen.communicate
2012-08-15 22:46:43 +03:00
Andrew Svetlov
aa0dbdc2dd
Issue #15592 . Fix regression: subprocess.communicate() breaks on no input with universal newlines true.
...
Patch by Chris Jerdonek.
2012-08-14 18:40:21 +03:00
Andrew Svetlov
f3765071eb
Add test to explicit check the absence regression in subprocess (issue #15592 ).
...
Patch by Chris Jerdonek.
2012-08-14 18:35:17 +03:00
Antoine Pitrou
6f1a40ffd3
Merge universal newlines-related fixes (issue #13119 )
2012-08-05 00:25:31 +02:00
Antoine Pitrou
ec2d26930c
Fix universal newlines test to avoid the newline translation done by sys.stdout.
2012-08-05 00:23:40 +02:00
Vinay Sajip
7ded1f0f69
Implemented PEP 405 (Python virtual environments).
2012-05-26 03:45:29 +01:00
Antoine Pitrou
b69ef16fe6
Issue #14252 : Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited.
2012-03-11 19:33:29 +01:00
Antoine Pitrou
1f9a835400
Issue #14252 : Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited.
2012-03-11 19:29:12 +01:00
Ross Lagerwall
e7ad419058
Fix sporadic test_subprocess regression introduced by 834650d63130.
2012-02-22 06:02:07 +02:00
Georg Brandl
2fb477c0f0
Merge 3.2: Issue #13703 plus some related test suite fixes.
2012-02-21 00:33:36 +01:00
Georg Brandl
a86b262d1e
Fix bad inheritance in test_subprocess that led to a number of tests being executed twice.
2012-02-20 21:34:57 +01:00
Ross Lagerwall
003c7a3fca
Fix a typo.
2012-02-12 09:02:01 +02:00
Ross Lagerwall
ab66d2a6cb
Attempt to speed up some subprocess tests (and hopefully keep them reliable).
2012-02-12 09:01:30 +02:00
Gregory P. Smith
0648458b84
Fix a unittest error seen on NetBSD 5.
2012-01-21 22:06:09 -08:00
Gregory P. Smith
886455cc4e
Fix a unittest error seen on NetBSD 5.
2012-01-21 22:05:10 -08:00
Gregory P. Smith
d635af5a61
Fixes issue #8052 : The posix subprocess module's close_fds behavior was
...
suboptimal by closing all possible file descriptors rather than just
the open ones in the child process before exec().
It now closes only the open fds when it is possible to safely determine what
those are.
2012-01-21 14:39:29 -08:00
Gregory P. Smith
8facece99a
Fixes issue #8052 : The posix subprocess module's close_fds behavior was
...
suboptimal by closing all possible file descriptors rather than just
the open ones in the child process before exec().
It now closes only the open fds when it is possible to safely determine what
those are.
2012-01-21 14:01:08 -08:00
Benjamin Peterson
ce2af33562
merge 3.2
2011-12-10 12:44:37 -05:00
Benjamin Peterson
b870aa1255
we're always going to have gc
2011-12-10 12:44:25 -05:00
Benjamin Peterson
d3a345a21f
merge 3.2
2011-12-10 12:38:52 -05:00
Benjamin Peterson
964561bb7c
you can't get resource.error if you can't import resource
2011-12-10 12:31:42 -05:00
Nadeem Vawda
74adbaa7bd
Merge: Fix ResourceWarnings in test_subprocess.
2011-08-19 05:14:40 +02:00