traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Get rig of EnvironmentError (#16705)

This commit is contained in:
Andrew Svetlov 2012-12-17 23:35:18 +02:00
parent 6eda46de99
commit 3438fa496d
16 changed files with 34 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/compileall.py
View File

@ -209,7 +209,7 @@ def main():
with (sys.stdin if args.flist=='-' else open(args.flist)) as f:
for line in f:
compile_dests.append(line.strip())
except EnvironmentError:
except OSError:
print("Error reading file list {}".format(args.flist))
return False

2
Lib/getpass.py
View File

@ -47,7 +47,7 @@ def unix_getpass(prompt='Password: ', stream=None):
input = tty
if not stream:
stream = tty
except EnvironmentError as e:
except OSError as e:
# If that fails, see if stdin can be controlled.
try:
fd = sys.stdin.fileno()

4
Lib/mimetypes.py
View File

@ -243,7 +243,7 @@ class MimeTypes:
while True:
try:
ctype = _winreg.EnumKey(mimedb, i)
except EnvironmentError:
except OSError:
break
else:
yield ctype
@ -256,7 +256,7 @@ class MimeTypes:
with _winreg.OpenKey(mimedb, ctype) as key:
suffix, datatype = _winreg.QueryValueEx(key,
'Extension')
except EnvironmentError:
except OSError:
continue
if datatype != _winreg.REG_SZ:
continue

10
Lib/shutil.py
View File

@ -39,20 +39,20 @@ __all__ = ["copyfileobj", "copyfile", "copymode", "copystat", "copy", "copy2",
"ignore_patterns", "chown", "which"]
# disk_usage is added later, if available on the platform
class Error(EnvironmentError):
class Error(OSError):
pass
class SameFileError(Error):
"""Raised when source and destination are the same file."""
class SpecialFileError(EnvironmentError):
class SpecialFileError(OSError):
"""Raised when trying to do a kind of operation (e.g. copying) which is
not supported on a special file (e.g. a named pipe)"""
class ExecError(EnvironmentError):
class ExecError(OSError):
"""Raised when a command could not be executed"""
class ReadError(EnvironmentError):
class ReadError(OSError):
"""Raised when an archive cannot be read"""
class RegistryError(Exception):
@ -329,7 +329,7 @@ def copytree(src, dst, symlinks=False, ignore=None, copy_function=copy2,
# continue with other files
except Error as err:
errors.extend(err.args[0])
except EnvironmentError as why:
except OSError as why:
errors.append((srcname, dstname, str(why)))
try:
copystat(src, dst)

4
Lib/subprocess.py
View File

@ -819,7 +819,7 @@ class Popen(object):
for f in filter(None, (self.stdin, self.stdout, self.stderr)):
try:
f.close()
except EnvironmentError:
except OSError:
pass # Ignore EBADF or other errors.
# Make sure the child pipes are closed as well.
@ -833,7 +833,7 @@ class Popen(object):
for fd in to_close:
try:
os.close(fd)
except EnvironmentError:
except OSError:
pass
raise

8
Lib/tarfile.py
View File

@ -2022,7 +2022,7 @@ class TarFile(object):
try:
self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
set_attrs=set_attrs)
except EnvironmentError as e:
except OSError as e:
if self.errorlevel > 0:
raise
else:
@ -2212,7 +2212,7 @@ class TarFile(object):
os.lchown(targetpath, u, g)
else:
os.chown(targetpath, u, g)
except EnvironmentError as e:
except OSError as e:
raise ExtractError("could not change owner")
def chmod(self, tarinfo, targetpath):
@ -2221,7 +2221,7 @@ class TarFile(object):
if hasattr(os, 'chmod'):
try:
os.chmod(targetpath, tarinfo.mode)
except EnvironmentError as e:
except OSError as e:
raise ExtractError("could not change mode")
def utime(self, tarinfo, targetpath):
@ -2231,7 +2231,7 @@ class TarFile(object):
return
try:
os.utime(targetpath, (tarinfo.mtime, tarinfo.mtime))
except EnvironmentError as e:
except OSError as e:
raise ExtractError("could not change modification time")
#--------------------------------------------------------------------------

6
Lib/test/test_exceptions.py
View File

@ -255,11 +255,11 @@ class ExceptionTests(unittest.TestCase):
'errno' : 'foo', 'strerror' : 'bar'}),
(IOError, ('foo', 'bar', 'baz', 'quux'),
{'args' : ('foo', 'bar', 'baz', 'quux')}),
(EnvironmentError, ('errnoStr', 'strErrorStr', 'filenameStr'),
(OSError, ('errnoStr', 'strErrorStr', 'filenameStr'),
{'args' : ('errnoStr', 'strErrorStr'),
'strerror' : 'strErrorStr', 'errno' : 'errnoStr',
'filename' : 'filenameStr'}),
(EnvironmentError, (1, 'strErrorStr', 'filenameStr'),
(OSError, (1, 'strErrorStr', 'filenameStr'),
{'args' : (1, 'strErrorStr'), 'errno' : 1,
'strerror' : 'strErrorStr', 'filename' : 'filenameStr'}),
(SyntaxError, (), {'msg' : None, 'text' : None,
@ -409,7 +409,7 @@ class ExceptionTests(unittest.TestCase):
self.assertIsNone(e.__context__)
self.assertIsNone(e.__cause__)
class MyException(EnvironmentError):
class MyException(OSError):
pass
e = MyException()

2
Lib/test/test_fileio.py
View File

@ -285,7 +285,7 @@ class OtherFileTests(unittest.TestCase):
if sys.platform != "win32":
try:
f = _FileIO("/dev/tty", "a")
except EnvironmentError:
except OSError:
# When run in a cron job there just aren't any
# ttys, so skip the test. This also handles other
# OS'es that don't support /dev/tty.

2
Lib/test/test_io.py
View File

@ -2825,7 +2825,7 @@ class MiscIOTest(unittest.TestCase):
for fd in fds:
try:
os.close(fd)
except EnvironmentError as e:
except OSError as e:
if e.errno != errno.EBADF:
raise
self.addCleanup(cleanup_fds)

2
Lib/test/test_signal.py
View File

@ -33,7 +33,7 @@ def exit_subprocess():
def ignoring_eintr(__func, *args, **kwargs):
try:
return __func(*args, **kwargs)
except EnvironmentError as e:
except OSError as e:
if e.errno != errno.EINTR:
raise
return None

7
Lib/test/test_subprocess.py
View File

@ -925,8 +925,7 @@ class ProcessTestCase(BaseTestCase):
# value for that limit, but Windows has 2048, so we loop
# 1024 times (each call leaked two fds).
for i in range(1024):
# Windows raises IOError. Others raise OSError.
with self.assertRaises(EnvironmentError) as c:
with self.assertRaises(OSError) as c:
subprocess.Popen(['nonexisting_i_hope'],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
@ -1874,7 +1873,7 @@ class POSIXProcessTestCase(BaseTestCase):
# let some time for the process to exit, and create a new Popen: this
# should trigger the wait() of p
time.sleep(0.2)
with self.assertRaises(EnvironmentError) as c:
with self.assertRaises(OSError) as c:
with subprocess.Popen(['nonexisting_i_hope'],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE) as proc:
@ -2155,7 +2154,7 @@ class ContextManagerTests(BaseTestCase):
self.assertEqual(proc.returncode, 1)
def test_invalid_args(self):
with self.assertRaises(EnvironmentError) as c:
with self.assertRaises(OSError) as c:
with subprocess.Popen(['nonexisting_i_hope'],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE) as proc:

4
Lib/test/test_tarfile.py
View File

@ -342,7 +342,7 @@ class MiscReadTest(CommonReadTest):
tar.extract("ustar/regtype", TEMPDIR)
try:
tar.extract("ustar/lnktype", TEMPDIR)
except EnvironmentError as e:
except OSError as e:
if e.errno == errno.ENOENT:
self.fail("hardlink not extracted properly")
@ -352,7 +352,7 @@ class MiscReadTest(CommonReadTest):
try:
tar.extract("ustar/symtype", TEMPDIR)
except EnvironmentError as e:
except OSError as e:
if e.errno == errno.ENOENT:
self.fail("symlink not extracted properly")

2
Lib/test/test_tempfile.py
View File

@ -149,7 +149,7 @@ class TestRandomNameSequence(BaseTestCase):
# via any bugs above
try:
os.kill(pid, signal.SIGKILL)
except EnvironmentError:
except OSError:
pass
os.close(read_fd)
os.close(write_fd)

2
Lib/test/test_urllib2net.py
View File

@ -216,7 +216,7 @@ class OtherNetworkTests(unittest.TestCase):
debug(url)
try:
f = urlopen(url, req, TIMEOUT)
except EnvironmentError as err:
except OSError as err:
debug(err)
if expected_err:
msg = ("Didn't get expected error(s) %s for %s %s, got %s: %s" %

10
Lib/test/test_winreg.py
View File

@ -97,7 +97,7 @@ class BaseWinregTests(unittest.TestCase):
QueryInfoKey(int_sub_key)
self.fail("It appears the CloseKey() function does "
"not close the actual key!")
except EnvironmentError:
except OSError:
pass
# ... and close that key that way :-)
int_key = int(key)
@ -106,7 +106,7 @@ class BaseWinregTests(unittest.TestCase):
QueryInfoKey(int_key)
self.fail("It appears the key.Close() function "
"does not close the actual key!")
except EnvironmentError:
except OSError:
pass
def _read_test_data(self, root_key, subkeystr="sub_key", OpenKey=OpenKey):
@ -123,7 +123,7 @@ class BaseWinregTests(unittest.TestCase):
while 1:
try:
data = EnumValue(sub_key, index)
except EnvironmentError:
except OSError:
break
self.assertEqual(data in test_data, True,
"Didn't read back the correct test data")
@ -144,7 +144,7 @@ class BaseWinregTests(unittest.TestCase):
try:
EnumKey(key, 1)
self.fail("Was able to get a second key when I only have one!")
except EnvironmentError:
except OSError:
pass
key.Close()
@ -168,7 +168,7 @@ class BaseWinregTests(unittest.TestCase):
# Shouldnt be able to delete it twice!
DeleteKey(key, subkeystr)
self.fail("Deleting the key twice succeeded")
except EnvironmentError:
except OSError:
pass
key.Close()
DeleteKey(root_key, test_key_name)

2
Lib/urllib/request.py
View File

@ -232,7 +232,7 @@ def urlcleanup():
for temp_file in _url_tempfiles:
try:
os.unlink(temp_file)
except EnvironmentError:
except OSError:
pass
del _url_tempfiles[:]