Commit Graph

36745 Commits

Author SHA1 Message Date
Josiah Carlson 1893ce7a97 Fixed documentation to be correct for Py3k. 2008-07-07 04:23:14 +00:00
Josiah Carlson d74900ebb5 Committing Py3k version of changelist 64080 and 64257, along with updated tests
for smtpd, which required updating with the new semantics.
2008-07-07 04:15:08 +00:00
Amaury Forgeot d'Arc d51ee54a23 Blocked revisions 64762 via svnmerge
........
  r64762 | amaury.forgeotdarc | 2008-07-06 23:34:39 +0200 (dim., 06 juil. 2008) | 8 lines

  Issue839496: SimpleHTTPServer should open all files in binary mode.

  Forward-port of 38255 (2005/01/15!)
  This was already fixed in 2.4, but never merged into trunk...
  py3k is already right, thanks to the bytes/str distinction!

  Should be backported to 2.5.
........
2008-07-06 21:37:52 +00:00
Benjamin Peterson bfc644bdbe fix no-op in tutorial 2008-07-05 23:39:56 +00:00
Benjamin Peterson 2b968d6187 #3295 actually define PyExc_BufferError 2008-07-05 23:38:30 +00:00
Benjamin Peterson bbea7972a4 make the symlink to Python be created on install for IDLE.app 2008-07-05 22:51:21 +00:00
Benjamin Peterson bebfbe2d11 finish fixing the rlcompleter regression (thanks for noticing Antonine Pitrou) 2008-07-05 21:20:33 +00:00
Benjamin Peterson f385485ec8 fix regression from merge error in rlcompletor 2008-07-05 20:59:18 +00:00
Martin v. Löwis ba32b72be5 Merged revisions 64736-64737 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

................
  r64736 | martin.v.loewis | 2008-07-05 17:45:45 +0200 (Sa, 05 Jul 2008) | 20 lines

  Merged revisions 64285-64735 via svnmerge from
  svn+ssh://pythondev@svn.python.org/sandbox/trunk/2to3/lib2to3

  ........
    r64493 | benjamin.peterson | 2008-06-24 04:14:14 +0200 (Di, 24 Jun 2008) | 1 line

    add a fix_import mapping for cPickle -> pickle
  ........
    r64651 | brett.cannon | 2008-07-02 04:00:11 +0200 (Mi, 02 Jul 2008) | 3 lines

    Update fix_imports for urllib. Had to change the fixer itself to handle modules
    that are split across several renames in 3.0.
  ........
    r64669 | brett.cannon | 2008-07-02 21:43:48 +0200 (Mi, 02 Jul 2008) | 4 lines

    Backing out last change until fix_imports is working again. Also re-enable the
    testing for fix_imports; if it is deemed that it takes too long to run then a
    random sample should be taken and used to test it.
  ........
................
  r64737 | martin.v.loewis | 2008-07-05 17:48:20 +0200 (Sa, 05 Jul 2008) | 2 lines

  Disable lib2to3 by default, unless run explicitly.
................
2008-07-05 15:55:00 +00:00
Mark Dickinson 0d748c2fa4 Docstring typo 2008-07-05 11:29:03 +00:00
Amaury Forgeot d'Arc a073e33746 Correct a typo during previous checkin. 2008-07-04 21:34:47 +00:00
Amaury Forgeot d'Arc a4db68622c Issue #3280: like chr() already does, the "%c" format now accepts the full unicode range
even on "narrow Unicode" builds; the result is a pair of UTF-16 surrogates.
2008-07-04 21:26:43 +00:00
Benjamin Peterson 142957ce95 touch up str docstrings #3284 2008-07-04 19:55:29 +00:00
Amaury Forgeot d'Arc a819caadef Correct a test after r64701. 2008-07-04 17:57:09 +00:00
Georg Brandl d52429fb49 Issue #3282: str.isprintable() should return False for undefined Unicode characters. 2008-07-04 15:55:02 +00:00
Georg Brandl 6e7196fb93 Fix committed merge conflict. 2008-07-04 15:45:10 +00:00
Benjamin Peterson e7c78b26c6 remove traces of .next 2008-07-03 20:28:26 +00:00
Benjamin Peterson 69164c77ef document LOAD_BUILD_CLASS 2008-07-03 14:45:20 +00:00
Martin v. Löwis b09b844a5c Merged revisions 64688 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64688 | martin.v.loewis | 2008-07-03 14:51:14 +0200 (Do, 03 Jul 2008) | 9 lines

  Patch #1622: Correct interpretation of various ZIP header fields.

  Also fixes
  - Issue #1526: Allow more than 64k files to be added to Zip64 file.

  - Issue #1746: Correct handling of zipfile archive comments (previously
    archives with comments over 4k were flagged as invalid). Allow writing
    Zip files with archives by setting the 'comment' attribute of a ZipFile.
........
2008-07-03 14:13:42 +00:00
Amaury Forgeot d'Arc 451a356f11 Merged revisions 64685 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64685 | amaury.forgeotdarc | 2008-07-03 01:40:28 +0200 (Thu, 03 Jul 2008) | 3 lines

  Try a blind fix to nismodule which fails on the solaris10 3.0 buildbot:
  the GIL must be re-acquired in the callback function
........
2008-07-02 23:44:19 +00:00
Amaury Forgeot d'Arc 4b02c5a854 Correct a typo that breaks test_distutils 2008-07-02 23:22:30 +00:00
Amaury Forgeot d'Arc 612f61f0f0 Add a NEWS entry for Issue #3247. 2008-07-02 23:02:21 +00:00
Amaury Forgeot d'Arc 87ce6d70ed #3247: get rid of Py_FindMethods
Remove references in documentation;
also rewrite a paragraph that looked off-topic to me.
2008-07-02 22:59:48 +00:00
Amaury Forgeot d'Arc 1f900f1f69 #3247: get rid of Py_FindMethod
Third step: unix-only modules. Really remove the function this time.
2008-07-02 22:38:47 +00:00
Brett Cannon 7c265a1943 Block r64673. 2008-07-02 22:07:22 +00:00
Brett Cannon 1af5a1e468 Merged revisions 64677 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64677 | brett.cannon | 2008-07-02 14:52:42 -0700 (Wed, 02 Jul 2008) | 2 lines

  Revert r64673 and instead just change the file encoding.
........
2008-07-02 22:06:12 +00:00
Amaury Forgeot d'Arc 55b69e794c Oops, forgot that there are modules outside the win32 world. 2008-07-02 21:47:18 +00:00
Amaury Forgeot d'Arc ba4105c133 #3247: Get rid of Py_FindMethod:
Second step: keep tp_getattr functions when they are complex,
but use PyObject_GenericGetAttr() as a fallback.

These were the last occurrences of Py_FindMethod.
2008-07-02 21:41:01 +00:00
Amaury Forgeot d'Arc e43d33a4db #3247 Get rid of Py_FindMethod; use tp_members instead.
Otherwise dir(_sre.SRE_Match) returns an empty list.

First step: handle most occurrences, remove tp_getattr and fill the tp_methods and tp_members slots.
Add some test about attribute access.
2008-07-02 20:50:16 +00:00
Benjamin Peterson 4118174315 Merged revisions 64475,64544-64545,64550,64557-64558,64565,64570,64577,64582-64583,64585,64590,64592-64593,64625,64630,64638,64647,64655-64656,64663-64664 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64475 | raymond.hettinger | 2008-06-22 22:29:28 -0500 (Sun, 22 Jun 2008) | 1 line

  Issue 3161: Missing import and test.
........
  r64544 | georg.brandl | 2008-06-26 16:12:55 -0500 (Thu, 26 Jun 2008) | 2 lines

  Use newer versions of externals.
........
  r64545 | benjamin.peterson | 2008-06-26 16:23:30 -0500 (Thu, 26 Jun 2008) | 1 line

  add a htmlview directive
........
  r64550 | brett.cannon | 2008-06-26 19:32:16 -0500 (Thu, 26 Jun 2008) | 2 lines

  Ignore .pyc and .pyo files.
........
  r64557 | mark.dickinson | 2008-06-27 05:11:52 -0500 (Fri, 27 Jun 2008) | 3 lines

  Remove trailing 'L's from numerator and denominator in the
  repr() of a Fraction instance.
........
  r64558 | mark.dickinson | 2008-06-27 06:03:21 -0500 (Fri, 27 Jun 2008) | 2 lines

  Add Jean Brouwers for his work on math.sum
........
  r64565 | raymond.hettinger | 2008-06-27 16:34:24 -0500 (Fri, 27 Jun 2008) | 1 line

  Fix whitespace in example code.
........
  r64570 | hyeshik.chang | 2008-06-27 20:04:31 -0500 (Fri, 27 Jun 2008) | 8 lines

  Give information for compililation of _multiprocessing.SemLock on FreeBSD:

  FreeBSD's P1003.1b semaphore support is highly experimental and
  it's disabled by default.  Even if a user loads the experimental
  kernel module manually, _multiprocessing doesn't work correctly due
  to several known incompatibilities around sem_unlink and sem_getvalue,
  yet.
........
  r64577 | raymond.hettinger | 2008-06-28 17:16:53 -0500 (Sat, 28 Jun 2008) | 1 line

  Issue 3230:  Do not the set specific size macro.
........
  r64582 | benjamin.peterson | 2008-06-28 18:06:05 -0500 (Sat, 28 Jun 2008) | 2 lines

  convert test_audioop to unittest. Thanks to Giampaolo Rodola.
........
  r64583 | benjamin.peterson | 2008-06-28 18:06:49 -0500 (Sat, 28 Jun 2008) | 1 line

  rewrap
........
  r64585 | benjamin.peterson | 2008-06-28 18:35:31 -0500 (Sat, 28 Jun 2008) | 1 line

  fix typo
........
  r64590 | benjamin.peterson | 2008-06-29 08:43:07 -0500 (Sun, 29 Jun 2008) | 1 line

  reinstate the ending backtick. thanks Nick :)
........
  r64592 | vinay.sajip | 2008-06-29 16:25:28 -0500 (Sun, 29 Jun 2008) | 2 lines

  Removed out-of-date comment in _install_handlers and
  used issubclass in place of equality comparison of classes.
........
  r64593 | vinay.sajip | 2008-06-29 16:27:15 -0500 (Sun, 29 Jun 2008) | 1 line

  Updated to reflect change in logging.config to remove out-of-date comment in _install_handlers and the use of issubclass in place of equality comparison of classes.
........
  r64625 | georg.brandl | 2008-07-01 14:59:00 -0500 (Tue, 01 Jul 2008) | 2 lines

  Add a link to PEP 324.
........
  r64630 | georg.brandl | 2008-07-01 15:18:10 -0500 (Tue, 01 Jul 2008) | 2 lines

  #3216: fix Execute's parameter description.
........
  r64638 | georg.brandl | 2008-07-01 15:50:02 -0500 (Tue, 01 Jul 2008) | 2 lines

  #1410739: add a footnote about "is" and "unusual" behavior.
........
  r64647 | benjamin.peterson | 2008-07-01 18:33:06 -0500 (Tue, 01 Jul 2008) | 1 line

  add ABC to the glossary
........
  r64655 | mark.dickinson | 2008-07-02 04:37:01 -0500 (Wed, 02 Jul 2008) | 7 lines

  Replace occurrences of '\d' with '[0-9]' in Decimal regex, to make sure
  that the behaviour of Decimal doesn't change if/when re.UNICODE becomes
  assumed in Python 3.0.

  Also add a check that alternative Unicode digits (e.g. u'\N{FULLWIDTH
  DIGIT ONE}') are *not* accepted in a numeric string.
........
  r64656 | nick.coghlan | 2008-07-02 08:09:19 -0500 (Wed, 02 Jul 2008) | 1 line

  Issue 3190: pydoc now hides module __package__ attributes
........
  r64663 | jesse.noller | 2008-07-02 11:44:09 -0500 (Wed, 02 Jul 2008) | 1 line

  Reenable the manager tests with Amaury's threading fix
........
  r64664 | facundo.batista | 2008-07-02 11:52:55 -0500 (Wed, 02 Jul 2008) | 4 lines


  Issue #449227: Now with the rlcompleter module, callable objects are
  added a '(' when completed.
........
2008-07-02 20:22:54 +00:00
Amaury Forgeot d'Arc 200ff1853b Revert a bad change I made in r64209, which probably broke compilation on win64 2008-07-02 19:49:38 +00:00
Benjamin Peterson dcf97b98ec Merged revisions 64434-64435,64440-64443,64445,64447-64448,64450,64452,64455,64461,64464,64466,64468 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64434 | andrew.kuchling | 2008-06-20 18:13:58 -0500 (Fri, 20 Jun 2008) | 1 line

  Remove request for e-mail; it's unlikely these classes will be saved
........
  r64435 | andrew.kuchling | 2008-06-20 18:14:32 -0500 (Fri, 20 Jun 2008) | 1 line

  Grammar fixes
........
  r64440 | andrew.kuchling | 2008-06-21 08:29:12 -0500 (Sat, 21 Jun 2008) | 1 line

  Docstring typo
........
  r64441 | andrew.kuchling | 2008-06-21 08:47:20 -0500 (Sat, 21 Jun 2008) | 1 line

  Use repr() for bad input strings; this makes the empty string or binary characters more visible
........
  r64442 | andrew.kuchling | 2008-06-21 08:48:38 -0500 (Sat, 21 Jun 2008) | 1 line

  Docstring correction
........
  r64443 | georg.brandl | 2008-06-21 09:26:19 -0500 (Sat, 21 Jun 2008) | 2 lines

  Documentation fix.
........
  r64445 | facundo.batista | 2008-06-21 12:30:06 -0500 (Sat, 21 Jun 2008) | 3 lines


  Reviewed and updated the documentation. Fixes #3017.
........
  r64447 | facundo.batista | 2008-06-21 13:58:04 -0500 (Sat, 21 Jun 2008) | 6 lines


  Now a from submitted via POST that also has a query string
  will contain both FieldStorage and MiniFieldStorage items.

  Fixes #1817.
........
  r64448 | facundo.batista | 2008-06-21 14:48:19 -0500 (Sat, 21 Jun 2008) | 5 lines


  In the deprecated functions I added an alert to review
  specially a section of the subprocess documentation
  that helps with the replacing of those functionss.
........
  r64450 | georg.brandl | 2008-06-22 04:05:29 -0500 (Sun, 22 Jun 2008) | 2 lines

  Turn section references into proper cross-references.
........
  r64452 | facundo.batista | 2008-06-22 08:36:20 -0500 (Sun, 22 Jun 2008) | 5 lines


  Issue #2722. Now the char buffer to support the path string has
  not fixed length, it mallocs memory if needed. As a result, we
  don't have a maximum for the getcwd() method.
........
  r64455 | facundo.batista | 2008-06-22 10:27:10 -0500 (Sun, 22 Jun 2008) | 4 lines


  Issue 3164. Small fix to don't repeat a comparation
  without necessity.
........
  r64461 | georg.brandl | 2008-06-22 13:11:52 -0500 (Sun, 22 Jun 2008) | 2 lines

  #3085: Fix syntax error.
........
  r64464 | georg.brandl | 2008-06-22 13:31:54 -0500 (Sun, 22 Jun 2008) | 2 lines

  Expand docstrings of sqlite3 functions.
........
  r64466 | georg.brandl | 2008-06-22 14:07:59 -0500 (Sun, 22 Jun 2008) | 2 lines

  Write out "phi" consistently.
........
  r64468 | facundo.batista | 2008-06-22 14:35:24 -0500 (Sun, 22 Jun 2008) | 4 lines


  Just returning nothing instead of rising TestSkipped, because
  it makes the test fail in the trunk.loewis-sun buildbot.
........
2008-07-02 17:30:14 +00:00
Benjamin Peterson f9c98b48bd sync whatsnew with 2.6 2008-07-02 16:19:28 +00:00
Benjamin Peterson 14654fdbbd I'm blocking all these whatsnew revisions, so I can just manually sync it with 2.6;
merging it has gotten quite out of hand

Blocked revisions 64429,64436,64498,64572 via svnmerge

........
  r64429 | georg.brandl | 2008-06-20 14:28:18 -0500 (Fri, 20 Jun 2008) | 2 lines

  Change references to the new math functions to generate proper x-refs.
........
  r64436 | andrew.kuchling | 2008-06-20 18:43:12 -0500 (Fri, 20 Jun 2008) | 1 line

  Various items
........
  r64498 | mark.dickinson | 2008-06-24 06:08:58 -0500 (Tue, 24 Jun 2008) | 4 lines

  Change description of float('nan') feature; NaNs don't care much about
  signs, and float('nan'), float('+nan') and float('-nan') actually all
  generate the exact same NaN value.
........
  r64572 | benjamin.peterson | 2008-06-28 08:18:14 -0500 (Sat, 28 Jun 2008) | 1 line

  fix typo
........
2008-07-02 16:18:39 +00:00
Benjamin Peterson fea6a94b3b Merged revisions 64365,64370,64406,64408-64409,64412,64416-64417,64420-64421,64425-64428 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64365 | raymond.hettinger | 2008-06-17 19:56:57 -0500 (Tue, 17 Jun 2008) | 1 line

  Fix double decref.
........
  r64370 | mark.dickinson | 2008-06-18 04:20:17 -0500 (Wed, 18 Jun 2008) | 2 lines

  Typo fix
........
  r64406 | andrew.kuchling | 2008-06-19 09:02:30 -0500 (Thu, 19 Jun 2008) | 1 line

  Only include update_lines_cols() function when it's actually going to be used
........
  r64408 | amaury.forgeotdarc | 2008-06-19 14:57:39 -0500 (Thu, 19 Jun 2008) | 2 lines

  test_macos can be skipped on non-mac platforms.
........
  r64409 | andrew.kuchling | 2008-06-19 15:33:31 -0500 (Thu, 19 Jun 2008) | 1 line

  Put threading in front of thread
........
  r64412 | amaury.forgeotdarc | 2008-06-19 16:17:12 -0500 (Thu, 19 Jun 2008) | 3 lines

  In test_site, correctly escape backslashes in path names.
  This allows the test to pass when the username begins with a lowercase 't'...
........
  r64416 | vinay.sajip | 2008-06-19 17:40:17 -0500 (Thu, 19 Jun 2008) | 2 lines

  Bug #3136: fileConfig()'s disabling of old loggers is now conditional via an optional disable_existing_loggers parameter, but the default value is such that the old behaviour is preserved.
  Thanks to Leandro Lucarella for the patch.
........
  r64417 | vinay.sajip | 2008-06-19 17:41:08 -0500 (Thu, 19 Jun 2008) | 1 line

  Updated with fix for #3136.
........
  r64420 | andrew.kuchling | 2008-06-19 21:05:57 -0500 (Thu, 19 Jun 2008) | 1 line

  Various items
........
  r64421 | andrew.kuchling | 2008-06-19 21:11:42 -0500 (Thu, 19 Jun 2008) | 1 line

  Fix comment typos
........
  r64425 | andrew.kuchling | 2008-06-20 06:39:54 -0500 (Fri, 20 Jun 2008) | 1 line

  Various items
........
  r64426 | mark.dickinson | 2008-06-20 09:53:43 -0500 (Fri, 20 Jun 2008) | 4 lines

  Issue #3004:  Minor fix to slice.indices().  slice(-10).indices(9) now
  returns (0, 0, 1) instead of (0, -1, 1), and slice(None, 10, -1).indices(10)
  returns (9, 9, -1) instead of (9, 10, -1).
........
  r64427 | mark.dickinson | 2008-06-20 10:17:41 -0500 (Fri, 20 Jun 2008) | 2 lines

  Fix outdated count of the number of new math module functions.
........
  r64428 | mark.dickinson | 2008-06-20 10:26:19 -0500 (Fri, 20 Jun 2008) | 2 lines

  Fix another typo in math_sum comment
........
2008-07-02 16:11:42 +00:00
Benjamin Peterson 464109a893 Blocked revisions 64398,64400,64437,64456,64462,64511 via svnmerge
........
  r64398 | barry.warsaw | 2008-06-18 20:48:07 -0500 (Wed, 18 Jun 2008) | 1 line

  Bumping to 2.6b1
........
  r64400 | barry.warsaw | 2008-06-18 21:31:54 -0500 (Wed, 18 Jun 2008) | 1 line

  Post release changes
........
  r64437 | andrew.kuchling | 2008-06-20 19:17:22 -0500 (Fri, 20 Jun 2008) | 1 line

  Correct two versionchanged directives, to improve the 'changes' output
........
  r64456 | facundo.batista | 2008-06-22 11:11:34 -0500 (Sun, 22 Jun 2008) | 4 lines


  Trying to see if the @ in a path is causing the issue in the
  shutil.rmtree() in the trunk.loewis-sun buildbot.
........
  r64462 | facundo.batista | 2008-06-22 13:23:55 -0500 (Sun, 22 Jun 2008) | 4 lines


  Trying to see if the problem in Martin's buildot is at
  directory creation time...
........
  r64511 | raymond.hettinger | 2008-06-24 10:58:53 -0500 (Tue, 24 Jun 2008) | 1 line

  Issue 3189:  Py3k DeprecationWarning in difflib
........
2008-07-02 15:15:37 +00:00
Benjamin Peterson 1cef37cd0d add an entry for object.__dir__ 2008-07-02 14:44:54 +00:00
Brett Cannon 549845b5f5 Blocked revisions 64649 via svnmerge
........
  r64649 | brett.cannon | 2008-07-01 18:57:08 -0700 (Tue, 01 Jul 2008) | 8 lines

  Handle urllib's renaming for Python 3.0:

  * Deprecate urllib.urlopen() in favor of urllib2.urlopen() for 3.0.
  * Update docs to mention split/rename of the module and deprecation of
    urlopen().

  Changes to lib2to3 are in a separate commit. Work is for issue #2885.
........
2008-07-02 01:57:57 +00:00
Amaury Forgeot d'Arc 251d3e2d45 Blocked revisions 64633 via svnmerge
........
  r64633 | amaury.forgeotdarc | 2008-07-01 22:38:04 +0200 (mar., 01 juil. 2008) | 5 lines

  #3242: fix a crash in "print", if sys.stdout is set to a custom object,
  whose write() method installs another sys.stdout.

  Will backport.
........
2008-07-01 20:48:50 +00:00
Georg Brandl efbcb46d7f Blocked revisions 64635 via svnmerge
........
  r64635 | georg.brandl | 2008-07-01 22:45:09 +0200 (Tue, 01 Jul 2008) | 2 lines

  #1523853: add note about fread().
........
2008-07-01 20:46:09 +00:00
Georg Brandl 809ddaaafb #3191: fix round() docs and docstring. 2008-07-01 20:39:59 +00:00
Benjamin Peterson 13b6d0df63 fix test_metaclass 2008-07-01 20:26:36 +00:00
Georg Brandl 336341f2ae Add some full stops. 2008-07-01 20:21:28 +00:00
Georg Brandl 18da8f06eb #3220: improve bytes docs a bit. 2008-07-01 20:08:02 +00:00
Benjamin Peterson 07a1f94fb7 Merged revisions 64622 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r64622 | benjamin.peterson | 2008-07-01 14:34:52 -0500 (Tue, 01 Jul 2008) | 1 line

  #3219 repeated keyword arguments aren't allowed in function calls anymore
........
2008-07-01 20:03:27 +00:00
Georg Brandl 13e89463e3 Fix a few urllib bugs (NameErrors).
Also directly import names from the various urllib submodules,
saves attribute lookup and is much cleaner.
2008-07-01 19:56:00 +00:00
Georg Brandl 1abcbf8e19 #2683: Popen.communicate() argument must be bytes. 2008-07-01 19:28:43 +00:00
Benjamin Peterson c22ed14ddd document PyUnicode_CompareWithASCIIString 2008-07-01 19:12:34 +00:00
Georg Brandl e11787a4e8 #2683: communicate() takes bytes. 2008-07-01 19:10:52 +00:00
Benjamin Peterson de9c869fb8 Hopefully fix make framework install on Mac (see 3174)
Removal of the Mac modules broke many of the Mac scripts (including
BuildApplet.py) so the building of the Python launcher and IDLE.app was
broken. I manually copied built versions of those apps into Mac. Everything else
which used Mac modules had to die.
2008-07-01 18:23:09 +00:00