Mirror
/
ardupilot
mirror of https://github.com/ArduPilot/ardupilot
5
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

github: remove elf_diff from checks we run 

We had previous discussed removing this as it was very-little-used.

Today this workflow died because elf_diff failed to install:

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/local/lib/python3.8/dist-packages/elf_diff/__main__.py", line 23, in <module>
    from elf_diff.pair_report_document import generateDocument, ValueTreeNode
  File "/usr/local/lib/python3.8/dist-packages/elf_diff/pair_report_document.py", line 34, in <module>
    import elf_diff.binary as binary
  File "/usr/local/lib/python3.8/dist-packages/elf_diff/binary.py", line 27, in <module>
    from elf_diff.instruction_collector import InstructionCollector
  File "/usr/local/lib/python3.8/dist-packages/elf_diff/instruction_collector.py", line 28, in <module>
    import progressbar  # type: ignore # Make mypy ignore this module
  File "/usr/local/lib/python3.8/dist-packages/progressbar/__init__.py", line 5, in <module>
    from .bar import DataTransferBar
  File "/usr/local/lib/python3.8/dist-packages/progressbar/bar.py", line 13, in <module>
    from python_utils import types
  File "/usr/local/lib/python3.8/dist-packages/python_utils/__init__.py", line 1, in <module>
    from . import (
  File "/usr/local/lib/python3.8/dist-packages/python_utils/aio.py", line 8, in <module>
    from . import types
  File "/usr/local/lib/python3.8/dist-packages/python_utils/types.py", line 4, in <module>
    from typing_extensions import *  # type: ignore  # noqa: F403
ModuleNotFoundError: No module named 'typing_extensions'
This commit is contained in:
Peter Barker 2023-05-29 12:13:23 +10:00 committed by Peter Barker
parent e415b5fda0
commit 6429295869
1 changed files with 0 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
.github/workflows/test_size.yml vendored
View File

@ -303,43 +303,3 @@ jobs:
shell: bash shell: bash
run: | run: |
diff -r $GITHUB_WORKSPACE/base_branch_bin_no_versions $GITHUB_WORKSPACE/pr_bin_no_versions --exclude=*.elf --exclude=*.apj || true diff -r $GITHUB_WORKSPACE/base_branch_bin_no_versions $GITHUB_WORKSPACE/pr_bin_no_versions --exclude=*.elf --exclude=*.apj || true
- name: elf_diff compare with ${{ github.event.pull_request.base.ref }}
shell: bash
run: |
# we don't use weasyprint so manually pull the elf_diff deps reduce install size and time
python3 -m pip install -U --no-deps elf_diff GitPython Jinja2 MarkupSafe PyYAML anytree dict2xml gitdb progressbar2 python-utils setuptools-git smmap
mkdir elf_diff
BIN_PREFIX="arm-none-eabi-"
if [ "${{ matrix.toolchain }}" = "armhf" ]; then
BIN_PREFIX="arm-linux-gnueabihf-"
fi
BOOTLOADER=0
AP_PERIPH=0
if [ "${{matrix.config}}" = "Hitec-Airspeed" ] ||
[ "${{matrix.config}}" = "f103-GPS" ]; then
AP_PERIPH=1
elif [ "${{matrix.config}}" = "MatekF405-CAN" ] ||
[ "${{matrix.config}}" = "DrotekP3Pro" ]; then
BOOTLOADER=1
fi
if [ $AP_PERIPH -eq 1 ]; then
TO_CHECK="AP_Periph"
elif [ $BOOTLOADER -eq 1 ]; then
TO_CHECK="AP_Bootloader"
else
TO_CHECK="arduplane arducopter"
fi
for CHECK in $TO_CHECK; do
python3 -m elf_diff --bin_prefix="$BIN_PREFIX" --html_dir=elf_diff/$CHECK $GITHUB_WORKSPACE/base_branch_bin/$CHECK $GITHUB_WORKSPACE/pr_bin/$CHECK
done
zip -r elf_diff.zip elf_diff
- name: Archive elf_diff output
uses: actions/upload-artifact@v3
with:
name: ELF_DIFF_${{matrix.config}}
path: elf_diff.zip
retention-days: 14