Commit Graph

15951 Commits

Author SHA1 Message Date
Brian Curtin f991642efe Fix #6378. Start IDLE using the proper version of Python based on the directory
tree that idle.bat resides in.

Works with any/all versions of Python installed concurrently.
2010-11-21 23:45:10 +00:00
Michael Foord 086f30815c Issue 10470: 'python -m unittest' launches test discovery by default.(If you need to pass options to test discovery the discover subcommand must still be specified explicitly.) 2010-11-21 21:28:01 +00:00
Antoine Pitrou 3bce11cbbd Make test_nntplib more robust 2010-11-21 17:14:19 +00:00
R. David Murray 719a449ba6 Fix TestBytesGeneratorIdempotent tests and a couple bugs they revealed.
The tests that were failing on (some) windows machines, where the
msg_XX.txt files used native \r\n lineseps are now also run on machines
that use \n natively, and conversely the \n tests are run on Windows.
The failing tests revealed one place where linesep needed to be added
to a flatten call in generator.  There was also another that the tests
didn't catch, so I added a test for that case as well.
2010-11-21 16:53:48 +00:00
Senthil Kumaran e4dad4f8e2 Fix issue3709 - BaseHTTPRequestHandler will buffer the headers and write only on end_headers call. 2010-11-21 14:36:14 +00:00
Łukasz Langa a73dc9d5e8 configparser: read-only attributes to get the section name and parser from a SectionProxy instance 2010-11-21 13:56:42 +00:00
Łukasz Langa 5c86339bd0 Issue #10489: removed broken `__name__` support from configparser 2010-11-21 13:41:35 +00:00
Raymond Hettinger d325c4b233 Revert r86517 2010-11-21 04:08:28 +00:00
Nick Coghlan e0f04659cd Issue #10220: Add inspect.getgeneratorstate(). Initial patch by Rodolpho Eckhardt 2010-11-21 03:44:04 +00:00
Éric Araujo a491cedaf4 Try to get more useful output from failing buildbot 2010-11-21 02:19:09 +00:00
Benjamin Peterson d57bb55c7d fix two broken tests 2010-11-20 23:03:34 +00:00
Benjamin Peterson 8d16ab3c56 merge all range tests into test_range 2010-11-20 23:01:55 +00:00
Benjamin Peterson 94ab7a0864 enable test that was commented out for whatever reason 2010-11-20 22:50:04 +00:00
Benjamin Peterson 0b458d52f9 count() should return integers #10474 2010-11-20 22:35:41 +00:00
Éric Araujo 2e579f0a87 Fix typos and style in compileall. 2010-11-20 21:53:02 +00:00
R. David Murray 650f147298 #10453: compileall now uses argparse instead of getopt, so -h works.
Patch by Michele Orrù.
2010-11-20 21:18:51 +00:00
Georg Brandl 74abf6f873 #9724: add nonlocal to pydoc topics. 2010-11-20 19:54:36 +00:00
Éric Araujo ff1144eb34 Fix two NameErrors in distutils (#10407) 2010-11-20 19:35:27 +00:00
Benjamin Peterson b1cb105bde revert changes in inappropiate branch 2010-11-20 19:09:08 +00:00
Ezio Melotti b3aedd4862 #9424: Replace deprecated assert* methods in the Python test suite. 2010-11-20 19:04:17 +00:00
Benjamin Peterson b8bc439b20 don't shadow globals 2010-11-20 18:24:54 +00:00
Alexander Belopolsky 44454afbe3 Issue #10371: Deprecated undocumented functions in the trace module. 2010-11-20 18:21:07 +00:00
Benjamin Peterson 5f78040057 add filename to ENOENT message #4925 2010-11-20 18:07:52 +00:00
Benjamin Peterson fa73555cfc correct logic when pos is after the string #10467 2010-11-20 17:24:04 +00:00
Michael Foord 6bcfadec07 Improve unittest.TestLoader.discover docstring 2010-11-20 17:22:21 +00:00
Benjamin Peterson 5c41787f13 add space 2010-11-20 17:22:13 +00:00
Senthil Kumaran 5e703cf32b Fix issue10377 - Output from pstats - it is just secs (i.e, wallclock time) and not CPU time. 2010-11-20 17:02:50 +00:00
Michael Foord 35184edd3d Issue 9732: __class__ no longer checked on objects by getattr_static 2010-11-20 16:58:30 +00:00
Michael Foord e516265bbc Issue 9732: fetch the method resolution order from the type metaclass directly in getattr_static 2010-11-20 16:40:44 +00:00
R. David Murray 6bb9989ae3 #1574217: only swallow AttributeErrors in isinstance, not everything.
Patch and tests by Brian Harring, with improvements by Ralf Schmitt.
2010-11-20 16:33:30 +00:00
Michael Foord cc7ebb8f69 Issue 9732: remove use of __class__ in inspect.getattr_static and note the mro exception to code execution 2010-11-20 16:20:16 +00:00
Łukasz Langa c264c098d0 configparser: the name of the DEFAULT section is now customizable 2010-11-20 16:15:37 +00:00
Michael Foord b357fb7bed Issue 10326: further extend test for unpickling to ensure type lookup mechanism works after unpickling 2010-11-20 15:47:56 +00:00
Michael Foord 8a00eec2a8 Issue 10326: extend test for pickling of TestCase instances to ensure they can be unpickled too 2010-11-20 15:43:02 +00:00
Michael Foord 8ca6d9884b Issue 10326: TestCase instances can now be pickled (they store names of instance methods instead of references to the instance methods themselves). 2010-11-20 15:34:26 +00:00
R. David Murray e5db2636f3 Improve TestBytesGeneratorIdempotent using by using linesep.
Also corrects a typo from a previous commit.  Unfortunately
this does *not* fix issue #10134.
2010-11-20 15:10:13 +00:00
Michael Foord 95fc51dfda Issue 9732: addition of getattr_static to the inspect module 2010-11-20 15:07:30 +00:00
Georg Brandl 89197fe93c socket.gethostbyname(socket.gethostname()) can fail when host name resolution is not set up correctly; do not fail test_socket if this is the case. 2010-11-20 14:16:17 +00:00
Georg Brandl 9f1c1dcde3 #10465: fix broken delegation in __getattr__ of _PaddedFile. 2010-11-20 11:25:01 +00:00
Mark Dickinson 4ccc137aff Issue #9920: Skip tests for cmath.atan and cmath.atanh applied to
complex zeros on systems where the log1p function fails to respect
the sign of zero.  This fixes a test failure on AIX.
2010-11-20 11:08:27 +00:00
Brian Quinlan b304d0b46f Fixes a timing-related failure on Windows (issue 10183) 2010-11-20 04:09:35 +00:00
R. David Murray 722b5fdbb8 Make test class name unique so that both test classes run. 2010-11-20 03:48:58 +00:00
Benjamin Peterson 5b066817e2 use %R format code; fixes invalid dereferencing #10391 2010-11-20 01:38:49 +00:00
Antoine Pitrou 98b644ff3f Fix test_ssl_presence when ssl is not present 2010-11-19 20:07:52 +00:00
Antoine Pitrou de609186fc Wrap all test_nntplib methods accessing a remote server in a transient_internet()
exception catcher.  Wrapping the initial connection routine is not sufficient
as network timeouts can then occur as part of NNTP commands.
2010-11-18 17:29:23 +00:00
Senthil Kumaran 6a0b5c414c Code Changes as per review comments by Antoine Pitrou. 2010-11-18 17:08:48 +00:00
Senthil Kumaran daa29d01b7 Fix Issue2244 - urllib unquotes user and password info multiple times - Patch by Theodore Turocy 2010-11-18 15:36:41 +00:00
Stefan Krah d8b661dd90 Issue #10356: hash(Decimal("sNaN")) now raises ValueError instead of TypeError. 2010-11-18 15:20:34 +00:00
Antoine Pitrou d28f790b69 Make test_nntplib more robust when the "last" article in a group can't be retrieved 2010-11-18 15:11:43 +00:00
Senthil Kumaran 8ce1f1ff83 Fix Issue 9991: xmlrpc client ssl check faulty 2010-11-18 15:00:53 +00:00
Benjamin Peterson 29bd840dee reduce try block compass 2010-11-18 14:14:43 +00:00
Kristján Valur Jónsson 6331520950 Issue 10260
Adding the wait_for() method to threading.Condition
2010-11-18 12:46:39 +00:00
Brett Cannon 0ffe6a9760 Fix a minor inconsistency in capitalization for the 'No module named' exception
message in importlib.

Thanks to Éric Araujo for spotting the inconsistency.
2010-11-18 03:03:04 +00:00
Brian Curtin 8fb9b868bd Fix #8886. Use context managers throughout the test. 2010-11-18 02:15:28 +00:00
Alexander Belopolsky a47bbf5a4b Issue #10446: Several changes to module documentation generated by pydoc:
1. Online reference manual link is now version-specific and the
   'MODULE DOCS' section renamed to 'MODULE REFERENCE'.

2. 'FILE' section is moved to the end of the file.

3. Special names processed by pydoc such as __version__ or __credits__
   are now excluded from the DATA section.

4. Defined __all__ to prevent pydoc from exposing undocumented details
   about itself.

5. Removed Python 2.3 compatibility code.
2010-11-18 01:52:54 +00:00
Benjamin Peterson f609654b0e handle dict subclasses gracefully in PyArg_ValidateKeywordArguments 2010-11-17 22:33:12 +00:00
Antoine Pitrou 12ae290bf3 Use laxer timeouts in barrier tests 2010-11-17 21:55:41 +00:00
Antoine Pitrou 664c2d1fc0 Issue #10443: Add the SSLContext.set_default_verify_paths() method. 2010-11-17 20:29:42 +00:00
Antoine Pitrou b6d4ee5361 Issue #10440: Support RUSAGE_THREAD as a constant in the resource module.
Patch by Robert Collins.
2010-11-17 16:19:35 +00:00
Stefan Krah dc817b229c Issue #10356: Decimal(-1).__hash__() should equal hash(Decimal(-1)). 2010-11-17 11:16:34 +00:00
Brian Quinlan 3ec60183a4 Removes an inefficient spin loop in as_completed 2010-11-17 11:06:29 +00:00
Antoine Pitrou dbe7519da9 Issue #10429: IMAP.starttls() stored the capabilities as bytes objects,
rather than strings.
2010-11-16 17:55:26 +00:00
Antoine Pitrou 36c0dbc9be Avoid some BytesWarnings when running test_imaplib in verbose mode 2010-11-16 17:49:46 +00:00
Vinay Sajip 8593ae6451 Logging: added stack_info argument. 2010-11-14 21:33:04 +00:00
Senthil Kumaran 74ebd9e6a3 Fix Issue5111 - Wrap the Ipv6 host with [] in the Host header 2010-11-13 12:27:49 +00:00
Mark Dickinson 5ccafbadda Streamline a cmath test (and fix some overlong lines into the bargain). 2010-11-13 10:43:40 +00:00
Mark Dickinson fec6620dfb Make Fraction(-1).__hash__() return -2 rather than -1 (see issue 10356). 2010-11-13 10:27:38 +00:00
Georg Brandl 24854cac99 Bump to 3.2a4. 2010-11-13 06:39:58 +00:00
Georg Brandl 1fd63dc7ac Update pydoc topics. 2010-11-13 06:36:58 +00:00
Antoine Pitrou 45ca987495 Switch from gmane to another provider for NNTP tests (as gmane isn't reliable
enough).  Also, use setUpClass in order to connect only once per test run.
2010-11-13 00:28:53 +00:00
Éric Araujo 67a93ae4ed And now for something completely different: Finish fixing #10252 again. 2010-11-12 22:25:23 +00:00
Antoine Pitrou f3b001f966 Issue #4471: Add the IMAP.starttls() method to enable encryption on
standard IMAP4 connections.  Original patch by Lorenzo M. Catucci.
2010-11-12 18:49:16 +00:00
R. David Murray 6495136e40 #1466065: add validate option to base64.b64decode
Patch by Neil Tallim.  This provides a mechanism for module
users to achieve RFC 3548 compliance in the cases where ignoring
non-base64-alphabet input characters is *not* mandated by the RFC that
references RFC 3548.
2010-11-11 20:09:20 +00:00
Łukasz Langa 49afa380fd configparser.py: changed PendingDeprecationWarnings to DeprecationWarnings, via http://mail.python.org/pipermail/python-dev/2010-November/105391.html
configparser:py: renamed _views to _proxies to be consistent with the SectionProxy name
2010-11-11 19:53:23 +00:00
Alexander Belopolsky b9d10d08c4 Issue #10386: Added __all__ to token module; this simplifies importing
in tokenize module and prevents leaking of private names through
import *.
2010-11-11 14:07:41 +00:00
Antoine Pitrou 8d9a4e66c2 Disable test_python_builders in test_xmlrpc_net, following buildbot upgrade on python.org 2010-11-10 22:36:43 +00:00
Łukasz Langa 26d513cf2f Issue #5412: extend configparser to support mapping access 2010-11-10 18:57:39 +00:00
Antoine Pitrou cf9f98034a Issue #10372: Import the warnings module only after the IO library is
initialized, so as to avoid bootstrap issues with the '-W' option.
2010-11-10 13:55:25 +00:00
Antoine Pitrou 81c87c5e9a Followup to r86383: it seems that in some cases (buildbots), the server
closes the connection before we can call shutdown().
2010-11-10 08:59:25 +00:00
Antoine Pitrou dac47914d7 Forward port r86386 after it fixed the 3.1 buildbot issues 2010-11-10 00:18:40 +00:00
Antoine Pitrou d79f3c8b3a Issue #4471: Properly shutdown socket in IMAP.shutdown(). Patch by
Lorenzo M. Catucci.
2010-11-09 23:10:33 +00:00
Antoine Pitrou b1436f185d Fix IMAP.login() to work properly.
Also, add remote tests for imaplib (part of #4471).
2010-11-09 22:55:55 +00:00
Antoine Pitrou adffced3df Preserve the original environment (e.g. LD_LIBRARY_PATH) 2010-11-09 22:04:44 +00:00
Antoine Pitrou 9bc35682de Use script_helper in one more test 2010-11-09 21:33:55 +00:00
Ask Solem 2afcbf2249 Issue #9244: multiprocessing.pool: Worker crashes if result can't be encoded 2010-11-09 20:55:52 +00:00
Antoine Pitrou fb0469112f Issue #10022: The dictionary returned by the `getpeercert()` method
of SSL sockets now has additional items such as `issuer` and `notBefore`.
2010-11-09 20:21:19 +00:00
Antoine Pitrou 859c4ef0a0 Make `usenetrc` False by default (the old behaviour of having it True by
default could be rather confusing).
2010-11-09 18:58:42 +00:00
Antoine Pitrou 1cb121ecea Issue #1926: Add support for NNTP over SSL on port 563, as well as
STARTTLS.  Patch by Andrew Vant.
2010-11-09 18:54:37 +00:00
Victor Stinner 3e2b7171bf Issue #10359: Remove ";" after function definition, invalid in ISO C 2010-11-09 09:32:19 +00:00
Raymond Hettinger 572895b8eb Simplify code 2010-11-09 03:43:58 +00:00
Senthil Kumaran ec30b3dd8c Fix Issue10205 - XML QName error when different tags have same QName. 2010-11-09 02:36:59 +00:00
Victor Stinner 92665ab8c7 test_tokenize: use self.assertEqual() instead of plain assert 2010-11-09 01:11:31 +00:00
Victor Stinner 58c0752a33 Issue #10335: Add tokenize.open(), detect the file encoding using
tokenize.detect_encoding() and open it in read only mode.
2010-11-09 01:08:59 +00:00
Alexander Belopolsky 18c33737f8 Fixed unit test failure on Windows 2010-11-08 23:10:20 +00:00
Antoine Pitrou ea510eba1a Fix memory consumption advertised by some test cases 2010-11-08 21:40:13 +00:00
Antoine Pitrou d7ae299e4b Fix test_hashlib with the bigmem option 2010-11-08 20:36:57 +00:00
Alexander Belopolsky 6672ea9424 Streamlined code in trace.Ignore and added unit tests. 2010-11-08 18:32:40 +00:00
R. David Murray 7dff9e08fb #10321: Add support for sending binary DATA and Message objects to smtplib 2010-11-08 17:15:13 +00:00
Antoine Pitrou d95c7b5f8a Issue #10347: ignore leading test count ("[ 1/340]") when using the -f option to regrtest. 2010-11-07 20:50:51 +00:00
Victor Stinner 64bc3b28a3 Issue #10329: The trace module writes reports using the input Python script
encoding, instead of the locale encoding. Patch written by Alexander
Belopolsky.
2010-11-07 15:47:36 +00:00
Victor Stinner bb4f218050 os module: remove nonbreaking space in a comment 2010-11-07 15:43:39 +00:00
Mark Dickinson a837aa6213 Update assertComplexIdentical to handle nans correctly. 2010-11-07 15:31:41 +00:00
Victor Stinner be3da38e0a Issue #10337: skip tests of tanh() sign in test_math and test_cmath if tanh()
doesn't preserve the zero sign (if TANH_PRESERVES_ZERO_SIGN define is 0).
2010-11-07 14:14:27 +00:00
Mark Dickinson baa0f0510e Add a dtoa.c test value that triggered a bug in recent versions of
Gay's dtoa.c (but not for current versions of Python's dtoa.c).
Thanks Rick Regan for finding and reporting this.
2010-11-07 10:01:46 +00:00
Victor Stinner 2e598faade test_concurrent_futures: remove temporary hack 2010-11-07 04:36:56 +00:00
Éric Araujo 7c03d8c5c6 Fix #10252 again (hopefully definitely). Patch by Brian Curtin. 2010-11-06 18:03:52 +00:00
Éric Araujo 8bdbe9c52f Correct the fix for #10252: Popen objects have no close method. 2010-11-06 15:57:52 +00:00
Eric Smith 72f6620859 Removed unused test classes from test_format_map(). 2010-11-06 14:43:26 +00:00
Victor Stinner 7322fcf84b test_concurrent_futures: dump ulimit -a to check a failure on x86 FreeBSD 7.2 3.x, buildbot 2010-11-06 13:10:29 +00:00
Victor Stinner 273b766870 os.get_exec_path() ignores BytesWarning instead of recoding them
Use only one global warning.catch_warnings() context, instead of two local
contexts. Improve also the explaination why the function uses a local import.
2010-11-06 12:59:33 +00:00
Éric Araujo 45ee43be43 Remove traces of Mac OS 9 support, again (#9508).
This was done in r80805 (#7908) and erroneously brought back by the
distutils revert.  This commit removes more code than the original,
which was uncomplete.  There is no NEWS entry, like in r80805.
2010-11-06 06:00:54 +00:00
Éric Araujo ba7209f0a5 Prevent race condition with mkdir in distutils. Patch by Arfrever on #9281. 2010-11-06 04:48:05 +00:00
Éric Araujo 7fa886df36 Prevent ResourceWarnings in test_gettext 2010-11-06 04:11:59 +00:00
Éric Araujo 37a89334da Fix caching error found by regrtest -R (#10229) 2010-11-06 04:09:29 +00:00
Éric Araujo 70ec44a773 Make sure each test can be run standalone (./python Lib/distutils/tests/x.py) 2010-11-06 02:44:43 +00:00
Éric Araujo 1c5054996f Fix one omission in r78359 2010-11-06 02:12:51 +00:00
Éric Araujo 5ac6d80c02 Also close file descriptors from os.popen and subprocess.Popen 2010-11-06 02:10:32 +00:00
Alexander Belopolsky 25b5741383 Issue #10330: trace module can now be used with python built without threads. 2010-11-06 01:31:16 +00:00
Brian Curtin ecd34cbbb8 Clear up ResourceWarnings 2010-11-06 01:30:41 +00:00
Éric Araujo 5fd730e0fb Of course, I forgot one file in r86223. 2010-11-05 23:59:32 +00:00
Éric Araujo bee5cef7db Always close files in distutils code and tests (#10252). 2010-11-05 23:51:56 +00:00
Antoine Pitrou 243757eb79 Issue #10180: Pickling file objects is now explicitly forbidden, since
unpickling them produced nonsensical results.
2010-11-05 21:15:39 +00:00
Antoine Pitrou 4a5f9677f3 Output served URL when running ssl_servers 2010-11-05 20:26:59 +00:00
Antoine Pitrou 66c95c745b Fix test_httplib when built without threads 2010-11-05 20:17:55 +00:00
Antoine Pitrou db1bad2d70 Fix bootstrap issues when building without threads 2010-11-05 19:58:28 +00:00
Antoine Pitrou a078115434 Issue #10282: Add a `nntp_implementation` attribute to NNTP objects. 2010-11-05 19:16:37 +00:00
Brian Curtin de11b189d1 Close subprocess pipes to clean up ResourceWarnings 2010-11-05 17:22:46 +00:00
Brian Curtin 19a5379c97 Fix a number of ResourceWarnings on Windows due to open pipes. 2010-11-05 17:09:05 +00:00
Brian Curtin 5ad0bd69c9 Add socket cleanup for ResourceWarning and update test to use skip decorator 2010-11-05 15:47:45 +00:00
Brian Curtin ab747a7daa Fix ResourceWarning from subprocess pipes being left open. 2010-11-05 15:40:27 +00:00
Brian Curtin 994ad6c775 Fix ResourceWarning from subprocess pipe. 2010-11-05 15:38:47 +00:00
Brian Curtin 43ec577e2c Close subprocess pipes in _kill. Fixes a number of ResourceWarnings. 2010-11-05 15:17:11 +00:00
Brian Curtin cbad4df179 Close subprocess pipes in the non-UNIX section of run_cgi.
Clears a number of ResourceWarnings in test_httpservers.
2010-11-05 15:04:48 +00:00
Brian Curtin 69cd87b5fa Shift the pipe-using code into an else block, then close the pipe
in finally. Removes two ResourceWarnings.
2010-11-05 14:48:35 +00:00
Brian Curtin 3c6a951cfb Add cleanups to stdout/stderr pipes to remove ResourceWarnings. 2010-11-05 03:58:52 +00:00
Antoine Pitrou 08eeadac27 Issue #10283: Add a `group_pattern` argument to NNTP.list(). 2010-11-04 21:36:15 +00:00
Antoine Pitrou 99c4830d0c Issue #3699: Fix test_bigaddrspace and extend it to test bytestrings
as well as unicode strings.  Initial patch by Sandro Tosi.
2010-11-04 20:48:37 +00:00
Antoine Pitrou aeb6ceead7 Issue #10293: Remove obsolete field in the PyMemoryView structure,
unused undocumented value PyBUF_SHADOW, and strangely-looking code in
PyMemoryView_GetContiguous.
2010-11-04 20:30:33 +00:00
Eric Smith 27bbca6f79 Issue #6081: Add str.format_map. str.format_map(mapping) is similar to str.format(**mapping), except mapping does not get converted to a dict. 2010-11-04 17:06:58 +00:00
Hirokazu Yamamoto 3cdd5cb959 Issue #5391: mmap.read_byte() should return unsigned value [0, 255]
instead of signed value [-127, 128].
2010-11-04 12:09:08 +00:00
Brian Curtin 3beb38f8ff Fix three ResourceWarnings.
Mimic the clientTearDown from ThreadedTCPSocketTest, closing the socket.
2010-11-04 03:41:43 +00:00
Benjamin Peterson b82c8e5b27 classic classes are gone; whoppie! 2010-11-04 00:38:49 +00:00
Phillip J. Eby b6d4a8e4de Implement http://bugs.python.org/issue10155 using And Clover's patch, w/added
docs and support for more client-generated CGI variables.  (This should
complete the WSGI 1.0.1 compliance changes for Python 3.x.)
2010-11-03 22:39:01 +00:00
Antoine Pitrou 4103bc09a4 Issue #10281: nntplib now returns None for absent fields in the OVER/XOVER
response, instead of raising an exception.
2010-11-03 18:18:43 +00:00
Antoine Pitrou 0eee1f588c Disabling SNI test; server admin would not like us to use it for automated tests. 2010-11-03 08:53:25 +00:00
Phillip J. Eby a01799f71a Update docs (and sample app in wsgiref.simple_server) to reflect PEP 3333. 2010-11-03 00:46:45 +00:00
Antoine Pitrou 0d1b38cef9 Issue #10173: test_multiprocessing shouldn't pickle TestCase instances 2010-11-02 23:50:11 +00:00
Antoine Pitrou f80b3f72c6 Issue #10280: NNTP.nntp_version should reflect the highest version
advertised by the server.
2010-11-02 22:31:52 +00:00
Phillip J. Eby e159422ce9 Update wsgiref for PEP 3333, and fix errors introduced into the test suite by converting type() checks to isinstance().
(When WSGI specifies a built-in type, it does NOT mean "this type or a subclass" -- it means 'type(x) is SpecifiedType'.)
2010-11-02 22:28:59 +00:00
Benjamin Peterson 5a43f72d1b remove some things that are now tested 2010-11-02 21:54:20 +00:00