d7d58ebfc8
Merged revisions 82075 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r82075 | jean-paul.calderone | 2010-06-18 16:00:17 -0400 (Fri, 18 Jun 2010) | 12 lines
Revert r60115
This revision introduced quoting for strings containing | based
on a misunderstanding of the commonly used quoting rules used
on Windows.
| is interpreted by cmd.exe, not by the MS C runtime argv initializer.
It only needs to be quoted if it is part of an argument passed through
cmd.exe.
See issue1300, issue7839, and issue8972.
........
2010-06-18 20:10:12 +00:00
f7b5def8b4
Merged revisions 81179 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r81179 | victor.stinner | 2010-05-14 23:52:26 +0200 (ven., 14 mai 2010) | 2 lines
Fix regression introduced by r81154 (Issue #5099 , subprocess destructor)
........
2010-05-14 21:53:32 +00:00
b565ac8776
Merged revisions 81154 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r81154 | brett.cannon | 2010-05-13 17:21:48 -0700 (Thu, 13 May 2010) | 15 lines
subprocess.Popen.__del__ referenced global objects, which is a no-no thanks to
interpreter shutdown semantics. Same issue goes for the methods that __del__
called. Now all the methods capture the global objects it needs as default
values to private parameters (could have stuck them on the class object itself,
but since the objects have nothing directly to do with the class that seemed
wrong).
There is no test as making one that works is hard. This patch was
verified against a consistently failing test in Mercurial's test suite, though,
so it has been tested in some regard.
Closes issue #5099 . Thanks to Mary Stern for the bug report and Gabriel
Genellina for writing another patch for the same issue and attempting to write
a test.
........
2010-05-14 01:26:08 +00:00
520c834fbb
Merged revisions 80439 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r80439 | brian.curtin | 2010-04-24 10:40:11 -0500 (Sat, 24 Apr 2010) | 6 lines
Fix #7838 . Add docstrings and privatize _subprocess implementation details.
Since CREATE_NEW_* are used for the creation flags of a subprocess, they
were added to __all__. The rest of the previously exposed attributes are
now qualified by _subprocess.ATTR rather than importing *.
........
2010-04-24 15:59:50 +00:00
953fe5f7e7
Merged revisions 76538,76559,76882-76883,76886,76891-76892,76920,76924-76925,77081,77084,77086,77092 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r76538 | georg.brandl | 2009-11-26 21:48:25 +0100 (Do, 26 Nov 2009) | 1 line
#7400 : typo.
........
r76559 | georg.brandl | 2009-11-28 12:11:50 +0100 (Sa, 28 Nov 2009) | 1 line
Fix versions and spacing.
........
r76882 | georg.brandl | 2009-12-19 18:30:28 +0100 (Sa, 19 Dez 2009) | 1 line
#7527 : use standard versionadded tags.
........
r76883 | georg.brandl | 2009-12-19 18:34:32 +0100 (Sa, 19 Dez 2009) | 1 line
#7521 : remove Py_GetBuildNumber(), which was removed in favor of Py_GetBuildInfo().
........
r76886 | georg.brandl | 2009-12-19 18:43:33 +0100 (Sa, 19 Dez 2009) | 1 line
#7493 : review of Design FAQ by Florent Xicluna.
........
r76891 | georg.brandl | 2009-12-19 19:16:31 +0100 (Sa, 19 Dez 2009) | 1 line
#7479 : add note about function availability on Unices.
........
r76892 | georg.brandl | 2009-12-19 19:20:18 +0100 (Sa, 19 Dez 2009) | 1 line
#7480 : remove tautology.
........
r76920 | georg.brandl | 2009-12-20 15:20:16 +0100 (So, 20 Dez 2009) | 1 line
#7495 : backport Programming FAQ review to trunk.
........
r76924 | georg.brandl | 2009-12-20 15:28:05 +0100 (So, 20 Dez 2009) | 1 line
Small indentation fix.
........
r76925 | georg.brandl | 2009-12-20 15:33:20 +0100 (So, 20 Dez 2009) | 1 line
#7381 : subprocess documentation and library docstring consistency fixes.
........
r77081 | georg.brandl | 2009-12-28 08:59:05 +0100 (Mo, 28 Dez 2009) | 1 line
#7577 : fix signature of PyBuffer_FillInfo().
........
r77084 | georg.brandl | 2009-12-28 09:01:59 +0100 (Mo, 28 Dez 2009) | 1 line
#7586 : fix typo.
........
r77086 | georg.brandl | 2009-12-28 09:09:32 +0100 (Mo, 28 Dez 2009) | 1 line
#7381 : consistency update, and backport avoiding ``None >= 0`` check from py3k.
........
r77092 | georg.brandl | 2009-12-28 09:48:24 +0100 (Mo, 28 Dez 2009) | 1 line
#7404 : remove reference to non-existing example files.
........
2010-03-21 19:06:51 +00:00
ca57499b72
Merged revisions 78523 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r78523 | gregory.p.smith | 2010-02-28 16:05:08 -0800 (Sun, 28 Feb 2010) | 3 lines
Issue #1068268 : The subprocess module now handles EINTR in internal
os.waitpid and os.read system calls where appropriate.
........
2010-03-01 00:35:34 +00:00
f4b581ed25
Merged revisions 76168 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r76168 | eric.smith | 2009-11-09 10:16:23 -0500 (Mon, 09 Nov 2009) | 1 line
Issue 7294: Fixed URL in a comment.
........
2009-11-09 15:20:16 +00:00
7865296ca3
Merged revisions 75143 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r75143 | philip.jenvey | 2009-09-29 12:10:15 -0700 (Tue, 29 Sep 2009) | 5 lines
#5329 : fix os.popen* regression from 2.5: don't execute commands as a sequence
through the shell. also document the correct subprocess replacement for this
case
patch from Jean-Paul Calderone and Jani Hakala
........
2009-09-29 19:18:11 +00:00
07638b9085
Issue #6274 . Fixed a potential FD leak in subprocess.py.
2009-06-19 19:51:26 +00:00
857c00e0fd
Merged revisions 70137 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r70137 | hirokazu.yamamoto | 2009-03-04 07:18:14 +0900 | 1 line
Issue #5179 : Fixed subprocess handle leak on failure on windows.
........
2009-03-03 22:55:00 +00:00
78162daff6
Merged revisions 69620 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r69620 | georg.brandl | 2009-02-14 18:01:36 +0100 (Sa, 14 Feb 2009) | 1 line
#5179 : don't leak PIPE fds when child execution fails.
........
2009-02-14 17:04:26 +00:00
03446c43ca
Remove warnings generated for the suprocess module when run under -3. Required
...
commenting out True/False compatbility stuff, remove a use of apply(), and
remove a use of buffer() (just pulled the solution used in 3.0 which is direct
slicing).
2008-08-08 04:19:32 +00:00
a36f8fefb0
- Issue #1857 : subprocess.Popen.poll gained an additional _deadstate keyword
...
argument in python 2.5, this broke code that subclassed Popen to include its
own poll method. Fixed my moving _deadstate to an _internal_poll method.
2008-08-04 00:13:29 +00:00
f41406409e
- Issue #2113 : Fix error in subprocess.Popen if the select system call is
...
interrupted by a signal.
2008-07-06 07:16:40 +00:00
4036fd4b75
Fixes issue2791: subprocess.Popen.communicate leaked a file descripton until
...
the last reference to the Popen instance was dropped. Adding explicit
close() calls fixes it.
Candidate for backport to release25-maint.
2008-05-26 20:22:14 +00:00
e74c8f2879
Added kill, terminate and send_signal to subprocess.Popen
...
The bits and pieces for the Windows side were already in place. The POSIX side is trivial (as usual) and uses os.kill().
2008-04-19 02:23:57 +00:00
70eb2f91b4
Fix issue 1300: Quote command line arguments that contain a '|' character in
...
subprocess.list2cmdline (windows).
2008-01-19 22:49:37 +00:00
92ffc634e4
Undo an unnecessary else: and indentation that r60104 added.
...
try:
...
except:
...
raise
else:
...
the else: is unecessary due to the blind except: with a raise.
2008-01-19 22:23:56 +00:00
87d49792b5
Fixes issue1336 - a race condition could occur when forking if the gc
...
kicked in during the critical section. solution: disable gc during
that section. Patch contributed by jpa and updated by me to cover the
race condition still existing what therve from twistedmatrix pointed
out (already seen and fixed in twisted's own subprocess code).
2008-01-19 20:57:59 +00:00
e047e6dd09
fix comment typos, use not arg instead of arg == "", add test coverage
...
for inside of the final if needquotes: within subprocess.list2cmdline().
2008-01-19 20:49:02 +00:00
309501a617
#1663329 : add os.closerange() to close a range of fds,
...
ignoring errors, and use this in subprocess to speed up
subprocess creation in close_fds mode. Patch by Mike Klaas.
2008-01-19 20:22:13 +00:00
81a191b351
Applied patch 1669481, slightly modified: Support close_fds on Win32
2007-05-26 22:18:20 +00:00
82be218e97
Remove trailing whitespace in docstring
2007-05-11 06:56:52 +00:00
aa87fb6be4
Fix typo in docstring (the module is popen2, not 3).
2007-05-11 06:23:01 +00:00
24522982d0
Bug #1704790 : bind name "sys" locally in __del__ method so that it is
...
not cleared before __del__ is run.
2007-04-21 20:35:38 +00:00
ea5962f86e
Whitespace normalization.
2007-03-12 18:07:52 +00:00
5f9c6ae545
Applied patch 1124861.3.patch to solve bug #1124861 : Automatically create pipes on Windows, if GetStdHandle fails. Will backport.
2007-02-06 15:37:50 +00:00
f54000325b
We had several if statements checking the value of a fd. This is unsafe, since valid fds might be zero. We should check for not None instead.
2007-02-02 19:06:36 +00:00
f733abb783
Whitespace normalization.
2007-01-30 03:03:46 +00:00
10514a70ac
Fix for bug #1634343 : allow specifying empty arguments on Windows
2007-01-13 22:35:35 +00:00
1812f8cf3f
Avoid O(N**2) bottleneck in _communicate_(). Fixes #1598181 .
2007-01-07 14:34:16 +00:00
ec05a2d580
Re-implemented fix for #1531862 once again, in a way that works with Python 2.2. Fixes bug #1603424 .
2007-01-07 08:53:46 +00:00
a186ee22c0
SF bug #1623890 , fix argument name in docstring
2006-12-29 03:01:53 +00:00
6c0e1e8673
Bug #1357915 : allow all sequence types for shell arguments in
...
subprocess.
2006-10-29 09:05:04 +00:00
c36bede6ff
Fixed subprocess bug #1531862 again, after removing tests
...
offending buildbot
2006-09-07 00:48:33 +00:00
314bef9fff
Revert 51758 because it broke all the buildbots
2006-09-06 03:58:34 +00:00
8cb64eaaf3
Fixing #1531862 : Do not close standard file descriptors in the
...
subprocess module.
2006-09-06 01:58:52 +00:00
13cf38c0cf
Guard for _active being None in __del__ method.
2006-07-20 16:28:39 +00:00
73a9eade1c
Whitespace normalization.
2006-07-18 21:55:15 +00:00
7d1d43630e
Bug #1223937 : CalledProcessError.errno -> CalledProcessError.returncode.
2006-07-14 14:04:45 +00:00
8440483fea
Fix doco. Backport candidate.
2006-07-10 00:05:34 +00:00
ff355f1ada
Applied patch #1506758 : Prevent MemoryErrors with large MAXFD.
2006-06-22 20:21:26 +00:00
ad62489e47
Bug #1500293 : fix memory leaks in _subprocess module.
2006-06-04 22:15:37 +00:00
a6d01cec3f
Try to fix breakage caused by patch #1479181 , r45850
2006-05-02 06:23:22 +00:00
17de8ffc21
Patch #1467770 : Add Popen objects to _active only in __del__.
...
Introduce _child_active member to keep track on whether a child
needs to be waited for.
Backport candidate.
2006-04-10 15:55:37 +00:00
3a708dfc88
Changed license header: Now simply referring to PSF. This closes bug
...
1138653.
2005-09-23 17:37:29 +00:00
eba28bea9b
Whitespace normalization.
2005-03-28 01:08:02 +00:00
7e78ade6f9
Corrected bug in list2cmdline wrt backslashes. Fixes #1083306 .
2005-03-03 21:10:23 +00:00
23109f0009
Optimization for communicate(): If only one of stdin/stdout/stderr is
...
redirected, using select() or threads is unnecessary.
2005-03-03 20:28:59 +00:00
c26516b29d
Made the module compatible with Python 2.2 again.
2005-02-21 08:13:02 +00:00
Jean-Paul Calderone
Victor Stinner
Brett Cannon
Brian Curtin
Georg Brandl
Gregory P. Smith
Eric Smith
Philip Jenvey
Facundo Batista
Hirokazu Yamamoto
Christian Heimes
Peter Astrand
Neal Norwitz
Tim Peters
Gustavo Niemeyer
Martin v. Löwis