cpython

Commit Graph

Author	SHA1	Message	Date
Berker Peksag	64b9a15886	[3.6] bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions (GH-3) Cython will, in the right circumstances, offer a MethodType instance where im_func is a builtin function. Any instance of MethodType is automatically assumed to be a Python-defined function (more specifically, a function that has an inspectable signature), but _set_signature was still conservative in its assumptions. As a result _set_signature would return early with None instead of a mock since the im_func had no inspectable signature. This causes problems deeper inside mock, as _set_signature is assumed to _always_ return a mock, and nothing checked its return value. In similar corner cases, autospec will simply not check the spec of the function, so _set_signature is amended to now return early with the original, not-wrapped mock object. Patch by Aaron Gallagher. (cherry picked from commit `856cbcc12f`)	2017-07-22 01:31:04 +03:00
Berker Peksag	fae59e1aa8	bpo-28961: Address my comments from earlier code review (#306 ) (cherry picked from commit `dea1536fd3`)	2017-02-26 16:05:30 +03:00
Victor Stinner	84b6fb0eea	Fix unittest.mock._Call: don't ignore name Issue #28961: Fix unittest.mock._Call helper: don't ignore the name parameter anymore. Patch written by Jiajun Huang.	2017-01-06 18:15:51 +01:00
Gregory P. Smith	9854789efe	Issue #26750 : unittest.mock.create_autospec() now works properly for subclasses of property() and other data descriptors.	2016-08-07 08:52:26 -07:00
Serhiy Storchaka	bc39869095	Issue #19594 : Use specific asserts in unittest tests.	2013-11-17 00:14:35 +02:00
Serhiy Storchaka	5665bc5980	Issue #19594 : Use specific asserts in unittest tests.	2013-11-17 00:12:21 +02:00
Antoine Pitrou	5c64df70b5	Issue #17015 : When it has a spec, a Mock object now inspects its signature when matching calls, so that arguments can be matched positionally or by name.	2013-02-03 00:23:58 +01:00
Michael Foord	75963643b1	Fix exception when calling reset_mock on a mock created with autospec	2012-06-09 17:31:59 +01:00
Michael Foord	3af125a4aa	Closes issue 14634. unittest.mock.create_autospec now supports keyword only arguments.	2012-04-21 18:22:28 +01:00
Michael Foord	656319e58d	Make unittest.mock.create_autospec resilient against AttributeError on original object	2012-04-13 17:39:16 +01:00
Michael Foord	c287062fcf	unittest.mock.PropertyMock return value and attributes are now standard MagicMocks	2012-04-13 16:57:22 +01:00
Michael Foord	345266aa7e	PEP 417: Adding unittest.mock	2012-03-14 12:24:34 -07:00

12 Commits