6b4953fd3d
Check returned pointer is valid.
...
Klocwork #233
2006-08-12 02:06:34 +00:00
b45f351832
I'm not sure why this code allocates this string for the error message.
...
I think it would be better to always use snprintf and have the format
limit the size of the name appropriately (like %.200s).
Klocwork #340
2006-08-12 01:57:47 +00:00
ef0de023db
Try to handle a malloc failure. I'm not entirely sure this is correct.
...
There might be something else we need to do to handle the exception.
Klocwork # 212-213
2006-08-12 01:53:28 +00:00
9cd3c34b6a
Move the assert which checks for a NULL pointer first.
...
Klocwork #274 .
2006-08-12 01:51:12 +00:00
e0a81afb10
If _stat_float_times is false, we will try to INCREF ival which could be NULL.
...
Return early in that case. The caller checks for PyErr_Occurred so this
should be ok.
Klocwork #297
2006-08-12 01:50:38 +00:00
6f5ff3f3eb
Klocwork made another run and found a bunch more problems.
...
This is the first batch of fixes that should be easy to verify based on context.
This fixes problem numbers: 220 (ast), 323-324 (symtable),
321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree).
2006-08-12 01:43:40 +00:00
2a899c8b76
When a ctypes C callback function is called, zero out the result
...
storage before converting the result to C data. See the comment in
the code for details.
Provide a better context for errors when the conversion of a callback
function's result cannot be converted.
2006-08-11 19:55:35 +00:00
789c09d2cd
Update dangling references to the 3.2 database to
...
mention that this is UCD 4.1 now.
2006-08-10 19:04:00 +00:00
534fe18e17
Bug #1535081 : A leading underscore has been added to the names of
...
the md5 and sha modules, so add it in Modules/Setup.dist too.
2006-08-06 07:26:21 +00:00
e6c9f982a0
Fix #1530559 , struct.pack raises TypeError where it used to convert.
...
Passing float arguments to struct.pack when integers are expected
now triggers a DeprecationWarning.
2006-08-04 23:59:21 +00:00
e9462c72bd
Change fix for segfaulting property(), add a NEWS entry and a test.
2006-08-04 18:03:37 +00:00
961b91bd3c
Correction of patch #1455898 : In the mbcs decoder, set final=False
...
for stream decoder, but final=True for the decode function.
2006-08-02 13:53:55 +00:00
9b0ca79213
Patch #1519025 and bug #926423 : If a KeyboardInterrupt occurs during
...
a socket operation on a socket with a timeout, the exception will be
caught correctly. Previously, the exception was not caught.
2006-08-02 06:46:21 +00:00
c0328d17a5
v is already checked for NULL, so just DECREF it
2006-08-02 06:15:10 +00:00
c5e060dee6
_PyWeakref_GetWeakrefCount() now returns a Py_ssize_t instead of long.
2006-08-02 06:14:22 +00:00
99dfe3c411
Prevent memory leak on error.
...
Reported by Klocwork #36
2006-08-02 04:27:11 +00:00
d61d0733cb
Speed up PyType_stgdict and PyObject_stgdict.
2006-08-01 19:14:15 +00:00
11d68a6ac4
Minimal useful docstring for CopyComPointer.
2006-08-01 17:46:10 +00:00
3de83e9b61
Fix a potential segfault and various potentail refcount leaks
...
in the cast() function.
2006-08-01 16:54:43 +00:00
07aadb14f3
Add PyErr_WarnEx() so C code can pass the stacklevel to warnings.warn().
...
This provides the proper warning for struct.pack().
PyErr_Warn() is now deprecated in favor of PyErr_WarnEx().
As mentioned by Tim Peters on python-dev.
2006-07-30 06:55:48 +00:00
8d9a01a1f2
Tweak wording
2006-07-29 15:43:13 +00:00
1393d6a4ca
Patch #1529514 : More openbsd platforms for ctypes.
...
Regenerated Modules/_ctypes/libffi/configure with autoconf 2.59.
Approved by Neal.
2006-07-28 21:43:20 +00:00
944f3b6ecb
Remove a useless XXX comment.
...
Cosmetic changes to the code so that the #ifdef _UNICODE block
doesn't mess emacs code formatting.
2006-07-28 19:42:40 +00:00
cddabbf98a
Fix spelling.
2006-07-28 18:36:01 +00:00
ec9265094a
Allow socketmodule to compile on NetBSD -current, whose bluetooth API
...
differs from both Linux and FreeBSD. Accepted by Neal Norwitz.
2006-07-28 11:27:27 +00:00
641cddf0fa
- pybsddb Bug #1527939 : bsddb module DBEnv dbremove and dbrename
...
methods now allow their database parameter to be None as the
sleepycat API allows.
Also adds an appropriate test case for DBEnv.dbrename and dbremove.
2006-07-28 01:35:25 +00:00
5566e96830
defdict_reduce(): Plug leaks.
...
We didn't notice these before because test_defaultdict didn't
actually do anything before Georg fixed that earlier today.
Neal's next refleak run then showed test_defaultdict leaking
9 references on each run. That's repaired by this checkin.
2006-07-28 00:23:15 +00:00
00decd7835
Patch #1520294 : Support for getset and member descriptors in types.py,
...
inspect.py, and pydoc.py. Specifically, this allows for querying the type of
an object against these built-in C types and more importantly, for getting
their docstrings printed in the interactive interpreter's help() function.
This patch includes a new built-in module called _types which provides
definitions of getset and member descriptors for use by the types.py module.
These types are exposed as types.GetSetDescriptorType and
types.MemberDescriptorType. Query functions are provided as
inspect.isgetsetdescriptor() and inspect.ismemberdescriptor(). The
implementations of these are robust enough to work with Python implementations
other than CPython, which may not have these fundamental types.
The patch also includes documentation and test suite updates.
I commit these changes now under these guiding principles:
1. Silence is assent. The release manager has not said "no", and of the few
people that cared enough to respond to the thread, the worst vote was "0".
2. It's easier to ask for forgiveness than permission.
3. It's so dang easy to revert stuff in svn, that you could view this as a
forcing function. :)
Windows build patches will follow.
2006-07-27 23:43:15 +00:00
37f694f21b
No functional change. Add comment and assert to describe why there cannot be overflow which was reported by Klocwork. Discussed on python-dev
2006-07-27 04:04:50 +00:00
a1da20472f
Correct error message
2006-07-26 17:18:01 +00:00
55b0a0eb0d
[Bug #1471938 ] Fix build problem on Solaris 8 by conditionalizing the use of mvwgetnstr(); it was conditionalized a few lines below. Fix from Paul Eggert. I also tried out the STRICT_SYSV_CURSES case and am therefore removing the 'untested' comment.
2006-07-26 17:16:52 +00:00
5f135787ec
Part of bug #1523610 : fix miscalculation of buffer length.
...
Also add a guard against NULL in converttuple and add a test case
(that previously would have crashed).
2006-07-26 08:03:10 +00:00
982e9fea0a
Bug #1524310 : Properly report errors from FindNextFile in os.listdir.
...
Will backport to 2.4.
2006-07-24 12:54:17 +00:00
dce937f32c
Ensure we don't write beyond errText. I think I got this right, but
...
it definitely could use some review to ensure I'm not off by one
and there's no possible overflow/wrap-around of bytes_left.
Reported by Klocwork #1 .
Fix a problem if there is a failure allocating self->db.
Found with failmalloc.
2006-07-23 08:01:43 +00:00
9029b5f289
nextlink can be NULL if teedataobject_new fails, so use XINCREF.
...
Ensure that dataobj is never NULL.
Reported by Klocwork #102
2006-07-23 07:59:00 +00:00
98a96004f9
Fix memory leaks spotted by Klocwork #37 .
2006-07-23 07:57:11 +00:00
93f2ca1f85
Check the allocation of b_objects and return if there was a failure.
...
Also fix a few memory leaks in other failure scenarios.
It seems that if b_objects == Py_None, we will have an extra ref to
b_objects. Add XXX comment so hopefully someone documents why the
else isn't necessary or adds it in.
Reported by Klocwork #20
2006-07-23 07:55:55 +00:00
b59d08c2fb
Fix more memory allocation issues found with failmalloc.
2006-07-22 16:20:49 +00:00
468e45edc1
Remove an XXX marker in a comment.
2006-07-21 22:44:07 +00:00
100a4e944b
Make sure the _ctypes extension can be compiled when WITH_THREAD is
...
not defined on Windows, even if that configuration is probably not
supported at all.
2006-07-19 09:09:32 +00:00
caebe22038
Fix bug #1520914 . Starting in 2.4, time.strftime() began to check the bounds
...
of values in the time tuple passed in. Unfortunately people came to rely on
undocumented behaviour of setting unneeded values to 0, regardless of if it was
within the valid range. Now those values force the value internally to the
minimum value when 0 is passed in.
2006-07-18 04:41:36 +00:00
5eaf772980
Fix memory leaks in some conditions.
...
Reported by Klocwork #152 .
2006-07-16 02:15:27 +00:00
109f91414f
proto was dereffed above and is known to be good. No need for X.
...
Reported by Klocwork, #39 .
2006-07-16 02:05:35 +00:00
ce5b3c3188
self is dereffed (and passed as first arg), so it's known to be good.
...
func is returned from PyArg_ParseTuple and also dereffed.
Reported by Klocwork, #30 (self one at least).
2006-07-16 02:02:57 +00:00
ce049a0aef
Patch #1521817 : The index range checking on ctypes arrays containing
...
exactly one element is enabled again.
2006-07-14 17:51:14 +00:00
9f902470da
Make the prototypes of our private PyUnicode_FromWideChar and
...
PyUnicode_AsWideChar replacement functions compatible to the official
functions by using Py_ssize_t instead of int.
2006-07-14 15:01:05 +00:00
b4dc2ef5da
A misspelled preprocessor symbol caused ctypes to be always compiled
...
without thread support. Replaced WITH_THREADS with WITH_THREAD.
2006-07-13 09:53:47 +00:00
9dceedbb97
Accept long options "--help" and "--version".
2006-07-12 15:31:17 +00:00
41efc14498
Fix function name in error msg
2006-07-12 05:26:35 +00:00
3b9be2ae6f
Change the ctypes version number to 1.0.0.
2006-07-11 18:40:50 +00:00
93ab5fa191
#1494314 : Fix a regression with high-numbered sockets in 2.4.3. This
...
means that select() on sockets > FD_SETSIZE (typically 1024) work again.
The patch makes sockets use poll() internally where available.
2006-07-11 02:04:09 +00:00
7644262aa5
Assigning None to pointer type structure fields possible overwrote
...
wrong fields.
2006-07-10 11:11:10 +00:00
7b1da513fd
Fixed a segfault when ctypes.wintypes were imported on
...
non-Windows machines.
2006-07-10 09:31:06 +00:00
dda068dee1
Fix bug #1518190 : accept any integer or long value in the
...
ctypes.c_void_p constructor.
2006-07-10 09:10:28 +00:00
2a30cd0ef0
Patch #1516912 : improve Modules support for OpenVMS.
2006-07-10 01:18:57 +00:00
5becdbee96
Patch #1517790 : It is now possible to use custom objects in the ctypes
...
foreign function argtypes sequence as long as they provide a
from_param method, no longer is it required that the object is a
ctypes type.
2006-07-06 08:48:35 +00:00
43d9a58dfd
Revert the change done in svn revision 47206:
...
Add a new function uses_seh() to the _ctypes extension module. This
will return True if Windows Structured Exception handling (SEH) is
used when calling functions, False otherwise.
2006-07-06 07:50:18 +00:00
24a0f41d83
- back out Expat change; the final fix to Expat will be different
...
- change the pyexpat wrapper to not be so sensitive to this detail of the
Expat implementation (the ex-crasher test still passes)
2006-07-06 05:13:22 +00:00
9ba7ca8229
Fix the bitfield test when _ctypes is compiled with MingW. Structures
...
containing bitfields may have different layout on MSVC and MingW .
2006-07-05 09:13:56 +00:00
b4a6a566ff
Sync the darwin/x86 port libffi with the copy in PyObjC. This fixes a number
...
of bugs in that port. The most annoying ones were due to some subtle differences
between the document ABI and the actual implementation :-(
(there are no python unittests that fail without this patch, but without it
some of libffi's unittests fail).
2006-07-04 12:30:22 +00:00
74c3ea0a0f
Fix build problems with the platform SDK on windows. It is not sufficient to test for the C compiler version when determining if we have the secure CRT from microsoft. Must test with an undocumented macro, __STDC_SECURE_LIB__ too.
2006-07-03 14:59:05 +00:00
f780be4239
Add a new function uses_seh() to the _ctypes extension module. This
...
will return True if Windows Structured Exception handling (SEH) is
used when calling functions, False otherwise.
Currently, only MSVC supports SEH.
Fix the test so that it doesn't crash when run with MingW compiled
_ctypes. Note that two tests are still failing when mingw is used, I
suspect structure layout differences and function calling conventions
between MSVC and MingW.
2006-07-03 08:08:14 +00:00
638f7addf3
Fixes so that _ctypes can be compiled with the MingW compiler.
...
It seems that the definition of '__attribute__(x)' was responsible for
the compiler ignoring the '__fastcall' attribute on the
ffi_closure_SYSV function in libffi_msvc/ffi.c, took me quite some
time to figure this out.
2006-07-03 08:04:05 +00:00
dd854e917f
Cleanup: Remove commented out code.
2006-07-03 07:58:09 +00:00
ee1e06d497
Correct arithmetic in access on Win32. Fixes #1513646 .
2006-07-02 18:44:00 +00:00
762fbd3485
The sqlite3 module did cut off data from the SQLite database at the first null
...
character before sending it to a custom converter. This has been fixed now.
2006-07-02 17:48:30 +00:00
6ffe499397
SF bug #1296433 (Expat bug #1515266 ): Unchecked calls to character data
...
handler would cause a segfault. This merges in Expat's lib/xmlparse.c
revisions 1.154 and 1.155, which fix this and a closely related problem
(the later does not affect Python).
Moved the crasher test to the tests for xml.parsers.expat.
2006-07-01 16:28:20 +00:00
08612926a1
Remove now-unused fidding with PY_FORMAT_SIZE_T.
2006-06-30 18:34:51 +00:00
730199275a
Revert the use of PY_FORMAT_SIZE_T in PyErr_Format.
2006-06-30 17:44:54 +00:00
3f2748e775
Silence compiler warning
2006-06-30 07:32:16 +00:00
bde081329b
Protect the thread api calls in the _ctypes extension module within
...
#ifdef WITH_THREADS/#endif blocks. Found by Sam Rushing.
2006-06-29 18:34:15 +00:00
0f8b31a2da
Fix bug #1512695 : cPickle.loads could crash if it was interrupted with
...
a KeyboardInterrupt since PyTuple_Pack was passed a NULL.
Will backport.
2006-06-28 06:28:31 +00:00
624af829a7
[ 1295808 ] expat symbols should be namespaced in pyexpat
...
(http://python.org/sf/1295808 )
2006-06-19 23:57:41 +00:00
f08d663a2f
Upgrade pyexpat to expat 2.0.0 ( http://python.org/sf/1462338 ).
2006-06-19 23:21:25 +00:00
ecd2010951
Fixed a memory leak that was introduced with incorrect usage of the Python weak
...
reference API in pysqlite 2.2.1.
Bumbed pysqlite version number to upcoming pysqlite 2.3.1 release.
2006-06-19 21:17:35 +00:00
4994d9546c
Patch #1506645 : add Python wrappers for the curses functions
...
is_term_resized, resize_term and resizeterm. This uses three
separate configure checks (one for each function).
2006-06-19 08:07:50 +00:00
e75cad6125
Fix memory leak reported by valgrind while running test_subprocess
2006-06-17 22:38:15 +00:00
fe7d0c3bc6
Speculative checkin (requires approval of Gerhard Haering)
...
This backs out the test changes in 46962 which prevented crashes
by not running the tests via a version check. All the version checks
added in that rev were removed from the tests.
Code was added to the error handler in connection.c that seems
to work with older versions of sqlite including 3.1.3.
2006-06-15 04:54:29 +00:00
b2e8816403
- Added version checks in C code to make sure we don't trigger bugs in older
...
SQLite versions.
- Added version checks in test suite so that we don't execute tests that we
know will fail with older (buggy) SQLite versions.
Now, all tests should run against all SQLite versions from 3.0.8 until 3.3.6
(latest one now). The sqlite3 module can be built against all these SQLite
versions and the sqlite3 module does its best to not trigger bugs in SQLite,
but using SQLite 3.3.3 or later is recommended.
2006-06-14 22:28:37 +00:00
d825143be1
Patch #1455898 : Incremental mode for "mbcs" codec.
2006-06-14 05:21:04 +00:00
1541ef08af
Merged changes from external pysqlite 2.3.0 release. Documentation updates will
...
follow in a few hours at the latest. Then we should be ready for beta1.
2006-06-13 22:24:47 +00:00
6d7db6ecc4
Remove unused variable.
2006-06-13 16:06:55 +00:00
9291332de1
Patch #1454481 : Make thread stack size runtime tunable.
...
Heavily revised, comprising revisions:
46640 - original trunk revision (backed out in r46655)
46647 - markup fix (backed out in r46655)
46692:46918 merged from branch aimacintyre-sf1454481
branch tested on buildbots (Windows buildbots had problems
not related to these changes).
2006-06-13 15:04:24 +00:00
c2da994585
Add pep-291 compatibility markers.
2006-06-12 20:56:48 +00:00
f608317061
Fix the CRT argument error handling for VisualStudio .NET 2005. Install a CRT error handler and disable the assertion for debug builds. This causes CRT to set errno to EINVAL.
...
This update fixes crash cases in the test suite where the default CRT error handler would cause process exit.
2006-06-12 15:45:12 +00:00
81f444bb8e
Make the -m switch conform to the documentation of sys.path by behaving like the -c switch
2006-06-12 10:17:11 +00:00
ee3ea5418e
I don't know how that happend, but the entire file contents was
...
duplicated. Thanks to Simon Percivall for the heads up.
2006-06-12 06:05:57 +00:00
70ee3ccd1e
Get rid of function pointer cast.
2006-06-12 04:26:31 +00:00
6e73aaab47
Patch #1503046 , Conditional compilation of zlib.(de)compressobj.copy
...
copy is only in newer versions of zlib. This should allow zlibmodule
to work with older versions like the Tru64 buildbot.
2006-06-12 03:33:09 +00:00
a6d80faf6c
Impl ssize_t
2006-06-12 03:05:40 +00:00
047f3c7ffa
Fix some Py_ssize_t issues
2006-06-12 02:06:42 +00:00
c7074386b4
Fix some Py_ssize_t issues
2006-06-12 02:06:17 +00:00
09a29fae8f
Cleanup Py_ssize_t a little (get rid of second #ifdef)
2006-06-12 02:05:55 +00:00
0d5d222959
Release the GIL during COM method calls, to avoid deadlocks in
...
Python coded COM objects.
2006-06-11 17:04:22 +00:00
3c5431e132
Wrap some long lines
...
Top/Bottom factor out some common expressions
Add a XXX comment about widing offset.
2006-06-11 05:45:25 +00:00
b4fcf8d787
Fix Coverity # 146. newDBSequenceObject would deref dbobj, so it can't be NULL.
...
We know it's not NULL from the ParseTuple and DbObject_Check will verify
it's not NULL.
2006-06-11 05:44:18 +00:00
9af2b44805
Handle failure of PyMem_Realloc.
2006-06-10 22:01:50 +00:00
9123edcc63
Don't use C++ comment.
2006-06-10 21:56:03 +00:00
eb6dcf6b0d
Fix the second occurrence of the problematic printf format.
2006-06-10 21:17:58 +00:00
5218ab263a
Fix a wrong printf format.
2006-06-10 21:07:19 +00:00
Neal Norwitz
Thomas Heller
Martin v. Löwis
Georg Brandl
Bob Ippolito
Andrew M. Kuchling
Matt Fleming
Gregory P. Smith
Tim Peters
Barry Warsaw
Brett Cannon
Anthony Baxter
Fred Drake
Ronald Oussoren
Kristján Valur Jónsson
Gerhard Häring
Trent Mick
Walter Dörwald
Andrew MacIntyre
Nick Coghlan