Commit Graph

72 Commits

Author SHA1 Message Date
Florent Xicluna 3c919cf140 The SIGINT signal may happen earlier, during site.py initialization. 2010-03-23 19:19:16 +00:00
Florent Xicluna 446ff14827 The standard error should be empty when the signal is killed, except on SIGINT. 2010-03-23 15:05:30 +00:00
Florent Xicluna fc4d6d7763 Silence test_subprocess. 2010-03-23 14:36:45 +00:00
Florent Xicluna 637637021a Revert r78830: realpath() should really be applied to sys.executable. 2010-03-11 01:50:48 +00:00
Florent Xicluna e58d91c8f0 Fix the test_subprocess failure when sys.executable is meaningless: '' or a directory.
It does not fix #7774.
2010-03-11 00:56:59 +00:00
Florent Xicluna faf175385d Replace the stderr logging with assertNotEqual(returncode, 0). 2010-03-08 10:59:33 +00:00
Florent Xicluna 400efc2259 #2777: Try hard to make Win7 buildbot happy... 2010-03-07 17:12:23 +00:00
Florent Xicluna c083864fc8 Do not fail if returncode is 0 on send_signal/kill/terminate, for win32 platforms.
Do not hide the KeyboardInterrupt on POSIX platforms.
2010-03-07 15:27:39 +00:00
Florent Xicluna c02bbe328d #2777: Enable test_send_signal, test_terminate and test_kill on win32 platforms. 2010-03-07 12:21:36 +00:00
Florent Xicluna 632df993dc Skip test_send_signal, test_kill, test_terminate on win32 platforms, for 2.7a4 release. 2010-03-06 19:43:41 +00:00
Florent Xicluna aa90db9477 #2777: Apply same recipe on win32, i.e. do not inherit file handles. 2010-03-06 09:54:14 +00:00
Florent Xicluna af9a06a77f #2777: Apply same recipe for test_terminate and test_kill, i.e. close or redirect fds. 2010-03-06 00:16:57 +00:00
Florent Xicluna cecef392f1 #2777: Handle fds more carefully to try to fix some x86-Linux failures (namely, neal bot and twisted bot). 2010-03-05 19:31:21 +00:00
Florent Xicluna 7272acfabe These line should not be there. 2010-03-05 01:12:14 +00:00
Florent Xicluna d6935631da Let's use assertIsNone / assertIsNotNone. It's hype. 2010-03-05 01:05:55 +00:00
Florent Xicluna 80e0e2d2d8 Workaround #3137: Retry SIGINT if it is not received the first time.
test_send_signal should not hang anymore on various Linux distributions.
2010-03-05 00:47:40 +00:00
Florent Xicluna ab5e17f896 #2777: Enable test_send_signal, test_kill and test_terminate on all platforms. 2010-03-04 21:31:58 +00:00
Florent Xicluna bab22a7c6d Cleanup. 2010-03-04 19:40:48 +00:00
Gregory P. Smith c1baf4ac9e Fix the new test on windows (skip it, its posix only) 2010-03-01 02:53:24 +00:00
Gregory P. Smith cce211f88c Issue #1068268: The subprocess module now handles EINTR in internal
os.waitpid and os.read system calls where appropriate.
2010-03-01 00:05:08 +00:00
Florent Xicluna 78fd521f1a Fix an oversight in r78508: p.wait() should be compared to 0 2010-02-27 21:15:27 +00:00
Florent Xicluna 98e3fc39bf Clean test_subprocess: use assertRaises, skipIf, skipUnless helpers and a custom helper assertStderrEqual. 2010-02-27 19:20:50 +00:00
Ezio Melotti 8f6a287029 #7712: add a temp_cwd context manager to test_support and use it in regrtest to run all the tests in a temporary directory, saving the original CWD in test_support.SAVEDCWD. Thanks to Florent Xicluna who helped with the patch. 2010-02-10 21:40:33 +00:00
Ezio Melotti aa98058cc4 use assert[Not]In where appropriate 2010-01-23 23:04:36 +00:00
Amaury Forgeot d'Arc ce32eb7406 #6416: Fix compilation of the select module on Windows, as well as test_subprocess:
PIPE_BUF is not defined on Windows, and probably has no meaning there.

Anyway the subprocess module uses another way to perform non-blocking reads (with a thread)
2009-07-09 22:37:22 +00:00
Gregory P. Smith dd7ca24eb5 Use select.poll() in subprocess, when available, rather than select() so that
it does not fail when file descriptors are large.  Fixes issue3392.

Patch largely contributed by Frank Chu (fpmc) with some improvements by me.
See http://bugs.python.org/issue3392.

Candidate for backporting to release26-maint as it is a bug fix and changes no
public API.
2009-07-04 01:49:29 +00:00
Benjamin Peterson 5c8da86f3a convert usage of fail* to assert* 2009-06-30 22:57:08 +00:00
Georg Brandl f3715d2fc7 #5179: don't leak PIPE fds when child execution fails. 2009-02-14 17:01:36 +00:00
Gregory P. Smith 26576801a6 rename the new check_call_output to check_output. its less ugly. 2008-12-05 02:27:01 +00:00
Gregory P. Smith 97f49f4be7 Adds a subprocess.check_call_output() function to return the output from a
process on success or raise an exception on error.
2008-12-04 20:21:09 +00:00
Gregory P. Smith 4036fd4b75 Fixes issue2791: subprocess.Popen.communicate leaked a file descripton until
the last reference to the Popen instance was dropped.  Adding explicit
close() calls fixes it.

Candidate for backport to release25-maint.
2008-05-26 20:22:14 +00:00
Gregory P. Smith af8a68733f fix issue2381: test_subprocess fails if your sys.executable is on a
path with a space in it.
2008-05-17 07:17:34 +00:00
Christian Heimes c2ca6db143 Disabled some unit tests for the upcoming release. See #2777 2008-05-06 23:42:58 +00:00
Christian Heimes e74c8f2879 Added kill, terminate and send_signal to subprocess.Popen
The bits and pieces for the Windows side were already in place. The POSIX side is trivial (as usual) and uses os.kill().
2008-04-19 02:23:57 +00:00
Gregory P. Smith 70eb2f91b4 Fix issue 1300: Quote command line arguments that contain a '|' character in
subprocess.list2cmdline (windows).
2008-01-19 22:49:37 +00:00
Gregory P. Smith e047e6dd09 fix comment typos, use not arg instead of arg == "", add test coverage
for inside of the final if needquotes: within subprocess.list2cmdline().
2008-01-19 20:49:02 +00:00
Guido van Rossum e9a0e885db Patch #1672 by Joseph Armbruster. Use tempdir() to get a temporary directory. 2007-12-20 17:28:10 +00:00
Peter Astrand 81a191b351 Applied patch 1669481, slightly modified: Support close_fds on Win32 2007-05-26 22:18:20 +00:00
Peter Astrand 10514a70ac Fix for bug #1634343: allow specifying empty arguments on Windows 2007-01-13 22:35:35 +00:00
Gustavo Niemeyer c36bede6ff Fixed subprocess bug #1531862 again, after removing tests
offending buildbot
2006-09-07 00:48:33 +00:00
Neal Norwitz 314bef9fff Revert 51758 because it broke all the buildbots 2006-09-06 03:58:34 +00:00
Gustavo Niemeyer 8cb64eaaf3 Fixing #1531862: Do not close standard file descriptors in the
subprocess module.
2006-09-06 01:58:52 +00:00
Tim Peters 4edcba69f3 Whitespace normalization. 2006-08-02 03:27:46 +00:00
Andrew M. Kuchling 86e1e38059 [Patch #1520905] Attempt to suppress core file created by test_subprocess.py.
Patch by Douglas Greiman.

The test_run_abort() testcase produces a core file on Unix systems,
even though the test is successful. This can be confusing or alarming
to someone who runs 'make test' and then finds that the Python
interpreter apparently crashed.
2006-08-01 18:16:15 +00:00
Peter Astrand 7d1d43630e Bug #1223937: CalledProcessError.errno -> CalledProcessError.returncode. 2006-07-14 14:04:45 +00:00
Peter Astrand 2b221ed657 Make it possible to run test_subprocess.py with Python 2.2, which lacks test_support.reap_children(). 2006-07-10 20:39:49 +00:00
Tim Peters 38ff36c4cc Whitespace normalization. 2006-06-30 06:18:39 +00:00
Neal Norwitz b15ac3169d Add new utility function, reap_children(), to test_support. This should
be called at the end of each test that spawns children (perhaps it
should be called from regrtest instead?).  This will hopefully prevent
some of the unexplained failures in the buildbots (hppa and alpha)
during tests that spawn children.  The problems were not reproducible.
There were many zombies that remained at the end of several tests.
In the worst case, this shouldn't cause any more problems,
though it may not help either.  Time will tell.
2006-06-29 04:10:08 +00:00
Peter Astrand d6b2430b7a Make it possible to run test_subprocess.py on Python 2.2, which lacks test_support.is_resource_enabled. 2006-06-22 20:06:46 +00:00
Neal Norwitz a6d01cec3f Try to fix breakage caused by patch #1479181, r45850 2006-05-02 06:23:22 +00:00