cpython

Commit Graph

Author	SHA1	Message	Date
Gregory P. Smith	32ec9da166	* Fix a refleak when a preexec_fn was supplied (preexec_fn_args_tuple was not being defref'ed). * Fixes another potential refleak of a reference to the gc module in the unlikely odd case where gc module isenabled or disable calls fail. * Adds a unittest for the above case to verify behavior and lack of leaks.	2010-03-19 16:53:08 +00:00
Gregory P. Smith	68f52178d9	* Fix the refcount leak in _PySequence_BytesToCharpArray from r78946. * Also fixes a potential extra DECREF of an arg in the error case within _posixsubprocess.fork_exec() by not reusing the process_args variable.	2010-03-15 06:07:42 +00:00
Gregory P. Smith	fb94c5f1e5	* Replaces the internals of the subprocess module from fork through exec on POSIX systems with a C extension module. This is required in order for the subprocess module to be made thread safe. The pure python implementation is retained so that it can continue to be used if for some reason the _posixsubprocess extension module is not available. The unittest executes tests on both code paths to guarantee compatibility. * Moves PyLong_FromPid and PyLong_AsPid from posixmodule.c into longobject.h. Code reviewed by jeffrey.yasskin at http://codereview.appspot.com/223077/show	2010-03-14 06:49:55 +00:00

Author

SHA1

Message

Date

Gregory P. Smith

32ec9da166

* Fix a refleak when a preexec_fn was supplied (preexec_fn_args_tuple was not

being defref'ed).
* Fixes another potential refleak of a reference to the gc
  module in the unlikely odd case where gc module isenabled or disable calls
  fail.
* Adds a unittest for the above case to verify behavior and lack of leaks.

2010-03-19 16:53:08 +00:00

Gregory P. Smith

68f52178d9

* Fix the refcount leak in _PySequence_BytesToCharpArray from r78946.

* Also fixes a potential extra DECREF of an arg in the error case within
  _posixsubprocess.fork_exec() by not reusing the process_args variable.

2010-03-15 06:07:42 +00:00

Gregory P. Smith

fb94c5f1e5

* Replaces the internals of the subprocess module from fork through exec on

POSIX systems with a C extension module.  This is required in order for
  the subprocess module to be made thread safe.

  The pure python implementation is retained so that it can continue to be
  used if for some reason the _posixsubprocess extension module is not
  available.

  The unittest executes tests on both code paths to guarantee compatibility.

* Moves PyLong_FromPid and PyLong_AsPid from posixmodule.c into longobject.h.

Code reviewed by jeffrey.yasskin at http://codereview.appspot.com/223077/show

2010-03-14 06:49:55 +00:00

3 Commits