Florent Xicluna
98e3fc39bf
Clean test_subprocess: use assertRaises, skipIf, skipUnless helpers and a custom helper assertStderrEqual.
2010-02-27 19:20:50 +00:00
Ezio Melotti
8f6a287029
#7712 : add a temp_cwd context manager to test_support and use it in regrtest to run all the tests in a temporary directory, saving the original CWD in test_support.SAVEDCWD. Thanks to Florent Xicluna who helped with the patch.
2010-02-10 21:40:33 +00:00
Ezio Melotti
aa98058cc4
use assert[Not]In where appropriate
2010-01-23 23:04:36 +00:00
Amaury Forgeot d'Arc
ce32eb7406
#6416 : Fix compilation of the select module on Windows, as well as test_subprocess:
...
PIPE_BUF is not defined on Windows, and probably has no meaning there.
Anyway the subprocess module uses another way to perform non-blocking reads (with a thread)
2009-07-09 22:37:22 +00:00
Gregory P. Smith
dd7ca24eb5
Use select.poll() in subprocess, when available, rather than select() so that
...
it does not fail when file descriptors are large. Fixes issue3392.
Patch largely contributed by Frank Chu (fpmc) with some improvements by me.
See http://bugs.python.org/issue3392 .
Candidate for backporting to release26-maint as it is a bug fix and changes no
public API.
2009-07-04 01:49:29 +00:00
Benjamin Peterson
5c8da86f3a
convert usage of fail* to assert*
2009-06-30 22:57:08 +00:00
Georg Brandl
f3715d2fc7
#5179 : don't leak PIPE fds when child execution fails.
2009-02-14 17:01:36 +00:00
Gregory P. Smith
26576801a6
rename the new check_call_output to check_output. its less ugly.
2008-12-05 02:27:01 +00:00
Gregory P. Smith
97f49f4be7
Adds a subprocess.check_call_output() function to return the output from a
...
process on success or raise an exception on error.
2008-12-04 20:21:09 +00:00
Gregory P. Smith
4036fd4b75
Fixes issue2791: subprocess.Popen.communicate leaked a file descripton until
...
the last reference to the Popen instance was dropped. Adding explicit
close() calls fixes it.
Candidate for backport to release25-maint.
2008-05-26 20:22:14 +00:00
Gregory P. Smith
af8a68733f
fix issue2381: test_subprocess fails if your sys.executable is on a
...
path with a space in it.
2008-05-17 07:17:34 +00:00
Christian Heimes
c2ca6db143
Disabled some unit tests for the upcoming release. See #2777
2008-05-06 23:42:58 +00:00
Christian Heimes
e74c8f2879
Added kill, terminate and send_signal to subprocess.Popen
...
The bits and pieces for the Windows side were already in place. The POSIX side is trivial (as usual) and uses os.kill().
2008-04-19 02:23:57 +00:00
Gregory P. Smith
70eb2f91b4
Fix issue 1300: Quote command line arguments that contain a '|' character in
...
subprocess.list2cmdline (windows).
2008-01-19 22:49:37 +00:00
Gregory P. Smith
e047e6dd09
fix comment typos, use not arg instead of arg == "", add test coverage
...
for inside of the final if needquotes: within subprocess.list2cmdline().
2008-01-19 20:49:02 +00:00
Guido van Rossum
e9a0e885db
Patch #1672 by Joseph Armbruster. Use tempdir() to get a temporary directory.
2007-12-20 17:28:10 +00:00
Peter Astrand
81a191b351
Applied patch 1669481, slightly modified: Support close_fds on Win32
2007-05-26 22:18:20 +00:00
Peter Astrand
10514a70ac
Fix for bug #1634343 : allow specifying empty arguments on Windows
2007-01-13 22:35:35 +00:00
Gustavo Niemeyer
c36bede6ff
Fixed subprocess bug #1531862 again, after removing tests
...
offending buildbot
2006-09-07 00:48:33 +00:00
Neal Norwitz
314bef9fff
Revert 51758 because it broke all the buildbots
2006-09-06 03:58:34 +00:00
Gustavo Niemeyer
8cb64eaaf3
Fixing #1531862 : Do not close standard file descriptors in the
...
subprocess module.
2006-09-06 01:58:52 +00:00
Tim Peters
4edcba69f3
Whitespace normalization.
2006-08-02 03:27:46 +00:00
Andrew M. Kuchling
86e1e38059
[Patch #1520905 ] Attempt to suppress core file created by test_subprocess.py.
...
Patch by Douglas Greiman.
The test_run_abort() testcase produces a core file on Unix systems,
even though the test is successful. This can be confusing or alarming
to someone who runs 'make test' and then finds that the Python
interpreter apparently crashed.
2006-08-01 18:16:15 +00:00
Peter Astrand
7d1d43630e
Bug #1223937 : CalledProcessError.errno -> CalledProcessError.returncode.
2006-07-14 14:04:45 +00:00
Peter Astrand
2b221ed657
Make it possible to run test_subprocess.py with Python 2.2, which lacks test_support.reap_children().
2006-07-10 20:39:49 +00:00
Tim Peters
38ff36c4cc
Whitespace normalization.
2006-06-30 06:18:39 +00:00
Neal Norwitz
b15ac3169d
Add new utility function, reap_children(), to test_support. This should
...
be called at the end of each test that spawns children (perhaps it
should be called from regrtest instead?). This will hopefully prevent
some of the unexplained failures in the buildbots (hppa and alpha)
during tests that spawn children. The problems were not reproducible.
There were many zombies that remained at the end of several tests.
In the worst case, this shouldn't cause any more problems,
though it may not help either. Time will tell.
2006-06-29 04:10:08 +00:00
Peter Astrand
d6b2430b7a
Make it possible to run test_subprocess.py on Python 2.2, which lacks test_support.is_resource_enabled.
2006-06-22 20:06:46 +00:00
Neal Norwitz
a6d01cec3f
Try to fix breakage caused by patch #1479181 , r45850
2006-05-02 06:23:22 +00:00
Neal Norwitz
c4edb0ec81
SF #1479181 : split open() and file() from being aliases for each other.
2006-05-02 04:43:14 +00:00
Tim Peters
eba28bea9b
Whitespace normalization.
2005-03-28 01:08:02 +00:00
Brett Cannon
653a5adcca
Tweak test_communicate_stderr so that it works when run under a pydebug build.
2005-03-05 06:40:52 +00:00
Peter Astrand
f7f1bb7ff5
Only run extensive subprocess tests if -usubprocess to regrtest is specified. Fixes #1124637
2005-03-03 20:47:37 +00:00
Peter Astrand
cbac93c229
Added three more testcases: Using communicate with only one of
...
stdin/stdout/stderr redirected.
2005-03-03 20:24:28 +00:00
Peter Astrand
454f76711c
New subprocess utility function: check_call. Closes #1071764 .
2005-01-01 09:36:35 +00:00
Peter Astrand
738131d391
Raise TypeError if bufsize argument is not an integer. Patch 1071755, slightly modified.
2004-11-30 21:04:45 +00:00
Peter Astrand
2224be64dc
Remove tempfile after use in test_call_string.
...
In test_args_string, remove the tempfile before assertEqual.
2004-11-17 20:06:35 +00:00
Peter Astrand
195404ff90
Use os.chdir/os.getcwd instead of os.path.realpath, to support Tru64
...
TEMP dirs with {memb} strings. Fixes #1063571 .
2004-11-12 15:51:48 +00:00
Peter Astrand
c19ccc9f11
Removed test_close_fds, because it's too unreliable. We simply cannot
...
know that the newly-started Python process only has 3 filedescriptors
open. Fixes bug 1048808.
2004-10-21 19:28:34 +00:00
Tim Peters
1dbf2434d5
remove_stderr_debug_decorations(): Always try the substitution. Else
...
this test failed under the combination of passing -O to a debug-build
Python. Now all 4 of those pass ({debug, release} x {-O, no -O}).
2004-10-14 04:16:54 +00:00
Fredrik Lundh
9e29fc584c
Don't spend quite as much time looking for leaks on Windows, where
...
it's rather expensive to create new processes.
2004-10-13 07:54:54 +00:00
Fredrik Lundh
59c0559554
normalize case when comparing directory names (problem reported by
...
"Khalid A. B." on python-dev)
2004-10-13 06:55:40 +00:00
Tim Peters
3761e8dd66
New helper remove_stderr_debug_decorations(). This test passes in a
...
debug build on Windows now. More applications of the helper may be needed
on non-Windows platforms.
2004-10-13 04:07:12 +00:00
Tim Peters
29b6b4f7c7
Kill several problems at once: test_poll() failed sometimes for me.
...
Turns out the mysterious "expected output" file contained exactly N dots,
because test_poll() has a loop that *usually* went around N times,
printing one dot on each loop trip. But there's no guarantee of that,
because the exact value of N depended on the vagaries of scheduling
time.sleep()s across two different processes. So stopped printing dots,
and got rid of the expected output file. Add a loop counter instead,
and verify that the loop goes around at least a couple of times. Also
cut the minimum time needed for this test from 4 seconds to 1.
2004-10-13 03:43:40 +00:00
Tim Peters
4052fe5a9b
test_stdout_none(): Don't print "banana" to the screen in the middle
...
of the test. It's testing stdout in a different process, so it has to
print something, but I didn't find "banana" to be self-explanatory.
2004-10-13 03:29:54 +00:00
Tim Peters
876c43245e
Windows test_creationflags() test: print msg to stderr informing the
...
tester that a DOS box is expected to flash. Slash the sleep from 2
seconds to a quarter second (why would we want to wait 2 seconds just
to stare at a DOS box?).
2004-10-13 03:21:35 +00:00
Tim Peters
f73cc9714f
XXX about extreme expense of test_no_leaking() on Windows. I'm not sure
...
what this is trying to do. If it's necessary for it to create > 1000
processes, it should be controlled by a new resource and not run by
default on Windows.
2004-10-13 03:14:40 +00:00
Tim Peters
7b759da1b8
Experience with Zope2's tests showed it's a Bad Idea to make unittest
...
display a test's docstring as "the name" of the test. So changed most
test docstrings to comments, and removed the clearly useless ones. Now
unittest reports the actual names of the test methods.
2004-10-12 22:29:54 +00:00
Tim Peters
3b01a70f76
Wrap long lines.
2004-10-12 22:19:32 +00:00
Tim Peters
e718f615b8
Whitespace normalization.
2004-10-12 21:51:32 +00:00