Commit Graph

88 Commits

Author SHA1 Message Date
Antoine Pitrou 91ce0d933c Merged revisions 87695 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87695 | antoine.pitrou | 2011-01-03 19:23:55 +0100 (lun., 03 janv. 2011) | 5 lines

  Issue #10806, issue #9905: Fix subprocess pipes when some of the standard
  file descriptors (0, 1, 2) are closed in the parent process.  Initial
  patch by Ross Lagerwall.
........
2011-01-03 18:45:09 +00:00
Gregory P. Smith 312efbc115 Merged revisions 87233 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87233 | gregory.p.smith | 2010-12-14 06:38:00 -0800 (Tue, 14 Dec 2010) | 4 lines

  Issue #1731717: Fixed the problem where subprocess.wait() could cause an
  OSError exception when The OS had been told to ignore SIGCLD in our process
  or otherwise not wait for exiting child processes.
........
2010-12-14 15:02:53 +00:00
Brian Curtin 7fe045ef00 Merged revisions 86207 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86207 | brian.curtin | 2010-11-05 12:09:05 -0500 (Fri, 05 Nov 2010) | 2 lines

  Fix a number of ResourceWarnings on Windows due to open pipes.
........
2010-11-05 17:19:38 +00:00
Brian Curtin d117b562ed Merged revisions 86185 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86185 | brian.curtin | 2010-11-04 22:58:52 -0500 (Thu, 04 Nov 2010) | 2 lines

  Add cleanups to stdout/stderr pipes to remove ResourceWarnings.
........
2010-11-05 04:09:09 +00:00
Antoine Pitrou dee0097fe4 Merged revisions 84997 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84997 | antoine.pitrou | 2010-09-24 20:57:01 +0200 (ven., 24 sept. 2010) | 3 lines

  Make _kill_process more robust under Windows too (see issue #8432)
........
2010-09-24 19:00:29 +00:00
Antoine Pitrou a6166dac94 Merged revisions 84909-84913 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84909 | antoine.pitrou | 2010-09-20 00:46:05 +0200 (lun., 20 sept. 2010) | 3 lines

  Try to fix test_subprocess on "x86 debian parallel 3.x" buildbot
........
  r84910 | antoine.pitrou | 2010-09-20 01:06:53 +0200 (lun., 20 sept. 2010) | 3 lines

  Try to make signal-sending tests in test_subprocess more robust on slow machines
........
  r84911 | antoine.pitrou | 2010-09-20 01:28:30 +0200 (lun., 20 sept. 2010) | 3 lines

  Make error more explicit in test_finalize_with_trace
........
  r84912 | antoine.pitrou | 2010-09-20 02:12:19 +0200 (lun., 20 sept. 2010) | 3 lines

  Try to fix buildbot failure (#9902)
........
  r84913 | antoine.pitrou | 2010-09-20 03:33:21 +0200 (lun., 20 sept. 2010) | 3 lines

  Try a more robust implementation of _kill_process
........
2010-09-20 11:20:44 +00:00
Antoine Pitrou b0b3bffe8b Merged revisions 84883 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84883 | antoine.pitrou | 2010-09-19 00:38:48 +0200 (dim., 19 sept. 2010) | 3 lines

  Issue #9895: speed up test_subprocess
........
2010-09-18 22:42:30 +00:00
Antoine Pitrou 767cbc41b4 Merged revisions 84878 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84878 | antoine.pitrou | 2010-09-18 19:56:02 +0200 (sam., 18 sept. 2010) | 5 lines

  Issue #9894: Do not hardcode ENOENT in test_subprocess.

  (GNU/Hurd is not dead)
........
2010-09-18 18:15:33 +00:00
Brian Curtin e8c4920e4c Merged revisions 83983 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83983 | brian.curtin | 2010-08-13 15:42:57 -0500 (Fri, 13 Aug 2010) | 3 lines

  Fix #9588. Add sys.executable to two shell=True tests.
........
2010-08-13 21:01:52 +00:00
Tim Golden 8e4756c763 #2304: fix incorporating Eric Smith's .format suggestion and tested on Ubuntu as well as Windows 2010-08-12 11:00:35 +00:00
Benjamin Peterson 718f222372 revert 83832; unix test breakage 2010-08-08 19:14:28 +00:00
Tim Golden 6fe8c41e8f Issue #2304: Add additional quotes when using cmd shell on Windows. Original patch from Gabriel Genellina 2010-08-08 16:18:45 +00:00
Tim Golden 90374f5102 Issue #3210: Ensure stdio handles are closed if CreateProcess fails 2010-08-06 13:14:33 +00:00
Ronald Oussoren 21b44e0ea2 Merged revisions 83067 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83067 | ronald.oussoren | 2010-07-23 10:50:05 +0100 (Fri, 23 Jul 2010) | 8 lines

  Workaround for issue 4047: in some configurations of
  the Crash Reporter on OSX test_subprocess will trigger
  the reporter.

  This patch prints a warning when the Crash Reporter will
  get triggered intentionally, which should avoid confusing
  people.
........
2010-07-23 12:26:30 +00:00
Stefan Krah e9a6a7dd4c Issue #9265: Incorrect name passed as arg[0] when shell=True
and executable specified.
2010-07-19 14:41:08 +00:00
Jean-Paul Calderone b33f0c1ccd Revert r60115
This revision introduced quoting for strings containing | based
on a misunderstanding of the commonly used quoting rules used
on Windows.

| is interpreted by cmd.exe, not by the MS C runtime argv initializer.
It only needs to be quoted if it is part of an argument passed through
cmd.exe.

See issue1300, issue7839, and issue8972.
2010-06-18 20:00:17 +00:00
Florent Xicluna 3c919cf140 The SIGINT signal may happen earlier, during site.py initialization. 2010-03-23 19:19:16 +00:00
Florent Xicluna 446ff14827 The standard error should be empty when the signal is killed, except on SIGINT. 2010-03-23 15:05:30 +00:00
Florent Xicluna fc4d6d7763 Silence test_subprocess. 2010-03-23 14:36:45 +00:00
Florent Xicluna 637637021a Revert r78830: realpath() should really be applied to sys.executable. 2010-03-11 01:50:48 +00:00
Florent Xicluna e58d91c8f0 Fix the test_subprocess failure when sys.executable is meaningless: '' or a directory.
It does not fix #7774.
2010-03-11 00:56:59 +00:00
Florent Xicluna faf175385d Replace the stderr logging with assertNotEqual(returncode, 0). 2010-03-08 10:59:33 +00:00
Florent Xicluna 400efc2259 #2777: Try hard to make Win7 buildbot happy... 2010-03-07 17:12:23 +00:00
Florent Xicluna c083864fc8 Do not fail if returncode is 0 on send_signal/kill/terminate, for win32 platforms.
Do not hide the KeyboardInterrupt on POSIX platforms.
2010-03-07 15:27:39 +00:00
Florent Xicluna c02bbe328d #2777: Enable test_send_signal, test_terminate and test_kill on win32 platforms. 2010-03-07 12:21:36 +00:00
Florent Xicluna 632df993dc Skip test_send_signal, test_kill, test_terminate on win32 platforms, for 2.7a4 release. 2010-03-06 19:43:41 +00:00
Florent Xicluna aa90db9477 #2777: Apply same recipe on win32, i.e. do not inherit file handles. 2010-03-06 09:54:14 +00:00
Florent Xicluna af9a06a77f #2777: Apply same recipe for test_terminate and test_kill, i.e. close or redirect fds. 2010-03-06 00:16:57 +00:00
Florent Xicluna cecef392f1 #2777: Handle fds more carefully to try to fix some x86-Linux failures (namely, neal bot and twisted bot). 2010-03-05 19:31:21 +00:00
Florent Xicluna 7272acfabe These line should not be there. 2010-03-05 01:12:14 +00:00
Florent Xicluna d6935631da Let's use assertIsNone / assertIsNotNone. It's hype. 2010-03-05 01:05:55 +00:00
Florent Xicluna 80e0e2d2d8 Workaround #3137: Retry SIGINT if it is not received the first time.
test_send_signal should not hang anymore on various Linux distributions.
2010-03-05 00:47:40 +00:00
Florent Xicluna ab5e17f896 #2777: Enable test_send_signal, test_kill and test_terminate on all platforms. 2010-03-04 21:31:58 +00:00
Florent Xicluna bab22a7c6d Cleanup. 2010-03-04 19:40:48 +00:00
Gregory P. Smith c1baf4ac9e Fix the new test on windows (skip it, its posix only) 2010-03-01 02:53:24 +00:00
Gregory P. Smith cce211f88c Issue #1068268: The subprocess module now handles EINTR in internal
os.waitpid and os.read system calls where appropriate.
2010-03-01 00:05:08 +00:00
Florent Xicluna 78fd521f1a Fix an oversight in r78508: p.wait() should be compared to 0 2010-02-27 21:15:27 +00:00
Florent Xicluna 98e3fc39bf Clean test_subprocess: use assertRaises, skipIf, skipUnless helpers and a custom helper assertStderrEqual. 2010-02-27 19:20:50 +00:00
Ezio Melotti 8f6a287029 #7712: add a temp_cwd context manager to test_support and use it in regrtest to run all the tests in a temporary directory, saving the original CWD in test_support.SAVEDCWD. Thanks to Florent Xicluna who helped with the patch. 2010-02-10 21:40:33 +00:00
Ezio Melotti aa98058cc4 use assert[Not]In where appropriate 2010-01-23 23:04:36 +00:00
Amaury Forgeot d'Arc ce32eb7406 #6416: Fix compilation of the select module on Windows, as well as test_subprocess:
PIPE_BUF is not defined on Windows, and probably has no meaning there.

Anyway the subprocess module uses another way to perform non-blocking reads (with a thread)
2009-07-09 22:37:22 +00:00
Gregory P. Smith dd7ca24eb5 Use select.poll() in subprocess, when available, rather than select() so that
it does not fail when file descriptors are large.  Fixes issue3392.

Patch largely contributed by Frank Chu (fpmc) with some improvements by me.
See http://bugs.python.org/issue3392.

Candidate for backporting to release26-maint as it is a bug fix and changes no
public API.
2009-07-04 01:49:29 +00:00
Benjamin Peterson 5c8da86f3a convert usage of fail* to assert* 2009-06-30 22:57:08 +00:00
Georg Brandl f3715d2fc7 #5179: don't leak PIPE fds when child execution fails. 2009-02-14 17:01:36 +00:00
Gregory P. Smith 26576801a6 rename the new check_call_output to check_output. its less ugly. 2008-12-05 02:27:01 +00:00
Gregory P. Smith 97f49f4be7 Adds a subprocess.check_call_output() function to return the output from a
process on success or raise an exception on error.
2008-12-04 20:21:09 +00:00
Gregory P. Smith 4036fd4b75 Fixes issue2791: subprocess.Popen.communicate leaked a file descripton until
the last reference to the Popen instance was dropped.  Adding explicit
close() calls fixes it.

Candidate for backport to release25-maint.
2008-05-26 20:22:14 +00:00
Gregory P. Smith af8a68733f fix issue2381: test_subprocess fails if your sys.executable is on a
path with a space in it.
2008-05-17 07:17:34 +00:00
Christian Heimes c2ca6db143 Disabled some unit tests for the upcoming release. See #2777 2008-05-06 23:42:58 +00:00
Christian Heimes e74c8f2879 Added kill, terminate and send_signal to subprocess.Popen
The bits and pieces for the Windows side were already in place. The POSIX side is trivial (as usual) and uses os.kill().
2008-04-19 02:23:57 +00:00