bdc4b02985
cast negative numbers to size_t before shifting them ( #20929 )
2014-03-14 20:15:29 -05:00
6dfc632f1f
whatsnew: difflib.isbjunk &c were removed, not deprecated.
...
Also move NEWS item to correct position (it was in 3.3).
2014-03-13 21:34:54 -04:00
d664db8a7b
whatsnew: difflib.isbjunk &c were removed, not deprecated.
...
Also move NEWS item to correct position (it was in 3.3).
2014-03-13 21:34:54 -04:00
45fc8713bd
Make distutils error messages more helpful ( #11599 ).
...
When running external programs such as a C compiler and getting an
error code, distutils only prints the program name. With this change,
one can get the full command line by setting the DISTUTILS_DEBUG
environment variable.
This should have no compatibility issues, unless there are tools
that depend on the exact format of distutils debug messages.
2014-03-13 04:55:35 -04:00
f7614d55a2
Close #19407 : New installation & distribution guides
...
- based on pip and other PyPA tools
- includes references to the new Python Packaging User Guide
where appropriate (and the relevant section is at least
partially filled in)
- started new FAQ sections
- both guides aim to introduce users to basic open source
concepts if they aren't aware of them
- existing guides have been relocated (now linked from the
distutils docs) rather then removed, since there is
some needed material that has yet to be relocated to the
distutils docs as a reference for the legacy formats
2014-03-13 22:13:45 +10:00
f1e8c70cf0
Merge 3.3 ( #11599 )
2014-03-13 05:59:31 -04:00
a0fe1f74f9
Merge 3.3 ( #4931 )
2014-03-12 04:10:51 -04:00
fc773a2d4b
Avoid “error: None” messages from distutils ( #4931 ).
...
Thanks to Amaury Forgeot d’Arc and Philip J. Eby.
2014-03-12 03:34:02 -04:00
1243c7d32c
Issue #19157 : Include the broadcast address in the usuable hosts for IPv6
...
in ipaddress.
2014-03-11 09:55:46 -07:00
30781e93b0
whatsnew: urllib Request objects are now reusable.
...
#16464 , #17485 , #17272 .
2014-03-10 17:06:00 -04:00
e8db162f62
whatsnew: PEP 424 implementation.
2014-03-10 15:00:33 -04:00
d840b8d613
whatsnew: multiprocessing start methods and context ( #8713 and #18999 )
...
Also tweaked the docs a bit to use our standard style for
versionadded/changed. (I'm guessing there are other places
in the multiprocessing docs where similar tweaks should be made.)
2014-03-10 14:27:21 -04:00
c51ebce03b
whatsnew: logging.config.listen *verify* ( #15452 ).
2014-03-10 12:03:01 -04:00
416616fc6f
whatsnew: logging.fileConfig accepts ConfigParser instances. ( #16110 )
...
And missing NEWS entry.
2014-03-10 11:51:19 -04:00
c51eaf5ca0
whatsnew: ChainMap.new_child *m* argument.
...
And NEWS entry.
2014-03-10 09:49:19 -04:00
6120739f0c
Issue #20875 : Prevent possible gzip "'read' is not defined" NameError.
...
Patch by Claudiu Popa.
2014-03-09 14:44:34 -07:00
e5127299c8
Issue #20875 : Merge from 3.3
2014-03-09 14:47:58 -07:00
5e572fd490
merge with 3.3.5 release repo
2014-03-09 11:17:23 +01:00
92d2d346ef
Post-release update.
2014-03-09 11:01:14 +01:00
fbd7518a41
Bump to 3.3.5 final.
2014-03-09 09:37:14 +01:00
19f1df6414
Tweak NEWS so some additional issue numbers become links in html version.
2014-03-08 10:06:04 -05:00
6b5284fd4e
Mark branch as being after Python 3.4.0rc3.
2014-03-15 20:57:42 -07:00
05fad4ede7
Remove redundant NEWS entry.
2014-03-06 12:58:25 -05:00
5dda12491e
#11558 : Better message if attach called on non-multipart.
...
Original patch by Varun Sharma.
2014-03-06 11:44:17 -05:00
ccdf352370
Issue #20283 : RE pattern methods now accept the string keyword parameters
...
as documented. The pattern and source keyword parameters are left as
deprecated aliases.
2014-03-06 11:28:32 +02:00
62b4b9eecb
Close #20839 : pkgutil.find_loader now uses importlib.util.find_spec
2014-03-04 20:39:42 +10:00
04edfdf320
whatsnew: tweak a couple importlib porting notes.
...
I had missed that there was already an entry for the Frozen package change, so
I combined mine with the existing one. Also added the info about the reload
change to the entry for the other changes to reload, but I'm missing an issue
number for the rest of the attribute behavior changes so I left myself an
XXX as a reminder to find it.
2014-03-03 08:56:43 -05:00
a537eb45fd
Issue #20283 : RE pattern methods now accept the string keyword parameters
...
as documented. The pattern and source keyword parameters are left as
deprecated aliases.
2014-03-06 11:36:15 +02:00
dc855b7b1f
Close #20839 : pkgutil.find_loader now uses importlib.util.find_spec
2014-03-04 20:39:42 +10:00
0c3ea0942d
Issue #14512 : Launch pydoc -b instead of pydocgui.pyw on Windows.
2014-03-02 20:29:18 +01:00
2b4b377966
Issue #14512 : Launch pydoc -b instead of pydocgui.pyw on Windows.
2014-03-02 20:29:18 +01:00
a663069b5c
Issue #20465 : Update Windows installer to SQLite 3.8.3.1.
2014-03-02 19:42:50 +01:00
09257f7ced
Issue #20465 : Update Windows installer to SQLite 3.8.3.1.
2014-03-02 19:42:50 +01:00
582538bde2
Issue #20748 : Uninstalling pip does not leave behind the pyc of
...
the uninstaller anymore.
2014-03-02 19:29:19 +01:00
5e6faf7fed
Issue #20748 : Uninstalling pip does not leave behind the pyc of
...
the uninstaller anymore.
2014-03-02 19:29:19 +01:00
d930d85f12
Issue #20786 : Fix signatures for dict.__delitem__ and property.__delete__
2014-03-02 12:25:27 -05:00
056e265491
Issue #20786 : Fix signatures for dict.__delitem__ and property.__delete__
2014-03-02 12:25:27 -05:00
bb386cf810
Update NEWS for 3.3.5rc2.
2014-03-02 09:18:41 +01:00
2658bad090
merge 3.3.5rc1 release commits with 3.3 branch
2014-03-02 08:54:15 +01:00
90c5c8ad5c
Issue #20465 : fix NEWS typo (it's 3.8.3.1)
2014-03-01 14:04:48 -08:00
3231bc01c5
Issue #20465 : fix NEWS typo (it's 3.8.3.1)
2014-03-01 14:04:48 -08:00
c1195c7ae7
Issue #20465 : Update OS X installer build to use SQLite 3.8.0.1.
2014-03-01 14:00:46 -08:00
2515edd7cf
Issue #20465 : Update OS X installer build to use SQLite 3.8.0.1.
2014-03-01 14:00:46 -08:00
298bb96776
Issue #20778 : Fix modulefinder to work with bytecode-only modules.
...
Bug filed and initial attempt at a patch by Bohuslav Kabrda.
2014-02-28 10:44:45 -05:00
815b41b1cd
Issue #20731 : Properly position in source code files even if they
...
are opened in text mode. Patch by Serhiy Storchaka.
2014-02-28 15:27:29 +01:00
07d843a101
Close #20568 : install unversioned pip command on Windows
2014-02-28 23:37:35 +10:00
a46cf12e99
Close #20757 : return success for skipped pip uninstall
...
The 3.4rc2 Windows uninstaller would fail if pip had been updated
to a version that didn't match the version installed by ensurepip.
This skip is no longer treated as an error, so an updated pip ends
up being handled like any other pip installed package and is left
alone by the CPython uninstaller.
2014-02-28 23:35:05 +10:00
0f3847855d
merge for issue #20778
2014-02-28 10:50:34 -05:00
9c17ff91f3
Merge heads
2014-02-28 15:47:15 +01:00
78f1e4c865
Merge with 3.3
2014-02-28 15:43:36 +01:00
f808df39de
Close #20568 : install unversioned pip command on Windows
2014-02-28 23:37:35 +10:00
4a6dc3a726
Close #20757 : return success for skipped pip uninstall
...
The 3.4rc2 Windows uninstaller would fail if pip had been updated
to a version that didn't match the version installed by ensurepip.
This skip is no longer treated as an error, so an updated pip ends
up being handled like any other pip installed package and is left
alone by the CPython uninstaller.
2014-02-28 23:35:05 +10:00
b807577da2
Issue #20791 : copy.copy() now doesn't make a copy when the input is a bytes object. Initial patch by Peter Otten.
2014-02-27 22:14:31 +01:00
dc9215f882
Issue #20791 : copy.copy() now doesn't make a copy when the input is a bytes object. Initial patch by Peter Otten.
2014-02-27 22:14:31 +01:00
7b80716cff
Mention issue 20621 fix in the NEWS file for 3.3.5rc1.
...
This bug was of the major reasons for the release.
2014-02-25 16:45:55 -08:00
1e923de0bf
Fix formatting in NEWS entry.
2014-02-25 14:36:20 -05:00
ef85119618
Issue #20765 : Add missing documentation for PurePath.with_name() and PurePath.with_suffix().
2014-02-25 20:33:02 +01:00
b1f65569bd
Fix wording of NEWS entry.
2014-02-24 15:48:31 -05:00
6225260e8c
Remove redundant NEWS entry.
2014-02-24 10:55:08 -05:00
c8400a47bb
Fix NEWS entry wording.
2014-02-24 10:42:20 -05:00
94ee389308
Issue #19619 : Blacklist non-text codecs in method API
...
str.encode, bytes.decode and bytearray.decode now use an
internal API to throw LookupError for known non-text encodings,
rather than attempting the encoding or decoding operation and
then throwing a TypeError for an unexpected output type.
The latter mechanism remains in place for third party non-text
encodings.
Backported changeset d68df99d7a57.
2014-02-24 14:43:03 +02:00
eb44b2d9e8
Issue #20535 : PYTHONWARNING no longer affects the run_tests.py script.
...
Patch by Arfrever Frehtes Taifersar Arahesis.
2014-02-24 14:00:38 +02:00
20f8728bf0
Issue #20535 : PYTHONWARNING no longer affects the run_tests.py script.
...
Patch by Arfrever Frehtes Taifersar Arahesis.
2014-02-24 13:57:00 +02:00
aa5e2995c7
Fix wording in NEWS entry.
2014-02-23 21:32:17 -05:00
8a14ea4694
Issue #20743 : Fix a reference leak in test_tcl.
2014-02-23 19:41:51 +01:00
220cc21cec
Issue #20743 : Fix a reference leak in test_tcl.
2014-02-23 19:39:06 +01:00
784a3ffdbb
Fix wording in news entry.
2014-02-23 11:22:08 -05:00
f0b5a7c0f6
Issue #20637 : Key-sharing now also works for instance dictionaries of subclasses. Patch by Peter Ingebretson.
2014-02-23 16:50:07 +01:00
e12675a0f2
Bump to 3.3.5rc1.
2014-02-23 08:30:06 +01:00
1db0eacf3e
Issue #20641 : Run custom actions with the NoImpersonate flag to support UAC.
2014-02-22 23:44:20 +01:00
1ac42614e3
Issue #19748 : On AIX, time.mktime() now raises an OverflowError for year
...
outsize range [1902; 2037].
2014-02-21 09:27:17 +01:00
24a882bb7b
Issue #20710 : The pydoc summary line no longer displays the "self" parameter
...
for bound methods. Previous to this change, it displayed "self" for methods
implemented in Python but not methods implemented in C; it is now both
internally consistent and consistent with inspect.Signature.
2014-02-20 23:34:46 -08:00
52855719f5
Issue #20221 : Removed conflicting (or circular) hypot definition
...
when compiled with VS 2010 or above. Initial patch by Tabrez Mohammed.
2014-02-20 15:39:29 -06:00
2d659518aa
Issue #20221 : Removed conflicting (or circular) hypot definition
...
when compiled with VS 2010 or above. Initial patch by Tabrez Mohammed.
2014-02-20 15:36:34 -06:00
cd153f8bdd
Misc/NEWS: Add some missing news items re asyncio.
2014-02-20 13:59:14 -05:00
f4558e8b54
merge heads
2014-02-19 16:28:36 -05:00
57d240ef64
inspect: Fix getfullargspec() to not to follow __wrapped__ chains
...
Initial patch by Nick Coghlan.
2014-02-19 16:27:23 -05:00
056eb02719
Issue #20654 : Fixed pydoc for enums with zero value. Patch by Vajrasky Kok.
2014-02-19 23:05:12 +02:00
22234dab05
Fixed grid_columnconfigure() and grid_rowconfigure() methods of
...
Tkinter widgets to work in wantobjects=True mode.
2014-02-19 18:35:10 +02:00
e95977621d
Fixed grid_columnconfigure() and grid_rowconfigure() methods of
...
Tkinter widgets to work in wantobjects=True mode.
2014-02-19 18:34:05 +02:00
ff827f08ac
asyncio: New error handling API. Issue #20681 .
2014-02-18 18:02:19 -05:00
5f47ac2aaa
(Merge 3.3) Issue #19612 : On Windows, subprocess.Popen.communicate() now
...
ignores OSError(22, 'Invalid argument') when writing input data into stdin,
whereas the process already exited.
2014-02-18 22:06:35 +01:00
d5c8ce7cc0
Issue #19612 : On Windows, subprocess.Popen.communicate() now ignores
...
OSError(22, 'Invalid argument') when writing input data into stdin, whereas
the process already exited.
2014-02-18 22:00:53 +01:00
34ce99f66d
Mangle __parameters in __annotations__ dict properly. Issue #20625 .
2014-02-18 12:49:41 -05:00
b59e4425d5
Issue #20609 : Merge with 3.3.
2014-02-18 11:35:15 -06:00
9e5a9876ad
Issue #20609 : Fix building 64-bit binaries on 32-bit Windows.
2014-02-18 11:33:18 -06:00
8e7761ec70
Misc/NEWS: Add a news item for UNIX Sockets support in asyncio. Cleanup WS.
2014-02-18 12:21:57 -05:00
c36e504c53
Issue #20510 : Merge with 3.3.
2014-02-18 08:41:21 -06:00
cefe6b34de
Issue #20510 : Rewrote test_exit in test_sys to match existing comments
...
and to modernize. Patch by Gareth Rees.
2014-02-18 08:39:04 -06:00
79bf89986c
Merge with 3.3
2014-02-17 23:12:37 -05:00
5b8d2c3af7
Issue #8478 : Untokenizer.compat now processes first token from iterator input.
...
Patch based on lines from Georg Brandl, Eric Snow, and Gareth Rees.
2014-02-17 23:12:16 -05:00
3c1b379ebd
Issue #20320 : select.select() and select.kqueue.control() now round the timeout
...
aways from zero, instead of rounding towards zero.
It should make test_asyncio more reliable, especially test_timeout_rounding() test.
2014-02-17 00:02:43 +01:00
23f628de4a
Issue #20616 : Add a format() method to tracemalloc.Traceback.
2014-02-16 23:53:38 +01:00
e686c5c3e8
look up __getnewargs__ and __getnewargs_ex__ on the object type ( #16251 )
2014-02-16 13:49:16 -05:00
e2df5cfcbd
Issue #19744 : Handle missing SSL/TLS in ensurepip
...
- now also allows POSIX installation with SSL/TLS missing
- a goal for pip 1.6 is to allow local use without SSL/TLS
2014-02-15 09:14:54 +10:00
b7bb675d3c
Issue #20605 : Make test_socket getaddrinfo OS X segfault test more robust.
2014-02-13 22:53:42 -08:00
b24f481ab4
Issue #20605 : Make test_socket getaddrinfo OS X segfault test more robust.
2014-02-13 22:50:42 -08:00
0714b8b6ab
set line and column numbers for keyword-only arg nodes ( closes #20619 )
2014-02-13 19:22:14 -05:00
15054c16c8
Issue #20526 , #19466 : Revert changes of issue #19466 which introduces a
...
regression: don't clear anymore the state of Python threads early during the
Python shutdown.
2014-02-13 12:48:54 +01:00
7dfaa27fdd
Issue #6815 : os.path.expandvars() now supports non-ASCII environment
...
variables names and values.
2014-02-13 10:14:48 +02:00
dbb101909d
Issue #6815 : os.path.expandvars() now supports non-ASCII environment
...
variables names and values.
2014-02-13 10:13:53 +02:00
5bdfc51950
Issue #17671 : Fixed a crash when use non-initialized io.BufferedRWPair.
...
Based on patch by Stephen Tu.
2014-02-12 10:55:07 +02:00
61e2493b83
Issue #17671 : Fixed a crash when use non-initialized io.BufferedRWPair.
...
Based on patch by Stephen Tu.
2014-02-12 10:52:35 +02:00
e18e787e70
merge 3.3 ( #20594 )
2014-02-11 10:19:12 -05:00
932bba33f2
avoid name clash with posix_close ( closes #20594 )
2014-02-11 10:16:16 -05:00
40be9e5100
remove dynamic initializer lists for c89 compliance ( closes #20595 )
2014-02-11 10:09:27 -05:00
801fe934d9
whatsnew: __complex__ may not return float, .so may have multiple python modules
...
Also a NEWS wording fixup.
2014-02-11 08:13:10 -05:00
fea7e7336f
Merge heads
2014-02-11 10:38:44 +02:00
6a45021084
Issue #19856 : shutil.move() failed to move a directory to other directory
...
on Windows if source name ends with os.altsep.
2014-02-11 10:32:41 +02:00
3a308b9f37
Issue #19856 : shutil.move() failed to move a directory to other directory
...
on Windows if source name ends with os.altsep.
2014-02-11 10:30:59 +02:00
3f99504c08
Merge Python 3.4.0rc1 release branch.
2014-02-11 00:15:46 -08:00
4cce8f2f40
Python 3.4.0rc1: Post-release updates.
2014-02-11 00:14:16 -08:00
42ec031fe7
merge 3.3 ( #20588 )
2014-02-10 22:41:40 -05:00
c2f665e721
don't put runtime values in array initializer for C89 compliance ( closes #20588 )
2014-02-10 22:19:02 -05:00
e9f73ac1fd
Python 3.4.0rc1: Version bump.
2014-02-10 14:45:05 -08:00
8f9c20b8ff
merge with 3.3.4 releasing repo
2014-02-10 22:04:20 +01:00
a37fcb28e6
Post-release updates.
2014-02-10 21:56:33 +01:00
013bb91aa3
Issue #19255 : The builtins module is restored to initial value before
...
cleaning other modules. The sys and builtins modules are cleaned last.
2014-02-10 18:21:34 +02:00
7850541a72
Issue #20641 : Run custom actions with the NoImpersonate flag to support UAC.
2014-02-22 23:44:20 +01:00
13da6a1a9c
Issue #20710 : The pydoc summary line no longer displays the "self" parameter
...
for bound methods. Previous to this change, it displayed "self" for methods
implemented in Python but not methods implemented in C; it is now both
internally consistent and consistent with inspect.Signature.
2014-02-20 23:34:46 -08:00
0c9beb64de
Issue #20221 : Removed conflicting (or circular) hypot definition
...
when compiled with VS 2010 or above. Initial patch by Tabrez Mohammed.
2014-02-20 15:39:29 -06:00
389b036b8f
Misc/NEWS: Add some missing news items re asyncio.
2014-02-20 13:59:14 -05:00
ff385b89f4
inspect: Fix getfullargspec() to not to follow __wrapped__ chains
...
Initial patch by Nick Coghlan.
2014-02-19 16:27:23 -05:00
569efa2e4b
asyncio: New error handling API. Issue #20681 .
2014-02-18 18:02:19 -05:00
026019f89b
Mangle __parameters in __annotations__ dict properly. Issue #20625 .
2014-02-18 12:49:41 -05:00
ee227ae7cf
Issue #20609 : Merge with 3.3.
2014-02-18 11:35:15 -06:00
907f0172e5
Misc/NEWS: Add a news item for UNIX Sockets support in asyncio. Cleanup WS.
2014-02-18 12:21:57 -05:00
a91ff1423f
Issue #20616 : Add a format() method to tracemalloc.Traceback.
2014-02-16 23:53:38 +01:00
2626fab4c7
look up __getnewargs__ and __getnewargs_ex__ on the object type ( #16251 )
2014-02-16 13:49:16 -05:00
c00fa6387d
Issue #19744 : Handle missing SSL/TLS in ensurepip
...
- now also allows POSIX installation with SSL/TLS missing
- a goal for pip 1.6 is to allow local use without SSL/TLS
2014-02-15 09:14:54 +10:00
e84fde981d
set line and column numbers for keyword-only arg nodes ( closes #20619 )
2014-02-13 19:22:14 -05:00
933538edde
Issue #20526 , #19466 : Revert changes of issue #19466 which introduces a
...
regression: don't clear anymore the state of Python threads early during the
Python shutdown.
2014-02-13 12:48:54 +01:00
5d95afa99d
merge 3.3 ( #20594 )
2014-02-11 10:19:12 -05:00
87a5c515d0
Issue #19255 : The builtins module is restored to initial value before
...
cleaning other modules. The sys and builtins modules are cleaned last.
2014-02-10 18:21:34 +02:00
8f9f0f12e8
Issue #20517 : Removed unnecessary new (short-lived) functions from PyErr.
2014-02-10 03:43:57 -08:00
69a2547cd5
Issue #20530 : The signatures for slot builtins have been updated
...
to reflect the fact that they only accept positional-only arguments.
2014-02-09 22:22:38 -08:00
b082731fbb
Issue #20517 : Functions in the os module that accept two filenames
...
now register both filenames in the exception on failure.
This required adding new C API functions allowing OSError exceptions
to reference two filenames instead of one.
2014-02-09 22:05:19 -08:00
dfe98a102e
Issue #20437 : Fixed 22 potential bugs when deleting objects references.
2014-02-09 13:46:20 +02:00
505ff755d7
Issue #20437 : Fixed 21 potential bugs when deleting objects references.
2014-02-09 13:33:53 +02:00
a7bf78d3eb
news entry
2014-02-09 08:57:59 +01:00
2623c8c23c
Issue #20530 : Argument Clinic's signature format has been revised again.
...
The new syntax is highly human readable while still preventing false
positives. The syntax also extends Python syntax to denote "self" and
positional-only parameters, allowing inspect.Signature objects to be
totally accurate for all supported builtins in Python 3.4.
2014-02-08 22:15:29 -08:00
d979e4335d
Close #20500 : Don't trigger PyObject_Str assertion at shutdown
2014-02-09 10:43:21 +10:00
96bb437ae8
Close #20563 : Declare ipaddress API stable
2014-02-09 09:18:26 +10:00
66c3d18af1
Merge: #14983 : always add a line end after a MIME boundary marker.
2014-02-08 17:56:17 -05:00
e9c31470e1
#14983 : always add a line end after a MIME boundary marker.
...
This is more RFC compliant (see issue) and fixes a problem with
signature verifiers rejecting the part when signed. There is some
amount of backward compatibility concern here since it changes
the output, but the RFC issue coupled with fixing the problem
with signature verifiers seems worth the small risk of breaking
code that depends on the current incorrect output.
2014-02-08 17:54:56 -05:00
b7d6d2ac6e
Issue #20540 : Fix a performance regression (vs. Python 3.2) when layering a multiprocessing Connection over a TCP socket.
...
For small payloads, Nagle's algorithm would introduce idle delays before the entire transmission of a message.
2014-02-08 23:03:56 +01:00
0c1e31ab1e
Issue #20540 : Fix a performance regression (vs. Python 3.2) when layering a multiprocessing Connection over a TCP socket.
...
For small payloads, Nagle's algorithm would introduce idle delays before the entire transmission of a message.
2014-02-08 23:05:52 +01:00
01e46ee7e2
Merge: #16983 : Apply postel's law to encoded words inside quoted strings.
2014-02-08 13:13:01 -05:00
0400d33928
#16983 : Apply postel's law to encoded words inside quoted strings.
...
This applies only to the new parser. The old parser decodes encoded words
inside quoted strings already, although it gets the whitespace wrong
when it does so.
This version of the patch only handles the most common case (a single encoded
word surrounded by quotes), but I haven't seen any other variations of this in
the wild yet, so its good enough for now.
2014-02-08 13:12:00 -05:00
ff9616bbf7
Merge #19772 : Do not mutate message when downcoding to 7bit.
2014-02-08 11:51:18 -05:00
Benjamin Peterson
R David Murray
Éric Araujo
Nick Coghlan
Peter Moody
Ned Deily
Georg Brandl
Larry Hastings
Serhiy Storchaka
Martin v. Löwis
Yury Selivanov
Brett Cannon
Antoine Pitrou
Gregory P. Smith
Victor Stinner
Zachary Ware
Terry Jan Reedy