Brett Cannon
03446c43ca
Remove warnings generated for the suprocess module when run under -3. Required
...
commenting out True/False compatbility stuff, remove a use of apply(), and
remove a use of buffer() (just pulled the solution used in 3.0 which is direct
slicing).
2008-08-08 04:19:32 +00:00
Gregory P. Smith
a36f8fefb0
- Issue #1857 : subprocess.Popen.poll gained an additional _deadstate keyword
...
argument in python 2.5, this broke code that subclassed Popen to include its
own poll method. Fixed my moving _deadstate to an _internal_poll method.
2008-08-04 00:13:29 +00:00
Gregory P. Smith
f41406409e
- Issue #2113 : Fix error in subprocess.Popen if the select system call is
...
interrupted by a signal.
2008-07-06 07:16:40 +00:00
Gregory P. Smith
4036fd4b75
Fixes issue2791: subprocess.Popen.communicate leaked a file descripton until
...
the last reference to the Popen instance was dropped. Adding explicit
close() calls fixes it.
Candidate for backport to release25-maint.
2008-05-26 20:22:14 +00:00
Christian Heimes
e74c8f2879
Added kill, terminate and send_signal to subprocess.Popen
...
The bits and pieces for the Windows side were already in place. The POSIX side is trivial (as usual) and uses os.kill().
2008-04-19 02:23:57 +00:00
Gregory P. Smith
70eb2f91b4
Fix issue 1300: Quote command line arguments that contain a '|' character in
...
subprocess.list2cmdline (windows).
2008-01-19 22:49:37 +00:00
Gregory P. Smith
92ffc634e4
Undo an unnecessary else: and indentation that r60104 added.
...
try:
...
except:
...
raise
else:
...
the else: is unecessary due to the blind except: with a raise.
2008-01-19 22:23:56 +00:00
Gregory P. Smith
87d49792b5
Fixes issue1336 - a race condition could occur when forking if the gc
...
kicked in during the critical section. solution: disable gc during
that section. Patch contributed by jpa and updated by me to cover the
race condition still existing what therve from twistedmatrix pointed
out (already seen and fixed in twisted's own subprocess code).
2008-01-19 20:57:59 +00:00
Gregory P. Smith
e047e6dd09
fix comment typos, use not arg instead of arg == "", add test coverage
...
for inside of the final if needquotes: within subprocess.list2cmdline().
2008-01-19 20:49:02 +00:00
Georg Brandl
309501a617
#1663329 : add os.closerange() to close a range of fds,
...
ignoring errors, and use this in subprocess to speed up
subprocess creation in close_fds mode. Patch by Mike Klaas.
2008-01-19 20:22:13 +00:00
Peter Astrand
81a191b351
Applied patch 1669481, slightly modified: Support close_fds on Win32
2007-05-26 22:18:20 +00:00
Neal Norwitz
82be218e97
Remove trailing whitespace in docstring
2007-05-11 06:56:52 +00:00
Neal Norwitz
aa87fb6be4
Fix typo in docstring (the module is popen2, not 3).
2007-05-11 06:23:01 +00:00
Georg Brandl
24522982d0
Bug #1704790 : bind name "sys" locally in __del__ method so that it is
...
not cleared before __del__ is run.
2007-04-21 20:35:38 +00:00
Tim Peters
ea5962f86e
Whitespace normalization.
2007-03-12 18:07:52 +00:00
Peter Astrand
5f9c6ae545
Applied patch 1124861.3.patch to solve bug #1124861 : Automatically create pipes on Windows, if GetStdHandle fails. Will backport.
2007-02-06 15:37:50 +00:00
Peter Astrand
f54000325b
We had several if statements checking the value of a fd. This is unsafe, since valid fds might be zero. We should check for not None instead.
2007-02-02 19:06:36 +00:00
Tim Peters
f733abb783
Whitespace normalization.
2007-01-30 03:03:46 +00:00
Peter Astrand
10514a70ac
Fix for bug #1634343 : allow specifying empty arguments on Windows
2007-01-13 22:35:35 +00:00
Peter Astrand
1812f8cf3f
Avoid O(N**2) bottleneck in _communicate_(). Fixes #1598181 .
2007-01-07 14:34:16 +00:00
Peter Astrand
ec05a2d580
Re-implemented fix for #1531862 once again, in a way that works with Python 2.2. Fixes bug #1603424 .
2007-01-07 08:53:46 +00:00
Neal Norwitz
a186ee22c0
SF bug #1623890 , fix argument name in docstring
2006-12-29 03:01:53 +00:00
Georg Brandl
6c0e1e8673
Bug #1357915 : allow all sequence types for shell arguments in
...
subprocess.
2006-10-29 09:05:04 +00:00
Gustavo Niemeyer
c36bede6ff
Fixed subprocess bug #1531862 again, after removing tests
...
offending buildbot
2006-09-07 00:48:33 +00:00
Neal Norwitz
314bef9fff
Revert 51758 because it broke all the buildbots
2006-09-06 03:58:34 +00:00
Gustavo Niemeyer
8cb64eaaf3
Fixing #1531862 : Do not close standard file descriptors in the
...
subprocess module.
2006-09-06 01:58:52 +00:00
Georg Brandl
13cf38c0cf
Guard for _active being None in __del__ method.
2006-07-20 16:28:39 +00:00
Tim Peters
73a9eade1c
Whitespace normalization.
2006-07-18 21:55:15 +00:00
Peter Astrand
7d1d43630e
Bug #1223937 : CalledProcessError.errno -> CalledProcessError.returncode.
2006-07-14 14:04:45 +00:00
Neal Norwitz
8440483fea
Fix doco. Backport candidate.
2006-07-10 00:05:34 +00:00
Peter Astrand
ff355f1ada
Applied patch #1506758 : Prevent MemoryErrors with large MAXFD.
2006-06-22 20:21:26 +00:00
Georg Brandl
ad62489e47
Bug #1500293 : fix memory leaks in _subprocess module.
2006-06-04 22:15:37 +00:00
Neal Norwitz
a6d01cec3f
Try to fix breakage caused by patch #1479181 , r45850
2006-05-02 06:23:22 +00:00
Martin v. Löwis
17de8ffc21
Patch #1467770 : Add Popen objects to _active only in __del__.
...
Introduce _child_active member to keep track on whether a child
needs to be waited for.
Backport candidate.
2006-04-10 15:55:37 +00:00
Peter Astrand
3a708dfc88
Changed license header: Now simply referring to PSF. This closes bug
...
1138653.
2005-09-23 17:37:29 +00:00
Tim Peters
eba28bea9b
Whitespace normalization.
2005-03-28 01:08:02 +00:00
Peter Astrand
7e78ade6f9
Corrected bug in list2cmdline wrt backslashes. Fixes #1083306 .
2005-03-03 21:10:23 +00:00
Peter Astrand
23109f0009
Optimization for communicate(): If only one of stdin/stdout/stderr is
...
redirected, using select() or threads is unnecessary.
2005-03-03 20:28:59 +00:00
Peter Astrand
c26516b29d
Made the module compatible with Python 2.2 again.
2005-02-21 08:13:02 +00:00
Peter Astrand
69bf13f1e8
Added copyright notice:
...
Licensed to PSF under a Contributor Agreement.
2005-02-14 08:56:32 +00:00
Peter Astrand
d38ddf4ca2
Patch from Leandro Lucarella: replaced:
...
var == None and var != None
with
var is None and var is not None
and type(var) == int
with
instanceof(var, int)
...as recomended in PEP 8 [1].
2005-02-10 08:32:50 +00:00
Raymond Hettinger
f715366f23
Reduce the usage of the types module.
2005-02-07 14:16:21 +00:00
Peter Astrand
f791d7a278
On UNIX, when the execution of the child fails, we must waitpid() to
...
prevent leaving zombies.
2005-01-01 09:38:57 +00:00
Peter Astrand
454f76711c
New subprocess utility function: check_call. Closes #1071764 .
2005-01-01 09:36:35 +00:00
Peter Astrand
5f5e141589
Changed signature of call function to avoid confusion: this 'args' is not the same as the one to the Popen constructor
2004-12-05 20:15:36 +00:00
Peter Astrand
738131d391
Raise TypeError if bufsize argument is not an integer. Patch 1071755, slightly modified.
2004-11-30 21:04:45 +00:00
Peter Astrand
6fdf3cbb13
Corrected example for replacing shell pipeline. Fixes bug 1073790.
2004-11-30 18:06:42 +00:00
Peter Astrand
c1d6536d60
When using shell=True on Windows, don't display a shell window by default. Fixes #1057061 .
2004-11-07 14:30:34 +00:00
Raymond Hettinger
837dd93e3b
Fix docstring formatting of escape sequences.
2004-10-17 16:36:53 +00:00
Fredrik Lundh
15aaacc93e
return codes are available on all platforms, not just on Unix
2004-10-17 14:47:05 +00:00