752bfb71d8
Remove trailing whitespace.
2013-01-16 15:16:10 +01:00
59a4a93f43
Issue #16422 : Use strings for rounding mode constants for better readability
...
and pickling compatibility.
2013-01-16 12:58:59 +01:00
ad1d5f908a
Issue #10527 : Use poll() instead of select() for multiprocessing pipes
2013-01-15 01:01:01 +00:00
25771b3749
Issue #16922 : fixed findtext() to return empty Unicode string instead of empty bytes object when there's no text.
...
Patch by Serhiy Storchaka.
2013-01-13 05:26:07 -08:00
b09b167419
Issue #16922 : fixed findtext() to return empty Unicode string instead of empty bytes object when there's no text.
...
Patch by Serhiy Storchaka.
2013-01-13 05:22:05 -08:00
4583990143
Clean trailing whitespace in _elementtree.c
2013-01-13 05:14:47 -08:00
0e5c48a917
make deque_clear void, since it's infallible
2013-01-12 21:22:18 -05:00
457a2292ca
SSLContext.load_dh_params() now properly closes the input file.
2013-01-12 21:43:45 +01:00
799e3edaf7
Issue #16076 : check for return value of PyTuple_New for args (following
...
Coverity report) and cleanup code.
2013-01-12 05:42:38 -08:00
b8f6dc855c
Issue #16076 : fix refleak in pickling of Element.
...
Thanks to Ezio Melotti and Daniel Shahaf for the patch.
2013-01-12 05:20:16 -08:00
e6174ca85e
Issue #16913 : Fix Element.itertext()'s handling of text with XML entities.
...
Patch by Serhiy Storchaka
2013-01-10 06:27:53 -08:00
698bdb2a6c
Issue #16076 : make _elementtree.Element pickle-able in a way that is compatible
...
with the Python version of the class.
Patch by Daniel Shahaf.
2013-01-10 06:01:06 -08:00
a2ad5c3ad1
Issue #15972 : Fix error messages when os functions expecting a file name or
...
file descriptor receive the incorrect type.
2013-01-07 23:13:46 +02:00
a873690d2c
The get() and iter() are now able to accept keyword arguments.
...
In conformance with the documentation and the Python version.
Patch by Franck Michea.
2013-01-05 06:26:39 -08:00
f402e922f3
Issue #16847 : Fixed improper use of _PyUnicode_CheckConsistency() in
...
non-pydebug builds. Several extension modules now compile cleanly when
assert()s are enabled in standard builds (-DDEBUG flag).
2013-01-03 09:21:55 +01:00
6f84659e5e
(Merge 3.2) Issue #16367 : Fix FileIO.readall() on Windows for files larger than 2 GB.
2013-01-03 03:37:47 +01:00
c44057dfbd
Issue #16367 : Fix FileIO.readall() on Windows for files larger than 2 GB
2013-01-03 03:33:21 +01:00
57cb81d161
Issue #16828 : Fix error incorrectly raised by bz2.compress('').
...
Initial patch by Martin Packman.
2013-01-02 23:05:56 +01:00
638fb9bbed
Issue #16828 : Fix error incorrectly raised by bz2.compress('').
...
Patch by Martin Packman.
2013-01-02 23:02:00 +01:00
e4110dc11f
Issue #9644 : Fix the encoding used by os.statvfs(): use the filesystem encoding
...
with the surrogateescape error handler, instead of UTF-8 in strict mode.
2013-01-01 23:05:55 +01:00
9b4599322d
Issue #9586 : Merge
2013-01-01 17:36:53 +00:00
9866231eab
Issue #9586 : Redefine SEM_FAILED on MacOSX to keep compiler happy.
2013-01-01 17:29:44 +00:00
b829dea0cd
Make indentation consistent
2013-01-01 07:41:51 -08:00
03ab4d3581
Make indentation consistent and remove dead commented-out code.
2012-12-31 15:34:20 -08:00
c1b59d4552
Issue #16688 : Fix backreferences did make case-insensitive regex fail on non-ASCII strings.
...
Patch by Matthew Barnett.
2012-12-29 23:38:48 +02:00
41dc9f3cd1
rename MathcObject to match object in doctrings for re module ( #16760 )
2012-12-25 18:49:08 +02:00
0b64c1415e
rename MathcObject to match object in doctrings for re module ( #16760 )
2012-12-25 18:48:54 +02:00
70dcef4789
Issue #16443 : Add docstrings to regular expression match objects.
...
Patch by Anton Kasyanov.
2012-12-23 19:59:27 +02:00
56ad5ed5ad
Issue #16443 : Add docstrings to regular expression match objects.
...
Patch by Anton Kasyanov.
2012-12-23 19:23:07 +02:00
e3dff55a5e
Issue #16753 : Define __GNUC_STDC_INLINE__ to an integer (same as gcc).
2012-12-23 15:42:21 +01:00
f03eee12b4
Issue #16745 : The gcc visibility pragma is buggy on OpenIndiana and NetBSD.
2012-12-22 23:05:51 +01:00
66a6f3fa81
Fix Visual Studio build.
2012-12-22 14:46:44 +01:00
fdf1a34ba1
Issue #16745 : Hide symbols in _decimal.so.
2012-12-22 14:18:35 +01:00
fb7f580e81
Issue #16745 : Hide a couple of symbols by making them local.
2012-12-21 23:11:05 +01:00
c51bafbbda
Merge with 3.2 : Don't DECREF the ctypes error_object without the GIL held.
2012-12-21 11:22:29 +00:00
3cbdaa3fee
Merge with 3.1 : Don't DECREF the ctypes error_object without the GIL held.
2012-12-21 11:20:53 +00:00
9946bd69fa
Don't DECREF the ctypes error_object without the GIL held.
2012-12-21 09:41:25 +00:00
68623614f0
call close on the underlying stream even if flush raises ( closes #16597 )
...
Patch by Serhiy Storchaka.
2012-12-20 11:53:11 -06:00
5b89840d9c
Issue #16714 : use 'raise' exceptions, don't 'throw'.
...
Patch by Serhiy Storchaka.
2012-12-18 21:26:36 +02:00
737fb89dd1
Issue #16714 : use 'raise' exceptions, don't 'throw'.
...
Patch by Serhiy Storchaka.
2012-12-18 21:14:22 +02:00
9a4ff437d1
Issue #15783 : Support None default values in the Context() constructor.
2012-12-16 21:10:35 +01:00
040e311826
Issue #15783 : Except for the number methods, the C version of decimal now
...
supports all None default values present in decimal.py. These values were
largely undocumented.
2012-12-15 22:33:33 +01:00
18d105b824
merge 3.2
2012-12-15 15:44:08 -05:00
7eb8a1a0cb
remove dead code
2012-12-15 15:43:58 -05:00
11def426c0
#16681 : merge with 3.2.
2012-12-14 20:13:39 +02:00
e3d7e54b11
#16681 : use "bidirectional class" instead of "bidirectional category" in the docstring too.
2012-12-14 20:12:25 +02:00
08d5ca6cd4
Code style fixup: No need for double ((parenthesis)) and use {} on an if else.
2012-12-10 20:22:31 -08:00
9504b13145
Code style fixup: No need for double ((parenthesis)) and use {} on an if else.
2012-12-10 20:20:20 -08:00
c0dd80e439
1 << 31 is invalid for signed integers, fix it by making 1 unsigned.
...
Found by Clang trunk's Undefined-Behavior Sanitizer. [more to come]
2012-12-10 17:45:03 -08:00
90555d0f0d
1 << 31 is invalid for signed integers, fix it by making 1 unsigned.
...
Found by Clang trunk's Undefined-Behavior Sanitizer. [more to come]
2012-12-10 17:44:44 -08:00
12f33df4a2
Issue #16628 : Fix a memory leak in ctypes.resize().
2012-12-08 11:07:16 +01:00
305e1a749f
Issue #16628 : Fix a memory leak in ctypes.resize().
2012-12-08 11:05:50 +01:00
2660e427d1
(Merge 3.2) Issue #16416 : On Mac OS X, operating system data are now always
...
encoded/decoded to/from UTF-8/surrogateescape, instead of the locale encoding
(which may be ASCII if no locale environment variable is set), to avoid
inconsistencies with os.fsencode() and os.fsdecode() functions which are
already using UTF-8/surrogateescape.
2012-12-03 12:48:53 +01:00
27b1ca29cc
Issue #16416 : On Mac OS X, operating system data are now always
...
encoded/decoded to/from UTF-8/surrogateescape, instead of the locale encoding
(which may be ASCII if no locale environment variable is set), to avoid
inconsistencies with os.fsencode() and os.fsdecode() functions which are
already using UTF-8/surrogateescape.
2012-12-03 12:47:59 +01:00
47a00f3d1a
support encoding error handlers that return bytes ( closes #16585 )
2012-12-02 11:20:28 -05:00
aff472394c
unicode -> str
2012-12-02 10:53:41 -05:00
9a2b26748b
Issue #10182 : The re module doesn't truncate indices to 32 bits anymore.
...
Patch by Serhiy Storchaka.
2012-12-02 12:54:28 +01:00
43fb54cd4f
Issue #10182 : The re module doesn't truncate indices to 32 bits anymore.
...
Patch by Serhiy Storchaka.
2012-12-02 12:52:36 +01:00
14b04cd350
Plug a leak in timemodule. The module dictionary is saved during
...
initialization. If the interpreter is shut down and reinitialized (embedded
CPython), the old module dictionary was not dec-refed during the next import of
the time extension module.
Contributed by Torsten Marek of Google.
2012-11-27 10:16:55 -08:00
9982c53c2f
Issue #12848 : The pure Python pickle implementation now treats object lengths as unsigned 32-bit integers, like the C implementation does.
...
Patch by Serhiy Storchaka.
2012-11-24 20:41:34 +01:00
bf6ecf92fa
Issue #12848 : The pure Python pickle implementation now treats object lengths as unsigned 32-bit integers, like the C implementation does.
...
Patch by Serhiy Storchaka.
2012-11-24 20:40:21 +01:00
8a6d1fed41
#16306 : merge with 3.2.
2012-11-23 18:52:39 +02:00
a0dd22e5e8
#16306 : report only the first unknown option and add more tests. Patch by Serhiy Storchaka.
2012-11-23 18:48:32 +02:00
39bdad813a
Issue #1160 : Fix compiling large regular expressions on UCS2 builds.
...
Patch by Serhiy Storchaka.
2012-11-20 22:30:42 +01:00
6ff262e18f
Issue #15677 : Document that zlib and gzip accept a compression level of 0 to mean 'no compression'.
...
Patch by Brian Brazil.
2012-11-11 14:14:47 +01:00
19e568d254
Issue #15677 : Document that zlib and gzip accept a compression level of 0 to mean 'no compression'.
...
Patch by Brian Brazil.
2012-11-11 14:04:14 +01:00
34b14951ee
Fixes issue #9535 : Fix pending signals that have been received but not
...
yet handled by Python to not persist after os.fork() in the child process.
2012-11-10 20:33:39 -08:00
9463e3ac8b
Fixes issue #9535 : Fix pending signals that have been received but not
...
yet handled by Python to not persist after os.fork() in the child process.
2012-11-10 20:33:07 -08:00
ec6dfcffa0
Issue #16411 : Fix a bug where zlib.decompressobj().flush() might try to access previously-freed memory.
...
Patch by Serhiy Storchaka.
2012-11-11 03:16:44 +01:00
7ee955550b
Issue #16411 : Fix a bug where zlib.decompressobj().flush() might try to access previously-freed memory.
...
Patch by Serhiy Storchaka.
2012-11-11 03:15:32 +01:00
dd1253abdd
Issue #16350 , part 2: Set unused_data (and unconsumed_tail) correctly in decompressobj().flush().
...
Additionally, fix a bug where a MemoryError in allocating a bytes object could
leave the decompressor object in an invalid state (with its unconsumed_tail
member being NULL).
Patch by Serhiy Storchaka.
2012-11-11 02:21:22 +01:00
ee7889dec3
Issue #16350 , part 2: Set unused_data (and unconsumed_tail) correctly in decompressobj().flush().
...
Additionally, fix a bug where a MemoryError in allocating a bytes object could
leave the decompressor object in an invalid state (with its unconsumed_tail
member being NULL).
Patch by Serhiy Storchaka.
2012-11-11 02:14:36 +01:00
6e467049c6
Accept Unicode legacy strings in the Decimal constructor.
2012-11-10 23:09:04 +01:00
0f82b76b57
Issue #16431 : Finally, consider all permutations.
2012-11-08 11:17:29 +01:00
ed16eff57e
Issue #16431 : Also fix the opposite direction.
2012-11-07 23:47:19 +01:00
f4abc7b8a0
Issue #16431 : Use the type information when constructing a Decimal subtype
...
from a Decimal argument.
2012-11-07 23:12:25 +01:00
519f43844b
Issue #16350 : Fix zlib decompressor handling of unused_data with multiple calls to decompress() after EOF.
...
Patch by Serhiy Storchaka.
2012-11-05 00:38:48 +01:00
39079946a2
Issue #16350 : Fix zlib decompressor handling of unused_data with multiple calls to decompress() after EOF.
...
Patch by Serhiy Storchaka.
2012-11-05 00:37:42 +01:00
e6996ed5d9
Issue #16145 : Support legacy strings in the _csv module.
2012-11-02 14:44:20 +01:00
0168d3d9b1
Issue #16230 : Fix a crash in select.select() when one the lists changes size while iterated on.
...
Patch by Serhiy Storchaka.
2012-11-01 20:15:23 +01:00
e4ad37e50e
Issue #16230 : Fix a crash in select.select() when one the lists changes size while iterated on.
...
Patch by Serhiy Storchaka.
2012-11-01 20:13:54 +01:00
5ebe65f8cb
Issue #16228 : Fix a crash in the json module where a list changes size while it is being encoded.
...
Patch by Serhiy Storchaka.
2012-11-01 19:59:21 +01:00
9f69e79c45
Issue #16228 : Fix a crash in the json module where a list changes size while it is being encoded.
...
Patch by Serhiy Storchaka.
2012-11-01 19:52:06 +01:00
796c443f3d
Merge: fix docstring for deque ctor to mark iterable parameter optional
2012-10-31 11:51:13 +02:00
6a5c7c341a
Fix docstring for deque ctor to mark iterable parameter optional
2012-10-31 11:50:40 +02:00
e8ea97fffb
merge 3.2 ( #16369 )
2012-10-30 23:27:52 -04:00
c43112823b
initialize more global type objects ( closes #16369 )
2012-10-30 23:21:10 -04:00
4648b4779a
#14897 : Enhance error messages of struct.pack and struct.pack_into
...
Patch by Matti Mäki.
2012-10-29 21:25:01 +02:00
92c28cace4
#14897 : Enhance error messages of struct.pack and struct.pack_into
...
Patch by Matti Mäki.
2012-10-29 21:24:07 +02:00
039e0cdc28
Issue #16305 : Merge fix from 3.2.
2012-10-25 10:47:46 +01:00
76464494bc
Fix math.factorial KeyboardInterrupt segfault. Thanks Amaury for report and diagnosis.
2012-10-25 10:46:28 +01:00
5445a8cb41
Replace tabs with spaces in posixmodule.c
2012-10-23 16:29:59 +03:00
18b7fcc7a6
Merge #14398 : Fix size truncation and overflow bugs in bz2 module.
2012-10-21 21:16:58 +02:00
5f8f0d6777
Issue #14398 : Fix size truncation and overflow bugs in bz2 module.
2012-10-21 21:13:27 +02:00
a10ddb8a55
Fixes Issue #16114 : The subprocess module no longer provides a
...
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.
2012-10-10 03:44:47 -07:00
5591b02a4c
Fixes Issue #16114 : The subprocess module no longer provides a
...
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.
It now keeps track of if the child got as far as preexec and reports it if
not back to the parent via a special "noexec" error message value in
the error pipe so that the cwd can be blamed for a failed chdir
instead of the exec of the executable being blamed instead.
The executable is also always reported accurately when exec fails.
Unittests enhanced to cover these cases.
2012-10-10 03:34:47 -07:00
c04ddff290
Issue #16096 : Fix several occurrences of potential signed integer overflow. Thanks Serhiy Storchaka.
2012-10-06 18:04:49 +01:00
ee329318db
Issue #16089 : Allow ElementTree.TreeBuilder to work again with a non-Element element_factory (fixes a regression in SimpleTAL).
2012-10-04 19:53:29 +02:00
6e1d2b6e78
Closes #16126 : PyErr_Format format mismatch in _testcapimodule.c
2012-10-04 16:06:30 +02:00
cf45325b61
Closes #15897 : zipimport.c doesn't check return value of fseek(). Typo
2012-10-03 03:16:42 +02:00
fb22f542d2
MERGE: Closes #15897 : zipimport.c doesn't check return value of fseek()
2012-10-03 03:00:37 +02:00
09bf7a799d
Closes #15897 : zipimport.c doesn't check return value of fseek()
2012-10-03 02:13:05 +02:00
c194884983
Sanitize and modernize some of the _elementtree code (see issue #16089 ).
2012-10-01 23:40:37 +02:00
a0346e56ac
Support gcc's -ansi flag: use "__asm__" instead of "asm".
2012-09-30 17:31:04 +02:00
e59aa8c94d
Revert 29506c7db353 (build output should be accurate).
2012-09-30 17:20:47 +02:00
5c9a5895d4
merge
2012-09-30 15:51:39 +02:00
72c9946718
Change libmpdec to use ANSI code in strict ansi mode as inline asm isn't supported in ANSI C
2012-09-30 15:49:56 +02:00
9a3f05e60f
Make it clear that the pi function is modified for benchmarking purposes.
2012-09-30 09:24:41 +02:00
6b6a1df996
Restore the benchmark order to avoid waiting for decimal.py if just the
...
prec=9 test is used.
2012-09-25 17:07:55 +02:00
6cf50c5b1d
Fix whitespace.
2012-09-25 10:26:15 -04:00
63092fe0ea
Fix whitespace.
2012-09-25 10:25:41 -04:00
d266c4451f
Make the decimal bench file run under Python 2.7.
2012-09-25 10:23:47 -04:00
49d130227b
merge 3.2: Issue #16013 : Fix CSV Reader parsing issue with ending quote characters. Patch by Serhiy Storchaka.
2012-09-25 02:37:20 -07:00
67b7b98a47
Issue #16013 : Fix CSV Reader parsing issue with ending quote characters. Patch by Serhiy Storchaka.
2012-09-25 02:30:27 -07:00
22340be15e
Issue #16012 : Fix a regression in pyexpat. The parser's UseForeignDTD()
...
method doesn't require an argument again.
2012-09-24 13:27:28 +02:00
e26d3af7ee
Issue #16012 : Fix a regression in pyexpat. The parser's UseForeignDTD()
...
method doesn't require an argument again.
2012-09-24 13:17:08 +02:00
3b9493b53c
Use C-style comments for C89 / ANSI C compatibility
2012-09-23 16:11:15 +02:00
91ceeceea7
Use C-style comments (required for the AIX build slave).
2012-09-23 15:51:16 +02:00
7e6523fbd7
Use C-style comments.
2012-09-23 15:46:09 +02:00
a3ff101e6a
Issue #5969 : faulthandler module: rename dump_tracebacks_later() to
...
dump_traceback_later() and cancel_dump_tracebacks_later() to
cancel_dump_traceback_later().
2012-09-23 11:06:21 +02:00
57caede470
Issue #15973 : fixed 3.2 backport.
2012-09-20 17:23:46 -04:00
9b9ed867bc
merged 3.2
2012-09-20 16:42:34 -04:00
3ec153681e
Issue #15973 : Fixed segmentation fault on timezone comparison to other types.
2012-09-20 16:39:33 -04:00
ca8aa4acf6
Issue #15144 : Fix possible integer overflow when handling pointers as integer values, by using Py_uintptr_t instead of size_t.
...
Patch by Serhiy Storchaka.
2012-09-20 20:56:47 +02:00
1c47222a25
merge
2012-09-20 12:43:24 +02:00
5cb31c9277
Issue #15977 : Fix memory leak in Modules/_ssl.c when the function _set_npn_protocols() is called multiple times
2012-09-20 12:42:54 +02:00
9a46105a89
#15965 : Explicitly cast AT_FDCWD as (int).
...
Required on Solaris 10 (which defines AT_FDCWD as 0xffd19553),
harmless on other platforms.
2012-09-18 21:50:06 -04:00
6d10b4d591
#15796 : merge with 3.2.
2012-09-18 07:21:18 +03:00
16d2b47837
#15796 : Fix \n in readline docstring. Patch by Serhiy Storchaka.
2012-09-18 07:20:18 +03:00
9d20e0edd9
Issue #15926 : Fix crash after multiple reinitializations of the interpreter.
2012-09-12 18:01:36 +02:00
6f3e5e48d3
remove useless and defined initialization ( closes #15921 )
2012-09-11 12:05:05 -04:00
b7a2800831
MERGE: Closes #15793 : Stack corruption in ssl.RAND_egd()
2012-09-11 02:08:48 +02:00
c8754a13e6
Closes #15793 : Stack corruption in ssl.RAND_egd()
2012-09-11 02:00:58 +02:00
67bd81b867
MERGE: #15676 : mmap: add empty file check prior to offset check <- Previous patch was incomplete (fix 2)
2012-09-10 22:58:35 +02:00
e8db356cf1
#15676 : mmap: add empty file check prior to offset check <- Previous patch was incomplete (fix 2)
2012-09-10 22:58:07 +02:00
4886d5b338
#15676 : mmap: add empty file check prior to offset check <- Previous patch was incomplete
2012-09-10 22:50:21 +02:00
1f2799bef4
#15676 : mmap: add empty file check prior to offset check <- Previous patch was incomplete
2012-09-10 22:49:50 +02:00
76e12179c5
Issue #15882 : Change _decimal to accept any coefficient tuple when
...
constructing infinities. This is done for backwards compatibility
with decimal.py: Infinity coefficients are undefined in _decimal
(in accordance with the specification).
2012-09-10 19:34:58 +02:00
f47d79fec1
Fixed reference leak in error branch of _bufferedreader_read_all(). The variable data can contain a bytes object but it wasn't cleaned up when PyList_New() failed. CID 715364
2012-09-10 17:46:09 +02:00
89ff3c7f20
Fixed out-of-bounce write to rawmode buffer. The fixed size buffer wasn't enlarged for the new 'x' flag. The buffer may contain the 5 flags xrwa+ and the \0 byte
2012-09-10 03:50:48 +02:00
1b5c76a283
Fixed two memory leaks in make_filename() in zipimport.c. The allocated buffer wasn't cleaned up in two error cases. CID 486832
2012-09-10 02:00:34 +02:00
15b6885fe0
Make sure that *really* no more than sizeof(ifr.ifr_name) chars are strcpy-ed to ifr.ifr_name and that the string is *always* NUL terminated. New code shouldn't use strcpy(), too. CID 719692
2012-09-10 01:25:50 +02:00
1b3f3b0316
Closes #15676 : mmap: add empty file check prior to offset check
2012-09-10 01:23:05 +02:00
941bfcc537
Closes #15676 : mmap: add empty file check prior to offset check
2012-09-10 00:27:55 +02:00
ea94ba45fa
Merge 3.2.
2012-09-08 11:19:27 +02:00
96efdd422c
Issue #15868 : Fix refleak in bytesio.c (Coverity #715365 ).
2012-09-08 11:12:33 +02:00
2dabaf63cf
Issue #15876 : Fix a refleak in the curses module
...
The refleak occurred when assigning to window.encoding.
2012-09-07 08:34:23 +02:00
527a2400fb
_testbuffer.c: In all current use cases of cmp_structure() dest->format and
...
src->format are either both NULL or both non-NULL. However, it is safer to
generalize the function. Found by Coverity.
2012-09-06 09:42:29 +02:00
11946fbe80
Issue #15841 : The readable(), writable() and seekable() methods of BytesIO
...
and StringIO objects now raise ValueError when the object has been closed.
Patch by Alessandro Moura.
2012-09-05 20:13:48 +02:00
1d857453b7
Issue #15841 : The readable(), writable() and seekable() methods of BytesIO
...
and StringIO objects now raise ValueError when the object has been closed.
Patch by Alessandro Moura.
2012-09-05 20:11:49 +02:00
Stefan Krah
Richard Oudkerk
Eli Bendersky
Benjamin Peterson
Antoine Pitrou
Serhiy Storchaka
Christian Heimes
Victor Stinner
Nadeem Vawda
Andrew Svetlov
Kristjan Valur Jonsson
Ezio Melotti
Gregory P. Smith
Petri Lehtinen
Mark Dickinson
Jesus Cea
Brett Cannon
Senthil Kumaran
Alexander Belopolsky
Trent Nelson
Ross Lagerwall