c1b4e8e6e2
Patch #1462488 : prevent a segfault in object_reduce_ex() by splitting
...
the implementation for __reduce__ and __reduce_ex__ into two separate
functions. Fixes bug #931877 .
(backport from rev. 54397)
2007-03-15 11:47:59 +00:00
94c887258c
Patch #1680015 : Don't modify __slots__ tuple if it contains an unicode
...
name. Remove a reference leak that happened if the name could not be
converted to string.
(backport from rev. 54378)
2007-03-14 12:34:30 +00:00
ad3d2c2fe4
Patch #1675981 : remove unreachable code from type.__new__() method.
...
__dict__ and __weakref__ are removed from the slots tuple earlier
in the code, in the loop that mangles slot names.
(backport from rev. 54270)
2007-03-11 16:01:51 +00:00
e7881559f2
Fix SF #1676971 , Complex OverflowError has a typo
2007-03-09 06:01:28 +00:00
ffb0a804c6
Patch #1638879 : don't accept strings with embedded NUL bytes in long().
...
(backport from rev. 54173)
2007-03-06 18:44:35 +00:00
5f795865da
Backport from Py3k branch: fix refleak in PyString_Format.
...
(backport from rev. 53935)
2007-02-26 13:51:34 +00:00
d621a6e8dc
Fixup set/dict interoperability.
2007-02-19 20:45:46 +00:00
1bff796983
Extend work on revision 52962: Eliminate redundant calls to PyObject_Hash().
2007-02-19 03:04:45 +00:00
b4af42a635
Bug #1653736 : Properly discard third argument to slot_nb_inplace_power.
2007-02-09 12:19:46 +00:00
fdf7bf8305
Bypass set specific optimizations for set and frozenset subclasses.
2007-02-08 00:49:51 +00:00
9f0e1ea964
Do not let overflows in enumerate() and count() pass silently.
2007-02-07 23:57:05 +00:00
bbe92887ce
Silence compiler warning
2007-02-07 23:48:15 +00:00
127ef44c7b
Bug #1575169 : operator.isSequenceType() now returns False for subclasses of dict.
2007-02-07 22:12:01 +00:00
20dcf1cb9d
SF #1615701 : make d.update(m) honor __getitem__() and keys() in dict subclasses
2007-02-07 20:01:28 +00:00
21191f4f0c
Bug #1648179 : set.update() not recognizing __iter__ overrides in dict subclasses.
2007-02-01 21:01:21 +00:00
75ba075110
If you created a weakref in an object's __del__ method to itself it would
...
segfault the interpreter during weakref clean up. Now any new weakrefs created
after __del__ is run are removed silently.
Fixes bug #1377858 and the weakref_in_del crasher for new-style classes.
Classic classes are still affected.
2007-01-23 22:41:20 +00:00
e471317a08
Backport trunk revision 53527:
...
SF patch #1630975 : Fix crash when replacing sys.stdout in sitecustomize
When running the interpreter in an environment that would cause it to set
stdout/stderr/stdin's encoding, having a sitecustomize that would replace
them with something other than PyFile objects would crash the interpreter.
Fix it by simply ignoring the encoding-setting for non-files.
This could do with a test, but I can think of no maintainable and portable
way to test this bug, short of adding a sitecustomize.py to the buildsystem
and have it always run with it (hmmm....)
2007-01-23 13:54:30 +00:00
535989ecb6
SF #1486663 -- Allow keyword args in subclasses of set() and frozenset().
2007-01-11 18:21:04 +00:00
9cdf70399f
For sets with cyclical reprs, emit '...' instead of recursing.
2006-12-29 18:49:13 +00:00
775ebe29a5
Backport fixes to set objects:
...
rev 52964 sf 1576657 KeyError unpacks tuple arguments
rev 52963 sf 1456209 obscure resizing vulnerability
rev 52962 redundant calls to PyObject_Hash()
2006-12-08 18:12:24 +00:00
a1e3422205
Correctly forward exception in instance_contains().
...
Fixes #1591996 . Patch contributed by Neal Norwitz.
2006-11-08 06:46:49 +00:00
ae6b84184b
Fix refleak
2006-10-29 23:42:59 +00:00
5e9f94ac7a
Bug #1576657 : when setting a KeyError for a tuple key, make sure that
...
the tuple isn't used as the "exception arguments tuple".
(backport from rev. 52535)
2006-10-29 18:31:45 +00:00
ca63121553
Backport 52506:
...
Don't inline Py_ADDRESS_IN_RANGE with gcc 4+ either.
2006-10-28 21:39:31 +00:00
e0cf624747
Backport 52505:
...
Prevent crash if alloc of garbage fails. Found by Typo.pl.
2006-10-28 21:39:10 +00:00
7e3ec048f9
Backport 52502:
...
Fix warnings with HP's C compiler. It doesn't recognize that infinite
loops are, um, infinite. These conditions should not be able to happen.
2006-10-28 21:37:16 +00:00
a0a50feea8
WindowsError.str should display the windows error code,
...
not the posix error code; with test.
Fixes #1576174 .
Backported from trunk, revision 52485.
2006-10-27 18:47:29 +00:00
dd4c398c27
Bug #1545497 : when given an explicit base, int() did ignore NULs
...
embedded in the string to convert.
(backport from rev. 52305)
2006-10-12 11:28:04 +00:00
4b63c21d6f
Forward-port of r52136: a review of overflow-detecting code.
...
* unified the way intobject, longobject and mystrtoul handle
values around -sys.maxint-1.
* in general, trying to entierely avoid overflows in any computation
involving signed ints or longs is extremely involved. Fixed a few
simple cases where a compiler might be too clever (but that's all
guesswork).
* more overflow checks against bad data in marshal.c.
* 2.5 specific: fixed a number of places that were still confusing int
and Py_ssize_t. Some of them could potentially have caused
"real-world" breakage.
* list.pop(x): fixing overflow issues on x was messy. I just reverted
to PyArg_ParseTuple("n"), which does the right thing. (An obscure
test was trying to give a Decimal to list.pop()... doesn't make
sense any more IMHO)
* trying to write a few tests...
2006-10-04 11:44:06 +00:00
10525ad313
Fix integer negation and absolute value to not rely
...
on undefined behaviour of the C compiler anymore.
2006-10-04 05:47:47 +00:00
506cc189a9
Bug #1566800 : make sure that EnvironmentError can be called with any
...
number of arguments, as was the case in Python 2.4.
(backport from rev. 52061)
2006-09-30 09:03:45 +00:00
af4337a017
Patch #1567691 : super() and new.instancemethod() now don't accept
...
keyword arguments any more (previously they accepted them, but didn't
use them).
(backport from rev. 52058)
2006-09-30 08:43:50 +00:00
c70e003f75
Backport of fix to allow exception instances to be sliced once again.
2006-09-21 18:12:15 +00:00
19d76c5aa8
Remove __unicode__ method so that ``unicode(BaseException)`` succeeds.
...
Fixes bug #1551432 .
2006-09-09 07:18:44 +00:00
8de403a56a
Backport rev. 51798 from trunk:
...
fix setobject.c refcounts and error checks.
2006-09-08 06:02:26 +00:00
ecab623e13
Bug #1542051 : Exceptions now correctly call PyObject_GC_UnTrack.
...
Also make sure that every exception class has __module__ set to
'exceptions'.
(backport)
2006-09-06 06:47:02 +00:00
fe50f8e961
Backport 51669: Make sure memory is properly cleaned up in file_init (even though this should not be able to happen since we already parsed the args)
2006-09-05 04:32:06 +00:00
29a5fdb7ca
Fix str.rpartition(sep) when sep is not found in str.
...
Partially from SF patch #1551339 , but also taken from head.
2006-09-05 02:21:38 +00:00
d3da7d394a
Fix SF bug #1546288 , crash in dict_equal
2006-09-05 01:54:06 +00:00
cbdd350dd7
i_divmod(): As discussed on Python-Dev, changed the overflow
...
checking to live happily with recent gcc optimizations that
assume signed integer arithmetic never overflows.
2006-09-05 01:47:53 +00:00
19c35bba5d
- Patch #1541585 : fix buffer overrun when performing repr() on
...
a unicode string in a build with wide unicode (UCS-4) support.
I will forward port to 2.6. Can someone backport to 2.4?
2006-08-21 22:13:11 +00:00
47f0ffa7ee
Fix a couple of ssize-t issues reported by Alexander Belopolsky on python-dev
2006-08-21 18:44:09 +00:00
3ba24783ba
Move initialization of interned strings to before allocating the
...
object so we don't leak op. (Fixes an earlier patch to this code)
Klockwork #350
2006-08-19 04:19:14 +00:00
271a8689e9
Subclasses of int/long are allowed to define an __index__.
2006-08-15 06:29:03 +00:00
26a07b5198
Fix refleak introduced in rev. 51248.
2006-08-14 20:25:39 +00:00
3a457790c7
Correct an accidentally removed previous patch.
2006-08-14 12:57:27 +00:00
040f76b79c
Slightly revised version of patch #1538956 :
...
Replace UnicodeDecodeErrors raised during == and !=
compares of Unicode and other objects with a new
UnicodeWarning.
All other comparisons continue to raise exceptions.
Exceptions other than UnicodeDecodeErrors are also left
untouched.
2006-08-14 10:55:19 +00:00
af33f2d571
Can't return NULL from a void function. If there is a memory error,
...
about the best we can do is call PyErr_WriteUnraisable and go on.
We won't be able to do the call below either, so verify delstr is valid.
2006-08-14 00:59:03 +00:00
56423e5762
Fix segfault when doing string formatting on subclasses of long if
...
__oct__, __hex__ don't return a string.
Klocwork 308
2006-08-13 18:11:08 +00:00
b09f4f578f
Handle a whole lot of failures from PyString_FromInternedString().
...
Should fix most of Klocwork 234-272.
2006-08-13 18:10:28 +00:00
1872b1c01f
Fix a couple of bugs exposed by the new __index__ code. The 64-bit buildbots
...
were failing due to inappropriate clipping of numbers larger than 2**31
with new-style classes. (typeobject.c) In reviewing the code for classic
classes, there were 2 problems. Any negative value return could be returned.
Always return -1 if there was an error. Also make the checks similar
with the new-style classes. I believe this is correct for 32 and 64 bit
boxes, including Windows64.
Add a test of classic classes too.
2006-08-12 18:44:06 +00:00
8a87f5d37e
Patch #1538606 , Patch to fix __index__() clipping.
...
I modified this patch some by fixing style, some error checking, and adding
XXX comments. This patch requires review and some changes are to be expected.
I'm checking in now to get the greatest possible review and establish a
baseline for moving forward. I don't want this to hold up release if possible.
2006-08-12 17:03:09 +00:00
b88cfad318
Check return of PyMem_MALLOC (garbage) is non-NULL.
...
Check seq in both portions of if/else.
Klocwork #289-290.
2006-08-12 03:16:54 +00:00
421c1319ad
Whoops, how did that get in there. :-) Revert all the parts of 51227 that were not supposed to go it. Only Modules/_ctypes/cfields.c was supposed to be changed
2006-08-12 02:12:30 +00:00
6b4953fd3d
Check returned pointer is valid.
...
Klocwork #233
2006-08-12 02:06:34 +00:00
6f5ff3f3eb
Klocwork made another run and found a bunch more problems.
...
This is the first batch of fixes that should be easy to verify based on context.
This fixes problem numbers: 220 (ast), 323-324 (symtable),
321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree).
2006-08-12 01:43:40 +00:00
51fc8c456e
Fix and test for an infinite C recursion.
2006-08-09 14:55:26 +00:00
ab2f8f7bd5
__hash__ may now return long int; the final hash
...
value is obtained by invoking hash on the long int.
Fixes #1536021 .
2006-08-09 07:57:39 +00:00
ab1049c046
memcmp() can return values other than -1, 0, and +1 but tp_compare
...
must not.
2006-08-08 17:37:00 +00:00
b0061c8e93
Remove "non-mapping" and "non-sequence" from TypeErrors raised by
...
PyMapping_Size and PySequence_Size.
Because len() tries first sequence, then mapping size, it will always
raise a "non-mapping object has no len" error which is confusing.
2006-08-08 11:56:21 +00:00
0067b5fa2b
Typo fixes
2006-08-04 20:37:43 +00:00
e9462c72bd
Change fix for segfaulting property(), add a NEWS entry and a test.
2006-08-04 18:03:37 +00:00
45381938e9
Fix bug caused by first decrefing, then increfing.
2006-08-04 06:03:53 +00:00
7a36f5f344
SF patch #1534048 (bug #1531003 ): fix typo in error message
2006-08-04 05:17:21 +00:00
c5e060dee6
_PyWeakref_GetWeakrefCount() now returns a Py_ssize_t instead of long.
2006-08-02 06:14:22 +00:00
5a51bf50b8
typo fix
2006-08-01 16:24:30 +00:00
a7edb11122
Whitespace normalization
2006-07-30 06:59:13 +00:00
f71ec5a0ac
Bug #1515471 : string.replace() accepts character buffers again.
...
Pass the char* and size around rather than PyObject's.
2006-07-30 06:57:04 +00:00
52740be425
[Bug #1414697 ] Change docstring of set/frozenset types to specify that the contents are unique. Raymond, please feel free to edit or revert.
2006-07-29 15:10:32 +00:00
101bac205d
Closure can't be NULL at this point since we know it's a tuple.
...
Reported by Klocwork # 74.
2006-07-27 03:55:39 +00:00
c09efa8444
Move the initialization of size_a down below the check for a being NULL.
...
Reported by Klocwork #106
2006-07-23 07:53:14 +00:00
e1fdb32ff2
Handle allocation failures gracefully. Found with failmalloc.
...
Many (all?) of these could be backported.
2006-07-21 05:32:28 +00:00
1adbb50701
Move the initialization of some pointers earlier. The problem is
...
that if we call Py_DECREF(frame) like we do if allocating locals fails,
frame_dealloc() will try to use these bogus values and crash.
2006-07-21 05:31:02 +00:00
48808a1d6c
Add some asserts that we got good params passed
2006-07-21 05:29:58 +00:00
04e39ec815
otherset is known to be non-NULL based on checks before and DECREF after.
...
DECREF otherset rather than XDECREF in error conditions too.
Reported by Klockwork #154 .
2006-07-17 00:57:15 +00:00
b337bb541b
Stop INCREFing name, then checking if it's NULL. name (f_name) should never
...
be NULL so assert it. Fix one place where we could have passed NULL.
Reported by Klocwork #66 .
2006-07-17 00:55:45 +00:00
ee4cc698ca
PyFunction_SetDefaults() is documented as taking None or a tuple.
...
A NULL would crash the PyTuple_Check(). Now make NULL return a SystemError.
Reported by Klocwork #73 .
2006-07-16 02:35:47 +00:00
fc28e0de58
Handle a NULL name properly.
...
Reported by Klocwork #67
2006-07-16 02:32:03 +00:00
4b0a315c31
Use sizeof(buffer) instead of duplicating the constants to ensure they won't
...
be wrong.
The real change is to pass (bufsz - 1) to PyOS_ascii_formatd and 1
to strncat. strncat copies n+1 bytes from src (not dest).
Reported by Klocwork #58 .
2006-07-16 02:22:30 +00:00
ef02b9e144
a & b were dereffed above, so they are known to be valid pointers.
...
z is known to be NULL, nothing to DECREF.
Reported by Klockwork, #107 .
2006-07-16 02:00:32 +00:00
7e49c6eee8
Fix uninitialized memory read reported by Valgrind when running doctest.
...
This could happen if size == 0.
2006-07-12 05:27:46 +00:00
74c3ea0a0f
Fix build problems with the platform SDK on windows. It is not sufficient to test for the C compiler version when determining if we have the secure CRT from microsoft. Must test with an undocumented macro, __STDC_SECURE_LIB__ too.
2006-07-03 14:59:05 +00:00
d5cfa5491a
Put method-wrappers into trashcan. Fixes #927248 .
2006-07-03 13:47:40 +00:00
0f415dc57f
Another problem reported by Coverity. Backport candidate.
2006-06-30 07:32:46 +00:00
b114984225
Fix refleak
2006-06-23 03:32:44 +00:00
53c1692f6a
Fix for an obscure bug introduced by revs 46806 and 46808, with a test.
...
The problem of checking too eagerly for recursive calls is the
following: if a RuntimeError is caused by recursion, and if code needs
to normalize it immediately (as in the 2nd test), then
PyErr_NormalizeException() needs a call to the RuntimeError class to
instantiate it, and this hits the recursion limit again... causing
PyErr_NormalizeException() to never finish.
Moved this particular recursion check to slot_tp_call(), which is not
involved in instantiating built-in exceptions.
Backport candidate.
2006-06-21 21:58:50 +00:00
0f2783cb4c
Use Py_ssize_t
2006-06-19 05:40:44 +00:00
ccff785258
Patch #1507676 : improve exception messages in abstract.c, object.c and typeobject.c.
2006-06-18 22:17:29 +00:00
d825143be1
Patch #1455898 : Incremental mode for "mbcs" codec.
2006-06-14 05:21:04 +00:00
ea3912b0da
If a classic class defined a __coerce__() method that just returned its two
...
arguments in reverse, the interpreter would infinitely recourse trying to get a
coercion that worked. So put in a recursion check after a coercion is made and
the next call to attempt to use the coerced values.
Fixes bug #992017 and closes crashers/coerce.py .
2006-06-13 21:46:41 +00:00
de4c78a1d7
Initialize the type object so pychecker can't crash the interpreter.
2006-06-13 08:28:19 +00:00
f608317061
Fix the CRT argument error handling for VisualStudio .NET 2005. Install a CRT error handler and disable the assertion for debug builds. This causes CRT to set errno to EINVAL.
...
This update fixes crash cases in the test suite where the default CRT error handler would cause process exit.
2006-06-12 15:45:12 +00:00
b9845e72f9
Get rid of f_restricted too. Doc the other 4 ints that were already removed
...
at the NeedForSpeed sprint.
2006-06-12 02:11:18 +00:00
a00c0b97bf
Don't leak the list object if there's an error allocating the item storage. Backport candidate
2006-06-12 02:08:41 +00:00
7d5b6e8991
f_code can't be NULL based on Frame_New and other code that derefs it.
...
So there doesn't seem to be much point to checking here.
2006-06-11 05:48:14 +00:00
8e6675a7dc
Update doc to make it agree with code.
...
Bottom factor out some common code.
2006-06-11 05:47:14 +00:00
9a8ae8f46b
Suppress warning on MacOSX about possible use before set of proc.
2006-06-10 22:38:13 +00:00
0e8bd7e1cc
Patch #1495999 : Part two of Windows CE changes.
...
- update header checks, using autoconf
- provide dummies for getenv, environ, and GetVersion
- adjust MSC_VER check in socketmodule.c
2006-06-10 12:23:46 +00:00
acd0d6d416
SF bug #1503294 .
...
PyThreadState_GET() complains if the tstate is NULL, but only in debug mode.
2006-06-10 10:57:40 +00:00
90e27d38f5
Apply perky's fix for #1503157 : "/".join([u"", u""]) raising OverflowError.
...
Also improve error message on overflow.
2006-06-10 06:40:50 +00:00
Žiga Seilnacht
Neal Norwitz
Georg Brandl
Raymond Hettinger
Martin v. Löwis
Brett Cannon
Thomas Wouters
Thomas Heller
Armin Rigo
Tim Peters
Marc-André Lemburg
Andrew M. Kuchling
Fred Drake
Kristján Valur Jónsson
Skip Montanaro