Commit Graph

101 Commits

Author SHA1 Message Date
Benjamin Peterson 8b59c23a54 you can't get resource.error if you can't import resource 2011-12-10 12:31:42 -05:00
Charles-François Natali 2a34eb3104 Issue #12786: Set communication pipes used by subprocess.Popen CLOEXEC to avoid
them being inherited by other subprocesses.
2011-08-25 21:20:54 +02:00
Nadeem Vawda 860593653b Fix resource leaks in test_subprocess. 2011-08-19 05:22:24 +02:00
Charles-François Natali a8085d306e Issue #12650: fix failures on some buildbots, when a subprocess takes a long
time to spawn.
2011-08-19 00:26:38 +02:00
Charles-François Natali 100df0f2b0 Issue #12650: only run the tests on Unix. 2011-08-18 17:56:02 +02:00
Charles-François Natali b02302c5cf Issue #12650: Fix a race condition where a subprocess.Popen could leak
resources (FD/zombie) when killed at the wrong time.
2011-08-18 17:18:28 +02:00
Ross Lagerwall d8e3901478 Issue #12607: In subprocess, fix issue where if stdin, stdout or stderr is
given as a low fd, it gets overwritten.
2011-07-27 18:54:53 +02:00
Victor Stinner b78fed9ee6 Issue #12493: skip test_communicate_eintr() if signal.SIGALRM is missing 2011-07-05 14:50:35 +02:00
Victor Stinner e790131dc6 Issue #12493: subprocess: communicate() handles EINTR
subprocess.Popen.communicate() now also handles EINTR errors if the process has
only one pipe.
2011-07-05 14:08:01 +02:00
Victor Stinner e9b185f263 Issue #12085: Fix test_subprocess for my previous commit
Replace support by test_support, and add captured_stderr() function.
2011-06-01 01:57:48 +02:00
Victor Stinner 776e69b5b3 Close #12085: Fix an attribute error in subprocess.Popen destructor if the
constructor has failed, e.g. because of an undeclared keyword argument. Patch
written by Oleg Oshmyan.
2011-06-01 01:03:00 +02:00
Ross Lagerwall 104c3f1020 Issue #10963: Ensure that subprocess.communicate() never raises EPIPE. 2011-04-05 15:24:34 +02:00
R David Murray cdd5fc9013 #11490: EACCES can also mean command not found 2011-03-13 22:37:18 -04:00
Antoine Pitrou 91ce0d933c Merged revisions 87695 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87695 | antoine.pitrou | 2011-01-03 19:23:55 +0100 (lun., 03 janv. 2011) | 5 lines

  Issue #10806, issue #9905: Fix subprocess pipes when some of the standard
  file descriptors (0, 1, 2) are closed in the parent process.  Initial
  patch by Ross Lagerwall.
........
2011-01-03 18:45:09 +00:00
Gregory P. Smith 312efbc115 Merged revisions 87233 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87233 | gregory.p.smith | 2010-12-14 06:38:00 -0800 (Tue, 14 Dec 2010) | 4 lines

  Issue #1731717: Fixed the problem where subprocess.wait() could cause an
  OSError exception when The OS had been told to ignore SIGCLD in our process
  or otherwise not wait for exiting child processes.
........
2010-12-14 15:02:53 +00:00
Brian Curtin 7fe045ef00 Merged revisions 86207 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86207 | brian.curtin | 2010-11-05 12:09:05 -0500 (Fri, 05 Nov 2010) | 2 lines

  Fix a number of ResourceWarnings on Windows due to open pipes.
........
2010-11-05 17:19:38 +00:00
Brian Curtin d117b562ed Merged revisions 86185 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86185 | brian.curtin | 2010-11-04 22:58:52 -0500 (Thu, 04 Nov 2010) | 2 lines

  Add cleanups to stdout/stderr pipes to remove ResourceWarnings.
........
2010-11-05 04:09:09 +00:00
Antoine Pitrou dee0097fe4 Merged revisions 84997 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84997 | antoine.pitrou | 2010-09-24 20:57:01 +0200 (ven., 24 sept. 2010) | 3 lines

  Make _kill_process more robust under Windows too (see issue #8432)
........
2010-09-24 19:00:29 +00:00
Antoine Pitrou a6166dac94 Merged revisions 84909-84913 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84909 | antoine.pitrou | 2010-09-20 00:46:05 +0200 (lun., 20 sept. 2010) | 3 lines

  Try to fix test_subprocess on "x86 debian parallel 3.x" buildbot
........
  r84910 | antoine.pitrou | 2010-09-20 01:06:53 +0200 (lun., 20 sept. 2010) | 3 lines

  Try to make signal-sending tests in test_subprocess more robust on slow machines
........
  r84911 | antoine.pitrou | 2010-09-20 01:28:30 +0200 (lun., 20 sept. 2010) | 3 lines

  Make error more explicit in test_finalize_with_trace
........
  r84912 | antoine.pitrou | 2010-09-20 02:12:19 +0200 (lun., 20 sept. 2010) | 3 lines

  Try to fix buildbot failure (#9902)
........
  r84913 | antoine.pitrou | 2010-09-20 03:33:21 +0200 (lun., 20 sept. 2010) | 3 lines

  Try a more robust implementation of _kill_process
........
2010-09-20 11:20:44 +00:00
Antoine Pitrou b0b3bffe8b Merged revisions 84883 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84883 | antoine.pitrou | 2010-09-19 00:38:48 +0200 (dim., 19 sept. 2010) | 3 lines

  Issue #9895: speed up test_subprocess
........
2010-09-18 22:42:30 +00:00
Antoine Pitrou 767cbc41b4 Merged revisions 84878 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r84878 | antoine.pitrou | 2010-09-18 19:56:02 +0200 (sam., 18 sept. 2010) | 5 lines

  Issue #9894: Do not hardcode ENOENT in test_subprocess.

  (GNU/Hurd is not dead)
........
2010-09-18 18:15:33 +00:00
Brian Curtin e8c4920e4c Merged revisions 83983 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83983 | brian.curtin | 2010-08-13 15:42:57 -0500 (Fri, 13 Aug 2010) | 3 lines

  Fix #9588. Add sys.executable to two shell=True tests.
........
2010-08-13 21:01:52 +00:00
Tim Golden 8e4756c763 #2304: fix incorporating Eric Smith's .format suggestion and tested on Ubuntu as well as Windows 2010-08-12 11:00:35 +00:00
Benjamin Peterson 718f222372 revert 83832; unix test breakage 2010-08-08 19:14:28 +00:00
Tim Golden 6fe8c41e8f Issue #2304: Add additional quotes when using cmd shell on Windows. Original patch from Gabriel Genellina 2010-08-08 16:18:45 +00:00
Tim Golden 90374f5102 Issue #3210: Ensure stdio handles are closed if CreateProcess fails 2010-08-06 13:14:33 +00:00
Ronald Oussoren 21b44e0ea2 Merged revisions 83067 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83067 | ronald.oussoren | 2010-07-23 10:50:05 +0100 (Fri, 23 Jul 2010) | 8 lines

  Workaround for issue 4047: in some configurations of
  the Crash Reporter on OSX test_subprocess will trigger
  the reporter.

  This patch prints a warning when the Crash Reporter will
  get triggered intentionally, which should avoid confusing
  people.
........
2010-07-23 12:26:30 +00:00
Stefan Krah e9a6a7dd4c Issue #9265: Incorrect name passed as arg[0] when shell=True
and executable specified.
2010-07-19 14:41:08 +00:00
Jean-Paul Calderone b33f0c1ccd Revert r60115
This revision introduced quoting for strings containing | based
on a misunderstanding of the commonly used quoting rules used
on Windows.

| is interpreted by cmd.exe, not by the MS C runtime argv initializer.
It only needs to be quoted if it is part of an argument passed through
cmd.exe.

See issue1300, issue7839, and issue8972.
2010-06-18 20:00:17 +00:00
Florent Xicluna 3c919cf140 The SIGINT signal may happen earlier, during site.py initialization. 2010-03-23 19:19:16 +00:00
Florent Xicluna 446ff14827 The standard error should be empty when the signal is killed, except on SIGINT. 2010-03-23 15:05:30 +00:00
Florent Xicluna fc4d6d7763 Silence test_subprocess. 2010-03-23 14:36:45 +00:00
Florent Xicluna 637637021a Revert r78830: realpath() should really be applied to sys.executable. 2010-03-11 01:50:48 +00:00
Florent Xicluna e58d91c8f0 Fix the test_subprocess failure when sys.executable is meaningless: '' or a directory.
It does not fix #7774.
2010-03-11 00:56:59 +00:00
Florent Xicluna faf175385d Replace the stderr logging with assertNotEqual(returncode, 0). 2010-03-08 10:59:33 +00:00
Florent Xicluna 400efc2259 #2777: Try hard to make Win7 buildbot happy... 2010-03-07 17:12:23 +00:00
Florent Xicluna c083864fc8 Do not fail if returncode is 0 on send_signal/kill/terminate, for win32 platforms.
Do not hide the KeyboardInterrupt on POSIX platforms.
2010-03-07 15:27:39 +00:00
Florent Xicluna c02bbe328d #2777: Enable test_send_signal, test_terminate and test_kill on win32 platforms. 2010-03-07 12:21:36 +00:00
Florent Xicluna 632df993dc Skip test_send_signal, test_kill, test_terminate on win32 platforms, for 2.7a4 release. 2010-03-06 19:43:41 +00:00
Florent Xicluna aa90db9477 #2777: Apply same recipe on win32, i.e. do not inherit file handles. 2010-03-06 09:54:14 +00:00
Florent Xicluna af9a06a77f #2777: Apply same recipe for test_terminate and test_kill, i.e. close or redirect fds. 2010-03-06 00:16:57 +00:00
Florent Xicluna cecef392f1 #2777: Handle fds more carefully to try to fix some x86-Linux failures (namely, neal bot and twisted bot). 2010-03-05 19:31:21 +00:00
Florent Xicluna 7272acfabe These line should not be there. 2010-03-05 01:12:14 +00:00
Florent Xicluna d6935631da Let's use assertIsNone / assertIsNotNone. It's hype. 2010-03-05 01:05:55 +00:00
Florent Xicluna 80e0e2d2d8 Workaround #3137: Retry SIGINT if it is not received the first time.
test_send_signal should not hang anymore on various Linux distributions.
2010-03-05 00:47:40 +00:00
Florent Xicluna ab5e17f896 #2777: Enable test_send_signal, test_kill and test_terminate on all platforms. 2010-03-04 21:31:58 +00:00
Florent Xicluna bab22a7c6d Cleanup. 2010-03-04 19:40:48 +00:00
Gregory P. Smith c1baf4ac9e Fix the new test on windows (skip it, its posix only) 2010-03-01 02:53:24 +00:00
Gregory P. Smith cce211f88c Issue #1068268: The subprocess module now handles EINTR in internal
os.waitpid and os.read system calls where appropriate.
2010-03-01 00:05:08 +00:00
Florent Xicluna 78fd521f1a Fix an oversight in r78508: p.wait() should be compared to 0 2010-02-27 21:15:27 +00:00