Miss Islington (bot)
fae0512e58
[3.6] bpo-31178: Mock os.waitpid() in test_subprocess (GH-3896) ( #3897 )
...
Fix test_exception_errpipe_bad_data() and
test_exception_errpipe_normal() of test_subprocess: mock os.waitpid()
to avoid calling the real os.waitpid(0, 0) which is an unexpected
side effect of the test.
(cherry picked from commit 11045c9d8a
)
2017-10-05 07:10:59 -07:00
Miss Islington (bot)
f135f62cfd
[3.6] bpo-31471: Fix assertion failure in subprocess.Popen() on Windows, in case env has a bad keys() method. (GH-3580) ( #3584 )
...
(cherry picked from commit 0b3a87ef54
)
2017-09-14 22:56:31 +03:00
Gregory P. Smith
3bad1650a0
[3.6] bpo-31178: Avoid concatenating bytes with str in subprocess error (GH-3066) ( #3388 )
...
Avoid concatenating bytes with str in the typically rare subprocess error path (exec failed). Includes a mock based unittest to exercise the codepath.
(cherry picked from commit 3fc499bca1
)
2017-09-06 13:34:17 -07:00
Gregory P. Smith
1dba3789e3
bpo-22536 [3.6] Set filename in FileNotFoundError ( #3305 )
...
* [3.6] bpo-22536: Set the filename in FileNotFoundError. (GH-3194)
Have the subprocess module set the filename in the FileNotFoundError
exception raised on POSIX systems when the executable or cwd are missing.
(cherry picked from commit 8621bb5d93
)
* bpo-22536 [3.6] (GH-3202) skip non-windows tests.
2017-09-04 14:23:23 -07:00
Victor Stinner
e76cb43556
[3.6] bpo-30121: Fix debug assert in subprocess on Windows ( #1224 ) ( #3173 )
...
* bpo-30121: Fix debug assert in subprocess on Windows (#1224 )
* bpo-30121: Fix debug assert in subprocess on Windows
This is caused by closing HANDLEs using os.close which is for CRT file
descriptors and not for HANDLEs.
* bpo-30121: Suppress debug assertion in test_subprocess when ran directly
(cherry picked from commit 4d3851727f
)
* Add test_subprocess.test_nonexisting_with_pipes() (#3133 )
bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
(cherry picked from commit 9a83f651f3
)
2017-08-22 00:15:23 +02:00
Victor Stinner
f2d769d539
bpo-31067: test_subprocess calls reap_children() ( #2931 ) ( #3074 )
...
test_subprocess now also calls reap_children() in tearDown(), not
only on setUp().
(cherry picked from commit cc42c121eb
)
2017-08-11 17:14:37 +02:00
Victor Stinner
bc69d00288
bpo-31173: Rewrite WSTOPSIG test of test_subprocess ( #3055 ) ( #3070 )
...
The current test_child_terminated_in_stopped_state() function test
creates a child process which calls ptrace(PTRACE_TRACEME, 0, 0) and
then crash (SIGSEGV). The problem is that calling os.waitpid() in the
parent process is not enough to close the process: the child process
remains alive and so the unit test leaks a child process in a
strange state. Closing the child process requires non-trivial code,
maybe platform specific.
Remove the functional test and replaces it with an unit test which
mocks os.waitpid() using a new _testcapi.W_STOPCODE() function to
test the WIFSTOPPED() path.
(cherry picked from commit 7b7c6dcfff
)
2017-08-11 02:36:30 +02:00
Victor Stinner
9ad50d9459
bpo-30764: test_subprocess uses SuppressCrashReport ( #2405 ) ( #2410 )
...
bpo-30764, bpo-29335: test_child_terminated_in_stopped_state() of
test_subprocess now uses support.SuppressCrashReport() to prevent the
creation of a core dump on FreeBSD.
(cherry picked from commit cdee3f14f7
)
2017-06-27 00:00:33 +02:00
Serhiy Storchaka
e7135751b8
[3.6] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) ( #2360 )
...
Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24a5d
)
2017-06-23 20:17:38 +03:00
Serhiy Storchaka
e254617262
[3.6] bpo-30065: Fixed arguments validation in _posixsubprocess.fork_exec(). (GH-1110) ( #1186 )
...
(cherry picked from commit 66bffd1
)
2017-04-19 23:59:02 +03:00
Berker Peksag
6b81003bdb
bpo-28624: Add a test that checks that cwd parameter of Popen() accepts PathLike objects ( #157 ) ( #323 )
...
(cherry picked from commit d5c11f7ace
)
2017-02-26 20:38:31 +03:00
Gregory P. Smith
9358a6e62b
Skip the test requiring ctypes if ctypes is unavailable.
...
prevents http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/240/steps/test/logs/stdio
2017-01-22 22:19:51 -08:00
Gregory P. Smith
1fa08bcbbb
Skip the test requiring ctypes if ctypes is unavailable.
...
prevents http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/240/steps/test/logs/stdio
2017-01-22 22:19:38 -08:00
Gregory P. Smith
21a9b1dfc6
typo fix, extra '.' on MacOS :)
2017-01-22 20:55:02 -08:00
Gregory P. Smith
21d333b703
typo fix, extra '.' :)
2017-01-22 20:54:42 -08:00
Gregory P. Smith
78034c81fb
Issue #29335 : Fix subprocess.Popen.wait() when the child process has
...
exited to a stopped instead of terminated state (ex: when under ptrace).
2017-01-22 17:29:44 -08:00
Gregory P. Smith
50e16e33af
Issue #29335 : Fix subprocess.Popen.wait() when the child process has
...
exited to a stopped instead of terminated state (ex: when under ptrace).
2017-01-22 17:28:38 -08:00
Gregory P. Smith
f0e98c510d
Issue #20572 : The subprocess.Popen.wait method's undocumented endtime
...
parameter now raises a DeprecationWarning. It was deprecated in 3.4.
It was never documented prior to that.
2016-11-20 16:25:14 -08:00
Xavier de Gaye
38c8b7d292
Issue #28662 : Catch PermissionError in tests when spawning a non existent program
2016-11-14 17:14:42 +01:00
Martin Panter
0be894b2f6
Issue #27895 : Spelling fixes (Contributed by Ville Skyttä).
2016-09-07 12:03:06 +00:00
Steve Dower
050acaed99
Issue #6135 : Adds encoding and errors parameters to subprocess
2016-09-06 20:16:17 -07:00
Steve Dower
22d0698d3b
Adds test.support.PGO and skips tests that are not useful for PGO.
2016-09-06 19:38:15 -07:00
Raymond Hettinger
15f44ab043
Issue #27895 : Spelling fixes (Contributed by Ville Skyttä).
2016-08-30 10:47:49 -07:00
Martin Panter
8bde911115
Issue #27626 : Merge spelling fixes from 3.5
2016-07-28 01:30:58 +00:00
Martin Panter
eb9957065a
Issue #27626 : Spelling fixes in docs, comments and internal names
...
Based on patch by Ville Skyttä.
2016-07-28 01:11:04 +00:00
Xavier de Gaye
d141531eb5
Issue #27472 : Add test.support.unix_shell as the path to the default shell.
2016-07-22 12:15:29 +02:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
7a9ddd1d85
merge from 3.5. (moves the issue26372 tests to the proper class)
2016-06-05 02:58:38 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
2daf8e7f76
Move the BrokenPipeError tests to the POSIXProcessTestCase class
...
instead of the generic ProcessTestCase class as they are posix
specific.
2016-06-05 02:57:47 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
c55014f371
issue26372 - use os.devnull instead of /dev/null
2016-06-04 19:05:17 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
78b642c6b2
issue26372 - use os.devnull instead of /dev/null
2016-06-04 19:04:43 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
fcbf1ca4f9
merge from 3.5 - Fixes Issue #26373 : subprocess.Popen.communicate
...
now correctly ignores BrokenPipeError when the child process dies
before .communicate() is called in more (all?) circumstances.
2016-06-04 00:34:15 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
1ef8c7e886
Fixes Issue #26373 : subprocess.Popen.communicate now correctly ignores
...
BrokenPipeError when the child process dies before .communicate()
is called in more (all?) circumstances.
2016-06-04 00:22:17 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
b414906f93
issue27167: make the test not care about the exact signal name in the
...
error message as some numbers map to multiple names.
2016-06-03 06:19:35 +00:00
Gregory P. Smith ext:(%20%5BGoogle%20Inc.%5D)
d6da7604d3
Issue #27167 : Clarify the subprocess.CalledProcessError error message text
...
when the child process died due to a signal.
2016-06-03 06:14:06 +00:00
Victor Stinner
5a48e21ff1
subprocess now emits a ResourceWarning warning
...
Issue #26741 : subprocess.Popen destructor now emits a ResourceWarning warning
if the child process is still running.
2016-05-20 12:11:15 +02:00
Victor Stinner
7438c612ab
Use "with popen:" in test_subprocess
...
Issue #26741 .
2016-05-20 12:43:15 +02:00
Martin Panter
f94ec1bd83
Issue #22274 : Merge stderr=STDOUT fix from 3.5
2016-05-13 07:45:21 +00:00
Martin Panter
c76358924f
Issue #22274 : Redirect stderr=STDOUT when stdout not redirected, by Akira Li
2016-05-13 01:54:44 +00:00
Serhiy Storchaka
a6f26c1d34
Remove more unused imports in tests.
2016-04-25 00:05:30 +03:00
Serhiy Storchaka
e437a10d15
Issue #23277 : Remove unused imports in tests.
2016-04-24 21:41:02 +03:00
Martin Panter
528619b6c3
Issue #26782 : Add STARTUPINFO to subprocess.__all__ on Windows
2016-04-16 23:42:37 +00:00
Martin Panter
06172e7bd4
Issue #26782 : Acknowledge the incomplete status of __all__ in 3.5
...
Handle is probably meant to be excluded, and STARTUPINFO will be added to
__all__ in 3.6.
2016-04-16 23:38:25 +00:00
Martin Panter
23172bd47b
Issue #10838 : Run test__all__() everywhere, even if poll() is not available
2016-04-16 11:28:10 +00:00
Martin Panter
5cf791b035
Issue #25764 : Skip fork failure test when run as root
2015-12-11 05:40:14 +00:00
Martin Panter
c4b8979a2f
Issue #25764 : Merge OS X test skipping from 3.4 into 3.5
2015-12-05 12:41:29 +00:00
Martin Panter
f7fdbdab5b
Issue #25764 : Skip the test on OS X
...
The OS X buildbots were failing at the second setrlimit() call with EPERM, as
if they were trying to raise the hard limit. The call should be keeping the
hard limit the same and raising the soft limit back to its original value, so
I don't understand the failure.
2015-12-05 09:51:52 +00:00
Martin Panter
6a77c2d978
Issue #25764 : Merge subprocess fix from 3.4 into 3.5
2015-12-05 02:03:42 +00:00
Martin Panter
afdd51343c
Issue #25764 : Preserve subprocess fork exception when preexec_fn used
...
Also fix handling of failure to release the import lock.
2015-11-30 02:21:41 +00:00
Gregory P. Smith
d0a5b1c343
Fixes #23564 : Fix a partially broken sanity check in the _posixsubprocess
...
internals regarding how fds_to_pass were passed to the child. The bug
had no actual impact as subprocess.py already avoided it.
2015-11-15 21:15:26 -08:00
Berker Peksag
636b83fdc5
Issue #25249 : Remove unneeded mkstemp helper in test_subprocess
...
The helper was added in 76641824cf05 11 years ago and it can be
removed now since all supported Python versions have tempfile.mkstemp().
Patch by Nir Soffer.
2015-09-28 13:33:43 +03:00