Commit Graph

16081 Commits

Author SHA1 Message Date
Ezio Melotti c569cfebce Merged revisions 83103 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83103 | ezio.melotti | 2010-07-23 19:48:22 +0300 (Fri, 23 Jul 2010) | 1 line

  #9359: fix typo. Thanks to Piotr Kasprzyk for the patch.
........
2010-07-23 16:55:21 +00:00
Ronald Oussoren 3a04a25206 Merged revisions 83075 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83075 | ronald.oussoren | 2010-07-23 12:54:59 +0100 (Fri, 23 Jul 2010) | 5 lines

  Fix for issue 7895. Avoid crashing the interpreter
  when calling platform.mac_ver after calling os.fork by
  reading from a system configuration file instead of
  using OSX APIs.
........
2010-07-23 12:41:00 +00:00
Ronald Oussoren 21b44e0ea2 Merged revisions 83067 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83067 | ronald.oussoren | 2010-07-23 10:50:05 +0100 (Fri, 23 Jul 2010) | 8 lines

  Workaround for issue 4047: in some configurations of
  the Crash Reporter on OSX test_subprocess will trigger
  the reporter.

  This patch prints a warning when the Crash Reporter will
  get triggered intentionally, which should avoid confusing
  people.
........
2010-07-23 12:26:30 +00:00
Senthil Kumaran 880685f698 Reverting the checkin made in revision 82940, as it was adding new parameters to quote function in a bugfix release.
Discussed in issue1712522
2010-07-22 01:47:30 +00:00
Antoine Pitrou 7a7013e830 Merged revisions 83030 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r83030 | antoine.pitrou | 2010-07-21 18:41:31 +0200 (mer., 21 juil. 2010) | 5 lines

  Issue #5395: check that array.fromfile() re-raises an IOError instead of replacing it
  with EOFError.
  (this is only an added test, but 2.x will get a fix too)
........
2010-07-21 16:47:28 +00:00
Doug Hellmann f31db93fc1 Apply patch from Ray Allen for issue 9296 2010-07-21 12:36:33 +00:00
Stefan Krah 0b9201fa1c Sub-issue of #9036: Fix incorrect use of Py_CHARMASK. 2010-07-19 18:06:46 +00:00
Senthil Kumaran c7743aaac3 Fix Issue9301 - urllib.quote(None) to raise TypeError 2010-07-19 17:35:50 +00:00
Stefan Krah e9a6a7dd4c Issue #9265: Incorrect name passed as arg[0] when shell=True
and executable specified.
2010-07-19 14:41:08 +00:00
Senthil Kumaran 5dba6dfe6a Fixing Issue1712522 - urllib.quote to support Unicode. The default
encoding='utf-8' and errors='strict'.
2010-07-18 02:27:10 +00:00
R. David Murray 05b7631c17 Merged revisions 82922 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82922 | r.david.murray | 2010-07-16 21:19:57 -0400 (Fri, 16 Jul 2010) | 4 lines

  #1555570: correctly handle a \r\n that is split by the read buffer.

  Patch and test by Tony Nelson.
........
2010-07-17 01:35:16 +00:00
Alexander Belopolsky 84305c5153 Merged revisions 82915 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82915 | alexander.belopolsky | 2010-07-16 10:39:45 -0400 (Fri, 16 Jul 2010) | 1 line

  Corrected TUPLE<N> opcodes' docs.
........
2010-07-16 14:53:52 +00:00
Senthil Kumaran 0fdd385e2c Merged revisions 82895 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82895 | senthil.kumaran | 2010-07-15 01:40:52 +0530 (Thu, 15 Jul 2010) | 3 lines

  Fix a mistake, https proxy shoud be https://
........
2010-07-14 20:22:17 +00:00
Senthil Kumaran 836a2bba2f Merged revisions 82890 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82890 | senthil.kumaran | 2010-07-15 00:45:23 +0530 (Thu, 15 Jul 2010) | 3 lines

  Fix: Issue6853 - Get HTTPS system proxy in Windows.
........
2010-07-14 19:25:26 +00:00
Senthil Kumaran 9a5bc1d001 Merged revisions 82881 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82881 | senthil.kumaran | 2010-07-14 15:51:22 +0530 (Wed, 14 Jul 2010) | 3 lines

  Fix Issue5842 - Moving the tests out of urllib.parse module
........
2010-07-14 10:39:35 +00:00
Alexander Belopolsky eeb666ccf3 Merged revisions 82850 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82850 | alexander.belopolsky | 2010-07-13 10:50:16 -0400 (Tue, 13 Jul 2010) | 1 line

  Set sys.modules[name] to None instead of 0 to block module import.
........
2010-07-14 00:05:00 +00:00
Stefan Krah 182ae64235 Issue #9185: On Solaris and OpenBSD, posix_getcwd() could loop indefinitely
if the path length exceeded PATH_MAX.
2010-07-13 19:17:08 +00:00
Ezio Melotti c425f8fcb4 Merged revisions 82839 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82839 | ezio.melotti | 2010-07-12 22:49:41 +0300 (Mon, 12 Jul 2010) | 1 line

  #6026: skip test_get_file_list when zlib is not available.
........
2010-07-12 19:52:15 +00:00
Mark Dickinson 42add99f77 Merged revisions 82821 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82821 | mark.dickinson | 2010-07-11 19:53:06 +0100 (Sun, 11 Jul 2010) | 3 lines

  Issue #9137: Fix issue in MutableMapping.update, which incorrectly
  treated keyword arguments called 'self' or 'other' specially.
........
2010-07-11 19:17:28 +00:00
Ronald Oussoren 7595620105 Fix for issue #9164: with this patch sysconfig and distuls don't break
when duplicate '-arch foo' flags end up in CFLAGS (which may happen when
building a universal build using macports)
2010-07-11 08:52:52 +00:00
Senthil Kumaran 87ed31a414 Merged revisions 82780 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82780 | senthil.kumaran | 2010-07-11 08:42:43 +0530 (Sun, 11 Jul 2010) | 3 lines

  Stricter verification for file based url scheme and reliance on ftp protocol.
........
2010-07-11 03:18:51 +00:00
Benjamin Peterson 9d8c456696 Merged revisions 82777 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82777 | benjamin.peterson | 2010-07-10 10:14:45 -0500 (Sat, 10 Jul 2010) | 1 line

  ValueError is eventually what we want to move to, I suppose
........
2010-07-10 15:17:08 +00:00
R. David Murray 2ab02f0e16 Merged revisions 82766 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

Since 'purge' is an API change, modified it to be _purge for 2.x
and deleted the doc update.

........
  r82766 | r.david.murray | 2010-07-10 09:52:13 -0400 (Sat, 10 Jul 2010) | 5 lines

  Fix 'refleak' introduced by fnmatch cache purge tests.

  This introduces a 'purge' function for the fnmatch module analogous
  to the 'purge' function in the re module.
........
2010-07-10 14:06:51 +00:00
Michael Foord 94f071c715 Fix error message for comparing single line strings in unittest.TestCase.assertEqual.
Issue 9174
2010-07-10 13:51:42 +00:00
Benjamin Peterson 8e93f4e791 this makes checking for warnings less error prone 2010-07-09 18:15:28 +00:00
Benjamin Peterson 0b00b6b987 Merged revisions 82739,82741 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82739 | benjamin.peterson | 2010-07-09 08:28:42 -0500 (Fri, 09 Jul 2010) | 1 line

  allow more exceptions
........
  r82741 | benjamin.peterson | 2010-07-09 08:31:11 -0500 (Fri, 09 Jul 2010) | 1 line

  wrap
........
2010-07-09 13:33:03 +00:00
Benjamin Peterson 306d88fc76 Merged revisions 82735 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82735 | benjamin.peterson | 2010-07-09 08:20:40 -0500 (Fri, 09 Jul 2010) | 1 line

  OverflowError is fine
........
2010-07-09 13:21:35 +00:00
R. David Murray abd4553fd4 Merged revisions 82730 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

'merge' in the sense that this is the same fix by the same author.

........
  r82730 | r.david.murray | 2010-07-09 08:23:21 -0400 (Fri, 09 Jul 2010) | 4 lines

  7846: limit fnmatch pattern cache to _MAXCACHE=100 entries.

  Patch by Andrew Clegg.
........
2010-07-09 13:16:00 +00:00
Mark Dickinson 9b9e12530d Merged revisions 82654 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82654 | mark.dickinson | 2010-07-08 22:15:36 +0100 (Thu, 08 Jul 2010) | 3 lines

  Issue #9136: Profiling Decimal gave 'dictionary changed size during iteration'.
  Remove the use of locals() that caused this error.
........
2010-07-08 21:22:54 +00:00
Mark Dickinson e85aa739ab Merged revisions 82646,82649-82650 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82646 | mark.dickinson | 2010-07-08 18:23:40 +0100 (Thu, 08 Jul 2010) | 1 line

  In test_decimal, convert heuristic for skipping tests into an explicit skiplist.
........
  r82649 | mark.dickinson | 2010-07-08 20:03:34 +0100 (Thu, 08 Jul 2010) | 1 line

  Fix a performance issue in Decimal.pow.  Thanks Stefan Krah for finding this.
........
  r82650 | mark.dickinson | 2010-07-08 20:09:16 +0100 (Thu, 08 Jul 2010) | 1 line

  Fix misplaced exactness check that was causing unnecessary work in Decimal.__pow__.
........
2010-07-08 19:24:40 +00:00
Antoine Pitrou 22db73523c Merged revisions 82647 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82647 | antoine.pitrou | 2010-07-08 20:51:30 +0200 (jeu., 08 juil. 2010) | 3 lines

  Issue #8605: Skip test_gdb if Python is compiled with optimizations.
........
2010-07-08 18:54:04 +00:00
Benjamin Peterson 86ac22e338 Merged revisions 82637 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82637 | benjamin.peterson | 2010-07-07 17:45:06 -0500 (Wed, 07 Jul 2010) | 1 line

  ValueError in this case is also acceptable
........
2010-07-07 23:26:57 +00:00
Benjamin Peterson 489113fd5f Merged revisions 82628,82630 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82628 | benjamin.peterson | 2010-07-07 13:44:05 -0500 (Wed, 07 Jul 2010) | 1 line

  this needn't be in the loop
........
  r82630 | benjamin.peterson | 2010-07-07 13:54:59 -0500 (Wed, 07 Jul 2010) | 1 line

  don't ignore exceptions from PyObject_IsTrue
........
2010-07-07 19:03:36 +00:00
Benjamin Peterson ba303c82d1 these tests are the result of cpython's incorrect implementation 2010-07-07 15:51:17 +00:00
Benjamin Peterson bace6764fa be more generous to implementations that have implemented correctly 2010-07-05 17:13:21 +00:00
R. David Murray 3caf7b9c88 #9161: Fix regression in acceptance of unicode strings in add_option calls.
The original change in 2.6 was made during rc1 changeover, and did not
get ported to 2.7.  The original change may not even have been
intentional, but if so it doesn't seem to have caused any problems.
2010-07-05 16:06:05 +00:00
Benjamin Peterson 9d7003e353 Merged revisions 82542 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

................
  r82542 | benjamin.peterson | 2010-07-04 11:44:15 -0500 (Sun, 04 Jul 2010) | 17 lines

  Merged revisions 81478,82530-82531 via svnmerge from
  svn+ssh://pythondev@svn.python.org/sandbox/trunk/2to3/lib2to3

  ........
    r81478 | benjamin.peterson | 2010-05-22 13:47:39 -0500 (Sat, 22 May 2010) | 1 line

    ensure doctests have some future_features
  ........
    r82530 | benjamin.peterson | 2010-07-04 11:11:41 -0500 (Sun, 04 Jul 2010) | 1 line

    simplify ignore star imports from itertools #8892
  ........
    r82531 | benjamin.peterson | 2010-07-04 11:13:20 -0500 (Sun, 04 Jul 2010) | 1 line

    wrap with parenthesis not \
  ........
................
2010-07-04 16:53:16 +00:00
Mark Dickinson 75b44b3437 Issue #9130: Fix validation of relative imports in parser module. 2010-07-04 16:47:56 +00:00
Mark Dickinson a7ee59b3d3 Issue #9128: Validate class decorator syntax correctly in parser module. 2010-07-04 16:23:54 +00:00
Florent Xicluna 96c4df4532 Issue #9145: Fix a regression due to r79539 2010-07-04 14:24:40 +00:00
Benjamin Peterson e3c104554b prepare for 2.7.1 2010-07-03 14:51:25 +00:00
Benjamin Peterson c60082d283 update to 2.7 final 2010-07-03 13:56:13 +00:00
Benjamin Peterson 6728d14b28 update pydoc-topics 2010-07-03 13:53:45 +00:00
Benjamin Peterson 743242af90 add release date 2010-07-03 13:49:03 +00:00
Victor Stinner 15e5b1bf0b Issue #7673: Fix security vulnerability (CVE-2010-2089) in the audioop module,
ensure that the input string length is a multiple of the frame size
2010-07-03 13:36:19 +00:00
Jesse Noller 2f8c8f47c7 Submit patch for bug 9144; broken imports due to r81380 2010-07-03 12:26:02 +00:00
Benjamin Peterson 0df5a858e7 don't require the presence of __getformat__ or __setformat__; use requires_IEEE_754 globally 2010-07-02 23:05:27 +00:00
Benjamin Peterson c262a69f54 an AttributeError is perfectly acceptable here 2010-06-30 18:41:08 +00:00
Giampaolo Rodolà e00e2f0082 fix issue #6589: cleanup asyncore.socket_map if smtpd.SMTPServer constructor raises an exception 2010-06-30 17:38:28 +00:00
Benjamin Peterson 10947a6416 mark test depending on ref counting 2010-06-30 17:11:08 +00:00
Mark Dickinson 070f0abc19 Issue #9125: Update parser module for "except ... as ..." syntax. 2010-06-30 16:27:57 +00:00
Mark Dickinson 858624944c Spelling. 2010-06-29 07:37:25 +00:00
Benjamin Peterson d6a8e6d234 fix skipping condition 2010-06-28 15:41:06 +00:00
Benjamin Peterson 8eeb1dcbbc testcapi tests are definitely cpython only 2010-06-28 15:36:40 +00:00
Senthil Kumaran 5871a8d744 Fix Issue8653 - Docstring for urlunsplit function. 2010-06-28 13:56:46 +00:00
Benjamin Peterson a70e91c284 mark tracking tests as implementation details 2010-06-27 22:40:26 +00:00
Ronald Oussoren b96fbb8d00 Fix for Issue8883: without this patch test_urllib will fail
when there is a bare IP address in the "Bypass proxy settings
for these Hosts & Domains" list on MacOSX.
2010-06-27 13:59:39 +00:00
Ronald Oussoren 76002c8f1d The uuid library on OSX 10.5 seems to contain the same bug as the one
on OSX 10.6, therefore don't use it there either.

This fixes issue8621.
2010-06-27 12:43:47 +00:00
Ronald Oussoren cd17213e8e Two small fixes for the support for SDKs on MacOSX:
1) The code that checks if an path should be located in the SDK
   explicitly excludes /usr/local. This fixes issue9046

2) The SDK variant for filtering "db_dirs_to_check" in setup.py
   was not doing anything because of a missing assignment.
2010-06-27 12:36:16 +00:00
Georg Brandl ad72bcc864 Untabify. 2010-06-27 11:24:15 +00:00
R. David Murray 62a14db9f4 #9085: email versions have gotten out of sync, 2.7 is actually 4.0.3.
In 2.5 the email version was bumped to 4.0.2 just before release but
after the maintenance branch was set up.  The bump was not backported
to trunk, and 2.6 went out the door with a version number of 4.0.1.
I bumped this to 4.0.2 because of a behavior change, but that makes
it look the same as 2.5.  So bump it again to 4.0.3.
2010-06-26 18:39:50 +00:00
R. David Murray 04a3439ba6 Fix indentation in recently added test. 2010-06-26 03:27:32 +00:00
R. David Murray 32e0681156 #4640: add a test to optparse that proves issue is invalid. 2010-06-26 00:06:44 +00:00
Benjamin Peterson cf3e20c8e8 mark implementation detail as such 2010-06-25 22:58:47 +00:00
Benjamin Peterson 0badae4748 this must be a typo 2010-06-25 21:19:04 +00:00
Benjamin Peterson 4b26acbf03 mark implementation detail as such 2010-06-25 20:34:01 +00:00
Benjamin Peterson 947ce58a90 prevent assignment to set literals 2010-06-24 00:12:40 +00:00
Benjamin Peterson f6d31cb8b5 cpython only gc tests 2010-06-23 20:29:26 +00:00
Benjamin Peterson 7f8ede4db9 mark ref counting as impl detail 2010-06-22 20:32:02 +00:00
Benjamin Peterson 694781b1d3 must force gc here 2010-06-22 20:26:20 +00:00
Benjamin Peterson bde67df0cd keep UserDict an old-style class
Be generous in abc.py to allow this.
2010-06-22 18:09:02 +00:00
Ronald Oussoren 934f4e1f39 Fix for issue8446:
* Don't import 'ic' in webbrowser, that module is no longer used
* Remove 'MacOS' from the list of modules that should emit a Py3kWarning on import.
  This is needed because one of the earlier tests triggers and import of this
  extension, and that causes a failure in test_py3kwarn (running test_py3kwarn
  separately worked fine)

With these changes 'make tests' no longer says that test_py3kwarn fails.
2010-06-22 09:18:28 +00:00
Benjamin Peterson bfcedf4cb7 bump verson to 2.7rc2 2010-06-21 15:57:57 +00:00
Benjamin Peterson bb937092f7 update pydoc-topics 2010-06-21 15:56:45 +00:00
Benjamin Peterson afa1b30969 fix finding visual studio 2008 on 64 bit #8854 2010-06-21 15:27:46 +00:00
Thomas Heller a45e6d5791 Add tests for problems reported in issue 8959. 2010-06-21 15:01:18 +00:00
Thomas Heller f180099ec6 Fix #8959 by reverting revision 80761. 2010-06-21 14:00:24 +00:00
Mark Dickinson 801923681c Merge test_strtod and test_float string-to-float conversion tests. 2010-06-20 18:50:19 +00:00
Jean-Paul Calderone b33f0c1ccd Revert r60115
This revision introduced quoting for strings containing | based
on a misunderstanding of the commonly used quoting rules used
on Windows.

| is interpreted by cmd.exe, not by the MS C runtime argv initializer.
It only needs to be quoted if it is part of an argument passed through
cmd.exe.

See issue1300, issue7839, and issue8972.
2010-06-18 20:00:17 +00:00
Florent Xicluna a37b7af4d7 Add few words about test.test_genericpath.CommonTest 2010-06-17 20:30:56 +00:00
R. David Murray df1cf301c2 #8720: fix inspect regression by teaching getsourcefile about linecache.
The fix for issue 4050 caused a regression:  before that fix, source
lines in the linecache would eventually be found by inspect.  After the
fix inspect reports an error earlier, and the source isn't found.
The fix for the fix is to have getsourcefile look in the linecache for
the file and return the psuedo-filename if the source is there, just as
it already returns it if there is a PEP 302 loader.
2010-06-17 01:36:52 +00:00
Mark Dickinson e979ec8fbf Issue #8986: erfc was raising OverflowError on Linux for arguments in
the (approximate) range (-27.3, 30.0), as a result of an escaped errno
value.
2010-06-13 10:50:29 +00:00
Vinay Sajip 936efc791a Issue #8924: logging: Improved error handling for Unicode in exception text. 2010-06-11 22:56:50 +00:00
Antoine Pitrou cca3a3f396 Issue #8941: decoding big endian UTF-32 data in UCS-2 builds could crash
the interpreter with characters outside the Basic Multilingual Plane
(higher than 0x10000).
2010-06-11 21:42:26 +00:00
Mark Dickinson 40228912c8 Fix possible undefined behaviour from signed overflow in struct module.
Backport of revisions 81897, 81898 and 81902 from py3k.
2010-06-11 20:27:05 +00:00
Michael Foord 33958b87f2 Fix issue with nested test suites debug method and module setups. (unittest) 2010-06-10 20:40:21 +00:00
Michael Foord ae1bb9a00c Typo correction. 2010-06-09 12:29:56 +00:00
Michael Foord 0fedb28951 Issue 8948. cleanup functions are not run by unittest.TestCase.debug(), plus class and module teardowns are not run by unittest.TestSuite.debug(). 2010-06-08 22:44:52 +00:00
Benjamin Peterson eabdeba25e use unicode literals 2010-06-07 22:33:09 +00:00
Benjamin Peterson 13e934acc0 correctly overflow when indexes are too large 2010-06-07 22:23:23 +00:00
Ezio Melotti 0b41707dde Silence deprecation warning in test___all__ caused by an import bsddb. 2010-06-07 22:00:18 +00:00
Benjamin Peterson 0229e8495f update pydoc-topics 2010-06-06 00:49:27 +00:00
Benjamin Peterson 77d534e59d bump version to 2.7 rc1 2010-06-06 00:22:09 +00:00
Michael Foord c532c57d44 Code formatting change. 2010-06-05 23:58:40 +00:00
Ezio Melotti 62c3c79426 Replace deprecated fail* methods with the equivalent assert* ones. 2010-06-05 22:28:10 +00:00
Michael Foord db919f0188 Tests for issue 8302, skipped test in a setUpClass or a setUpModule are reported as skips rather than errors. 2010-06-05 20:59:00 +00:00
Michael Foord c1d7c5b7fa Tests for unittest.TestCase.maxDiff. 2010-06-05 20:33:43 +00:00
Michael Foord 20e287caed Issue 8302. SkipTest exception is setUpClass or setUpModule is now reported as a skip rather than an error. 2010-06-05 19:38:42 +00:00
Ezio Melotti ab2eb0ee84 Add a NEWS entry for r81758 and clarify a comment. 2010-06-05 19:21:32 +00:00
Ezio Melotti e57e50c8e7 Update PyUnicode_DecodeUTF8 from RFC 2279 to RFC 3629.
1) #8271: when a byte sequence is invalid, only the start byte and all the
   valid continuation bytes are now replaced by U+FFFD, instead of replacing
   the number of bytes specified by the start byte.
   See http://www.unicode.org/versions/Unicode5.2.0/ch03.pdf (pages 94-95);
2) 5- and 6-bytes-long UTF-8 sequences are now considered invalid (no changes
   in behavior);
3) Add code and tests to reject surrogates (U+D800-U+DFFF) as defined in
   RFC 3629, but leave it commented out since it's not backward compatible;
4) Change the error messages "unexpected code byte" to "invalid start byte"
   and "invalid data" to "invalid continuation byte";
5) Add an extensive set of tests in test_unicode;
6) Fix test_codeccallbacks because it was failing after this change.
2010-06-05 17:51:07 +00:00