Commit Graph

11241 Commits

Author SHA1 Message Date
Jeremy Hylton 3e18615496 Fix test: readline() now returns bytes 2007-08-04 03:46:11 +00:00
Jeremy Hylton 66dc8c59be Fix tests that tried to sneak strings through httplib.
The httplib interface returns bytes for now.
2007-08-04 03:42:26 +00:00
Jeremy Hylton 04319c78d6 Make sure LineAndFileWrapper gets bytes() as its first argument.
This change fixes a test in test_urllib.
2007-08-04 03:41:19 +00:00
Jeremy Hylton 4e7855d7fd Use BytesIO instead of StringIO. 2007-08-04 03:34:03 +00:00
Jeremy Hylton 0ee5eeb8ff Fix several more paths from the SSL code.
In particular, watch out for comparing b"" to "".  They're not equal,
but you can start at the code asking whether buf == "" for a long time
before realizing that it will never be True.
2007-08-04 03:25:17 +00:00
Jeremy Hylton 97043c3c02 HTTPResponse should not inherit from io.IOBase.
I'm not sure why I thought it should originally, but it introduces an
__del__() method on the response which cause the close() to be called
too soon using the HTTP compat class.

Also, remove some stale comments.  The HTTPResponse calls makefile()
immediately, so there is no risk of it closing the socket.
2007-08-04 02:34:24 +00:00
Guido van Rossum 4a7fd90d9c Fix failure do to outlawing complex floordiv/mod. 2007-08-03 21:15:23 +00:00
Jeremy Hylton ec0c508b0a Fix an absurdly invasive test.
Checks that an io object somewhere in the stack of wrappers is
actually closed.  --This line, and those below, will be ignored--

M    test_urllib2net.py
2007-08-03 21:03:02 +00:00
Jeremy Hylton 8fff7924a4 Fix tests to use bytes() where the actual sockets return bytes().
Use io.BytesIO() instead of StringIO.StringIO().  FakeSocket still
accepts regular strings and coverts them to bytes internally.
2007-08-03 20:56:14 +00:00
Guido van Rossum 9648d62fd5 Make test_complex pass again now that floordiv and mod are illegal. 2007-08-03 20:40:44 +00:00
Jeremy Hylton 5accbdb812 Make sure socket.close() doesn't interfere with socket.makefile().
If a makefile()-generated object is open and its parent socket is
closed, the parent socket should remain open until the child is
closed, too.  The code to support this is moderately complex and
requires one extra slots in the socket object.

This change fixes httplib so that several urllib2net test cases pass
again.

Add SocketCloser class to socket.py, which encapsulates the
refcounting logic for sockets after makefile() has been called.

Move SocketIO class from io module to socket module.  It's only use is
to implement the raw I/O methods on top of a socket to support
makefile().

Add unittests to test_socket to cover various patterns of close and
makefile.
2007-08-03 20:40:09 +00:00
Jeremy Hylton d2ef864f81 Treat HTTP status line as ISO-8859-1 as in httplib module. 2007-08-03 20:32:27 +00:00
Jeremy Hylton cf2f41919c Hack: Fix some test_urllib2.net tests by getting them access to the
raw socket so they can check the timeout value.  Should change the
code under test to expose the timeout in a more direct way.
2007-08-03 20:31:38 +00:00
Jeremy Hylton fb35f65e8b A few local changes for consistency of string literals. 2007-08-03 20:30:33 +00:00
Guido van Rossum c0f2d2d345 SF patch# 1762940 by Joe Gregorio.
Fix test_cookielib and test_urllib2.
(The changes to urllib make urllib.quote() work correctly for Unicode
strings; but they don't fix test_urllib.)
2007-08-03 19:19:24 +00:00
Guido van Rossum 15863ea07a SF patch# 1764815 by Paul Colomiets.
Fix for test_socketserver.
Use io.BytesIO instead of io.StringIO, and adjust tests.
2007-08-03 19:03:39 +00:00
Guido van Rossum ad8d30092c SF patch# 1766592 by Paul Colomiets.
Fix test_zipimport.
2007-08-03 18:40:49 +00:00
Jeremy Hylton e5d0e8431f Make consistent use of "" for string literals in new classes. 2007-08-03 13:45:24 +00:00
Jeremy Hylton 811fc14935 Fix status line parsing for http response. 2007-08-03 13:30:02 +00:00
Guido van Rossum 4737482fad Add a default __prepare__() method to 'type', so it can be called
using super().  (See recent conversation on python-3000 with Talin
and Phillip Eby about PEP 3115 chaining rules.)
2007-08-02 16:48:17 +00:00
Guido van Rossum a6bcefca81 When testing all stdlib modules, ignore test_pep263.py which is encoded
in KOI8-R.
2007-08-01 18:06:13 +00:00
Guido van Rossum 70d2b890de Tests for @abstractproperty by Jeffrey Yasskin.
(The previous changes to abc.py were also by him).
Put back a comment about using super() for properties
(I didn't realize this worked).
2007-08-01 17:52:23 +00:00
Guido van Rossum b31339fa02 Add @abstractproperty. 2007-08-01 17:32:28 +00:00
Walter Dörwald e78178e2c0 Bytes (which are the input for decoding) are mutable now. If a decoding
error callback changes the bytes object in the exception the decoder might
use memory that's no longer in use. Change unicode_decode_call_errorhandler()
so that it fetches the adresses of the bytes array (start and end) from the
exception object and passes them back to the caller.
2007-07-30 13:31:40 +00:00
Brett Cannon 2dbde5ea44 In cases where dealing with base64, do the conversion but then get the ASCII
string representation for use in the XML.

Also strip out some unneeded encoding/decoding steps.
2007-07-30 03:50:35 +00:00
Brett Cannon 96d7e8369c Don't try to use a bytes sequence for file paths. Also force equivalency tests
to be between str8 and str.
2007-07-30 01:34:07 +00:00
Martin v. Löwis 447d33ead6 Implement PEP 3120. 2007-07-29 18:10:01 +00:00
Brett Cannon 5de17db361 Testing against a different default encoding is meaningless as the default
encoding can only be UTF-8 now.
2007-07-29 02:57:38 +00:00
Brett Cannon d38d078566 Expat parser no longer has a returns_unicode attribute since everything is
Unicode now.
2007-07-29 02:56:27 +00:00
Martin v. Löwis 48f4cf9b94 Use BytesIO instead of cStringIO.StringIO. 2007-07-28 17:58:14 +00:00
Martin v. Löwis c582bfca26 Fix quopri to operate consistently on bytes. 2007-07-28 17:52:25 +00:00
Martin v. Löwis f30bb0eba2 Patch #1762412: Fix test case for struni branch. 2007-07-28 11:40:46 +00:00
Guido van Rossum 3e1f85eb5d Fix the minidom test.
In order to do this, I added an optional encoding argument to io.StringIO.
The toprettyxml() function returns bytes when you specify an encoding now.
2007-07-27 18:03:11 +00:00
Guido van Rossum 3992db81b6 SF patch# 1759922 by Alexandre Vassalotti.
Fix one of the two failing tests for minidom.
2007-07-27 17:26:00 +00:00
Guido van Rossum 624ab7c28a Make test_sgmllib pass on OSX. Hopefully it still passes everywhere else too. 2007-07-27 17:12:11 +00:00
Guido van Rossum ea8344797e SF patch# 1757839 by Alexandre Vassalotti (part 2).
Change a bunch of .assert_(X == Y) to .assertEqual(X, Y).
2007-07-27 05:17:50 +00:00
Guido van Rossum f7a94e4b44 SF patch# 1761465 by Jeffrey Yasskin.
Fix test_aepack and test_applesingle.
2007-07-27 04:41:00 +00:00
Guido van Rossum 67feb09d06 Delete redundant read() and close() methods from SocketIO class. 2007-07-27 04:38:24 +00:00
Brett Cannon 1eb79cfd6d Move xdrlib over to the bytes type. 2007-07-26 03:19:46 +00:00
Brett Cannon d24fffe7c6 Move shelve over to BytesIO as pickle.(Pickler | Unpickler) expect binary
files, not text files.

test_shelve still fails thanks to bsddb not having been fixed.
2007-07-26 03:07:02 +00:00
Guido van Rossum 51a883bf87 Make test_wave.py pass.
I have no illusion that this fixes all issues with this module.
2007-07-23 21:28:30 +00:00
Guido van Rossum 005ebb1f7c Tweaks to make the codecmaps tests pass again.
(To run these, you need to pass -uurlfetch to regrtest.py or runtests.sh.)
2007-07-23 18:06:59 +00:00
Guido van Rossum 4ca9471831 SF patch# 1759016 by Joe Gregorio, who writes:
1. Removed "returns_unicode" attribute, associated code
   in the module to support that attribute, and all tests
   associated with it.
2. Parsed data is now returned as unicode strings.
3. Changed input tests to use io.BytesIO instead
   of StringIO, to reflect the byte processing
   nature of expat.
2007-07-23 17:42:32 +00:00
Guido van Rossum f520c05456 Don't use cwnon-ASCII characters in the source; use \ooo escapes.
(This doesn't fix test_cookielib, just removes the SyntaxError.)
2007-07-23 03:46:37 +00:00
Guido van Rossum accecdf969 Don't use a sleep to wait for the server to be ready; this caused
problems on my OSX laptop.  use a condition variable instead.
2007-07-23 01:49:28 +00:00
Collin Winter d745c436fb Fix test_largefile by changing some string literals to byte literals. 2007-07-23 00:51:28 +00:00
Collin Winter f86f285bdd Fix test_poplib failures. 2007-07-23 00:24:10 +00:00
Guido van Rossum 33e7a8e813 Make close() (all versions) ignore IOError from flush().
This makes test_resource.py pass, and I think it's the right thing
to do: if you're closing a file after encountering an I/O error
there's nothing you can do about it.  If you want the error, you
can call flush() yourself.
2007-07-22 20:38:07 +00:00
Guido van Rossum ca73d496ec Remove this test; it checked for a single old bug and I don't think that
its failure means much, now that the handling of unicode and bytes has
changed so much.
2007-07-22 20:13:35 +00:00
Guido van Rossum f8761c781b Make test_compile not fail.
I *think* it's okay no longer to require that compiling a Unicode
string with a coding declaration fails; it seems appropriate to
just ignore it.
2007-07-22 20:01:13 +00:00