The webbrowser module now uses subprocess's start_new_session=True rather
than a potentially risky preexec_fn=os.setsid call.
This commit is contained in:
parent
2ced87f3e6
commit
feac3980ce
|
@ -159,10 +159,8 @@ class BackgroundBrowser(GenericBrowser):
|
|||
if sys.platform[:3] == 'win':
|
||||
p = subprocess.Popen(cmdline)
|
||||
else:
|
||||
setsid = getattr(os, 'setsid', None)
|
||||
if not setsid:
|
||||
setsid = getattr(os, 'setpgrp', None)
|
||||
p = subprocess.Popen(cmdline, close_fds=True, preexec_fn=setsid)
|
||||
p = subprocess.Popen(cmdline, close_fds=True,
|
||||
start_new_session=True)
|
||||
return (p.poll() is None)
|
||||
except OSError:
|
||||
return False
|
||||
|
@ -321,11 +319,6 @@ class Konqueror(BaseBrowser):
|
|||
action = "openURL"
|
||||
|
||||
devnull = subprocess.DEVNULL
|
||||
# if possible, put browser in separate process group, so
|
||||
# keyboard interrupts don't affect browser as well as Python
|
||||
setsid = getattr(os, 'setsid', None)
|
||||
if not setsid:
|
||||
setsid = getattr(os, 'setpgrp', None)
|
||||
|
||||
try:
|
||||
p = subprocess.Popen(["kfmclient", action, url],
|
||||
|
@ -343,7 +336,7 @@ class Konqueror(BaseBrowser):
|
|||
p = subprocess.Popen(["konqueror", "--silent", url],
|
||||
close_fds=True, stdin=devnull,
|
||||
stdout=devnull, stderr=devnull,
|
||||
preexec_fn=setsid)
|
||||
start_new_session=True)
|
||||
except OSError:
|
||||
# fall through to next variant
|
||||
pass
|
||||
|
@ -356,7 +349,7 @@ class Konqueror(BaseBrowser):
|
|||
p = subprocess.Popen(["kfm", "-d", url],
|
||||
close_fds=True, stdin=devnull,
|
||||
stdout=devnull, stderr=devnull,
|
||||
preexec_fn=setsid)
|
||||
start_new_session=True)
|
||||
except OSError:
|
||||
return False
|
||||
else:
|
||||
|
|
|
@ -27,6 +27,9 @@ Core and Builtins
|
|||
Library
|
||||
-------
|
||||
|
||||
- The webbrowser module now uses subprocess's start_new_session=True rather
|
||||
than a potentially risky preexec_fn=os.setsid call.
|
||||
|
||||
- Issue #22236: Fixed Tkinter images copying operations in NoDefaultRoot mode.
|
||||
|
||||
- Issue #22191: Fix warnings.__all__.
|
||||
|
|
Loading…
Reference in New Issue