bpo-33549: Remove shim and deprecation warning to access DocumentLS.async. (GH-6924)

`obj.async` is now a syntax error, so the warning/shim is
quasi-unnecessary.
This commit is contained in:
Matthias Bussonnier 2018-05-17 01:16:12 -07:00 committed by Serhiy Storchaka
parent d5f1442608
commit f90f5d5c1d
2 changed files with 0 additions and 32 deletions

View File

@ -60,17 +60,7 @@ class MinidomTest(unittest.TestCase):
def testDocumentAsyncAttr(self): def testDocumentAsyncAttr(self):
doc = Document() doc = Document()
self.assertFalse(doc.async_) self.assertFalse(doc.async_)
with self.assertWarns(DeprecationWarning):
self.assertFalse(getattr(doc, 'async', True))
with self.assertWarns(DeprecationWarning):
setattr(doc, 'async', True)
with self.assertWarns(DeprecationWarning):
self.assertTrue(getattr(doc, 'async', False))
self.assertTrue(doc.async_)
self.assertFalse(Document.async_) self.assertFalse(Document.async_)
with self.assertWarns(DeprecationWarning):
self.assertFalse(getattr(Document, 'async', True))
def testParseFromBinaryFile(self): def testParseFromBinaryFile(self):
with open(tstfile, 'rb') as file: with open(tstfile, 'rb') as file:

View File

@ -332,29 +332,10 @@ class DOMBuilderFilter:
del NodeFilter del NodeFilter
class _AsyncDeprecatedProperty:
def warn(self, cls):
clsname = cls.__name__
warnings.warn(
"{cls}.async is deprecated; use {cls}.async_".format(cls=clsname),
DeprecationWarning)
def __get__(self, instance, cls):
self.warn(cls)
if instance is not None:
return instance.async_
return False
def __set__(self, instance, value):
self.warn(type(instance))
setattr(instance, 'async_', value)
class DocumentLS: class DocumentLS:
"""Mixin to create documents that conform to the load/save spec.""" """Mixin to create documents that conform to the load/save spec."""
async_ = False async_ = False
locals()['async'] = _AsyncDeprecatedProperty() # Avoid DeprecationWarning
def _get_async(self): def _get_async(self):
return False return False
@ -384,9 +365,6 @@ class DocumentLS:
return snode.toxml() return snode.toxml()
del _AsyncDeprecatedProperty
class DOMImplementationLS: class DOMImplementationLS:
MODE_SYNCHRONOUS = 1 MODE_SYNCHRONOUS = 1
MODE_ASYNCHRONOUS = 2 MODE_ASYNCHRONOUS = 2