Closes #18941: Merged fix from 3.3.

This commit is contained in:
Vinay Sajip 2013-09-06 10:26:48 +01:00
commit f7b436ce8d
2 changed files with 7 additions and 4 deletions

View File

@ -1,4 +1,4 @@
# Copyright 2001-2012 by Vinay Sajip. All Rights Reserved.
# Copyright 2001-2013 by Vinay Sajip. All Rights Reserved.
#
# Permission to use, copy, modify, and distribute this software and its
# documentation for any purpose and without fee is hereby granted,
@ -18,7 +18,7 @@
Logging package for Python. Based on PEP 282 and comments thereto in
comp.lang.python.
Copyright (C) 2001-2012 Vinay Sajip. All Rights Reserved.
Copyright (C) 2001-2013 Vinay Sajip. All Rights Reserved.
To use, simply 'import logging' and log away!
"""
@ -971,6 +971,7 @@ class FileHandler(StreamHandler):
self.baseFilename = os.path.abspath(filename)
self.mode = mode
self.encoding = encoding
self.delay = delay
if delay:
#We don't open the stream, but we still need to call the
#Handler constructor to set level, formatter, lock etc.

View File

@ -172,7 +172,8 @@ class RotatingFileHandler(BaseRotatingHandler):
if os.path.exists(dfn):
os.remove(dfn)
self.rotate(self.baseFilename, dfn)
self.stream = self._open()
if not self.delay:
self.stream = self._open()
def shouldRollover(self, record):
"""
@ -394,7 +395,8 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
if self.backupCount > 0:
for s in self.getFilesToDelete():
os.remove(s)
self.stream = self._open()
if not self.delay:
self.stream = self._open()
newRolloverAt = self.computeRollover(currentTime)
while newRolloverAt <= currentTime:
newRolloverAt = newRolloverAt + self.interval