Issue #18394: Explicitly close the file object cgi.FieldStorage

caches.

Eliminates the ResoureWarning raised during testing.

Patch also independently written by Vajrasky Kok.
This commit is contained in:
Brett Cannon 2013-08-23 15:15:48 -04:00
parent 9c7eb55570
commit f79126f373
2 changed files with 8 additions and 0 deletions

View File

@ -552,6 +552,12 @@ class FieldStorage:
else:
self.read_single()
def __del__(self):
try:
self.file.close()
except AttributeError:
pass
def __repr__(self):
"""Return a printable representation."""
return "FieldStorage(%r, %r, %r)" % (

View File

@ -38,6 +38,8 @@ Core and Builtins
Library
-------
- Issue #18394: Close cgi.FieldStorage's optional file.
- Issue #17702: On error, os.environb now removes suppress the except context
when raising a new KeyError with the original key.