traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-38478: Correctly handle keyword argument with same name as positional-only parameter (GH-16800)

This commit is contained in:
Pablo Galindo 2019-10-15 12:40:02 +01:00 committed by GitHub
parent eb1dda2b56
commit f3ef06a7cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/inspect.py
View File

@ -2960,7 +2960,7 @@ class Signature:
arguments[param.name] = tuple(values) arguments[param.name] = tuple(values)
break break
if param.name in kwargs: if param.name in kwargs and param.kind != _POSITIONAL_ONLY:
raise TypeError( raise TypeError(
'multiple values for argument {arg!r}'.format( 'multiple values for argument {arg!r}'.format(
arg=param.name)) from None arg=param.name)) from None

10
Lib/test/test_inspect.py
View File

@ -3573,6 +3573,16 @@ class TestSignatureBind(unittest.TestCase):
iterator = iter(range(5)) iterator = iter(range(5))
self.assertEqual(self.call(setcomp_func, iterator), {0, 1, 4, 9, 16}) self.assertEqual(self.call(setcomp_func, iterator), {0, 1, 4, 9, 16})
def test_signature_bind_posonly_kwargs(self):
def foo(bar, /, **kwargs):
return bar, kwargs.get(bar)
sig = inspect.signature(foo)
result = sig.bind("pos-only", bar="keyword")
self.assertEqual(result.kwargs, {"bar": "keyword"})
self.assertIn(("bar", "pos-only"), result.arguments.items())
class TestBoundArguments(unittest.TestCase): class TestBoundArguments(unittest.TestCase):
def test_signature_bound_arguments_unhashable(self): def test_signature_bound_arguments_unhashable(self):

3
Misc/NEWS.d/next/Library/2019-10-15-11-37-57.bpo-38478.A87OPO.rst Normal file
View File

@ -0,0 +1,3 @@
Fixed a bug in :meth:`inspect.signature.bind` that was causing it to fail
when handling a keyword argument with same name as positional-only parameter.
Patch by Pablo Galindo.