traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix test_iterlen by returning the iterator of dict views. Problem is that 

iteritems and itervalues' previous object were both an iterator *and* and
iterable.  The tests expected an iterator but were given an iterable.

Should the 2to3 conversion for iter(values|items|keys) change the code to
``iter(dict.keys())`` to be more compatible?
This commit is contained in:
Brett Cannon 2007-02-22 04:45:13 +00:00
parent 861fd6fdb9
commit eb6b0eec29
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BROKEN
View File

@ -1,2 +1,2 @@
test_bsddb test_bsddb3 test_compile test_dumbdbm test_bsddb test_bsddb3 test_compile test_dumbdbm
test_importhooks test_iter test_iterlen test_importhooks test_iter

4
Lib/test/test_iterlen.py
View File

@ -139,14 +139,14 @@ class TestDictItems(TestTemporarilyImmutable):
def setUp(self): def setUp(self):
d = dict.fromkeys(xrange(n)) d = dict.fromkeys(xrange(n))
self.it = d.items() self.it = iter(d.items())
self.mutate = d.popitem self.mutate = d.popitem
class TestDictValues(TestTemporarilyImmutable): class TestDictValues(TestTemporarilyImmutable):
def setUp(self): def setUp(self):
d = dict.fromkeys(xrange(n)) d = dict.fromkeys(xrange(n))
self.it = d.values() self.it = iter(d.values())
self.mutate = d.popitem self.mutate = d.popitem
class TestSet(TestTemporarilyImmutable): class TestSet(TestTemporarilyImmutable):