traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove a redundant string length check and variable assignment. 

Found with Clang's static analyzer.
This commit is contained in:
Brett Cannon 2010-05-04 00:30:17 +00:00
parent 7983284472
commit e894e93f4c
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Modules/cPickle.c
View File

@ -864,7 +864,7 @@ whichmodule(PyObject *global, PyObject *global_name)
*global_name_attr = 0, *name = 0;
module = PyObject_GetAttrString(global, "__module__");
if (module)
if (module)
return module;
if (PyErr_ExceptionMatches(PyExc_AttributeError))
PyErr_Clear();
@ -903,7 +903,6 @@ whichmodule(PyObject *global, PyObject *global_name)
like this rule. jlf
*/
if (!j) {
j=1;
name=__main___str;
}
@ -1235,9 +1234,6 @@ save_string(Picklerobject *self, PyObject *args, int doput)
int i;
char c_str[5];
if ((size = PyString_Size(args)) < 0)
return -1;
if (size < 256) {
c_str[0] = SHORT_BINSTRING;
c_str[1] = size;