bpo-25684: ttk.OptionMenu radiobuttons weren't unique (GH-2276) (GH-2960)
ttk.OptionMenu radiobuttons weren't unique
between instances of OptionMenu.
(cherry picked from commit a568e52733
)
This commit is contained in:
parent
ae16b9966d
commit
e1847ea4a9
|
@ -284,6 +284,31 @@ class OptionMenuTest(AbstractTkTest, unittest.TestCase):
|
|||
|
||||
optmenu.destroy()
|
||||
|
||||
def test_unique_radiobuttons(self):
|
||||
# check that radiobuttons are unique across instances (bpo25684)
|
||||
items = ('a', 'b', 'c')
|
||||
default = 'a'
|
||||
optmenu = ttk.OptionMenu(self.root, self.textvar, default, *items)
|
||||
textvar2 = tkinter.StringVar(self.root)
|
||||
optmenu2 = ttk.OptionMenu(self.root, textvar2, default, *items)
|
||||
optmenu.pack()
|
||||
optmenu.wait_visibility()
|
||||
optmenu2.pack()
|
||||
optmenu2.wait_visibility()
|
||||
optmenu['menu'].invoke(1)
|
||||
optmenu2['menu'].invoke(2)
|
||||
optmenu_stringvar_name = optmenu['menu'].entrycget(0, 'variable')
|
||||
optmenu2_stringvar_name = optmenu2['menu'].entrycget(0, 'variable')
|
||||
self.assertNotEqual(optmenu_stringvar_name,
|
||||
optmenu2_stringvar_name)
|
||||
self.assertEqual(self.root.tk.globalgetvar(optmenu_stringvar_name),
|
||||
items[1])
|
||||
self.assertEqual(self.root.tk.globalgetvar(optmenu2_stringvar_name),
|
||||
items[2])
|
||||
|
||||
optmenu.destroy()
|
||||
optmenu2.destroy()
|
||||
|
||||
|
||||
tests_gui = (LabeledScaleTest, OptionMenuTest)
|
||||
|
||||
|
|
|
@ -1614,7 +1614,8 @@ class OptionMenu(Menubutton):
|
|||
menu.delete(0, 'end')
|
||||
for val in values:
|
||||
menu.add_radiobutton(label=val,
|
||||
command=Tkinter._setit(self._variable, val, self._callback))
|
||||
command=Tkinter._setit(self._variable, val, self._callback),
|
||||
variable=self._variable)
|
||||
|
||||
if default:
|
||||
self._variable.set(default)
|
||||
|
|
|
@ -1229,6 +1229,7 @@ James Rutherford
|
|||
Chris Ryland
|
||||
Constantina S.
|
||||
Matthieu S
|
||||
Cheryl Sabella
|
||||
Patrick Sabin
|
||||
Sébastien Sablé
|
||||
Suman Saha
|
||||
|
|
|
@ -0,0 +1,2 @@
|
|||
Change ``ttk.OptionMenu`` radiobuttons to be unique across instances of
|
||||
``OptionMenu``.
|
Loading…
Reference in New Issue