traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-33967: Fix singledispatch raised IndexError when no args (GH-8184) 

(cherry picked from commit 445f1b35ce)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
This commit is contained in:
Miss Islington (bot) 2018-07-10 00:48:57 -07:00 committed by GitHub
parent c3bdea4c6c
commit df9f633f94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Lib/functools.py
View File

@ -817,8 +817,13 @@ def singledispatch(func):
return func return func
def wrapper(*args, **kw): def wrapper(*args, **kw):
if not args:
raise TypeError(f'{funcname} requires at least '
'1 positional argument')
return dispatch(args[0].__class__)(*args, **kw) return dispatch(args[0].__class__)(*args, **kw)
funcname = getattr(func, '__name__', 'singledispatch function')
registry[object] = func registry[object] = func
wrapper.register = register wrapper.register = register
wrapper.dispatch = dispatch wrapper.dispatch = dispatch

7
Lib/test/test_functools.py
View File

@ -2187,6 +2187,13 @@ class TestSingleDispatch(unittest.TestCase):
)) ))
self.assertTrue(str(exc.exception).endswith(msg_suffix)) self.assertTrue(str(exc.exception).endswith(msg_suffix))
def test_invalid_positional_argument(self):
@functools.singledispatch
def f(*args):
pass
msg = 'f requires at least 1 positional argument'
with self.assertRaisesRegexp(TypeError, msg):
f()
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()

2
Misc/NEWS.d/next/Library/2018-07-08-18-49-41.bpo-33967.lhaAez.rst Normal file
View File

@ -0,0 +1,2 @@
functools.singledispatch now raises TypeError instead of IndexError when no
positional arguments are passed.