traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue #15038 : Fixing the condition broadcast and docs.

This commit is contained in:
Kristján Valur Jónsson 2013-03-19 20:18:37 -07:00
parent f47e77f343
commit dc32d18d11
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Python/condvar.h
View File

@ -163,10 +163,9 @@ PyCOND_TIMEDWAIT(PyCOND_T *cond, PyMUTEX_T *mut, long us)
Generic emulations of the pthread_cond_* API using Generic emulations of the pthread_cond_* API using
earlier Win32 functions can be found on the Web. earlier Win32 functions can be found on the Web.
The following read can be edificating (or not): The following read can be give background information to these issues,
but the implementations are all broken in some way.
http://www.cse.wustl.edu/~schmidt/win32-cv-1.html http://www.cse.wustl.edu/~schmidt/win32-cv-1.html
See also
*/ */
typedef CRITICAL_SECTION PyMUTEX_T; typedef CRITICAL_SECTION PyMUTEX_T;
@ -297,9 +296,10 @@ PyCOND_SIGNAL(PyCOND_T *cv)
Py_LOCAL_INLINE(int) Py_LOCAL_INLINE(int)
PyCOND_BROADCAST(PyCOND_T *cv) PyCOND_BROADCAST(PyCOND_T *cv)
{ {
if (cv->waiting > 0) { int waiting = cv->waiting;
return ReleaseSemaphore(cv->sem, cv->waiting, NULL) ? 0 : -1; if (waiting > 0) {
cv->waiting = 0; cv->waiting = 0;
return ReleaseSemaphore(cv->sem, waiting, NULL) ? 0 : -1;
} }
return 0; return 0;
} }