diff --git a/Lib/idlelib/editor.py b/Lib/idlelib/editor.py index 892b64ba696..7c3f215e9f9 100644 --- a/Lib/idlelib/editor.py +++ b/Lib/idlelib/editor.py @@ -30,6 +30,7 @@ from idlelib import windows # The default tab setting for a Text widget, in average-width characters. TK_TABWIDTH_DEFAULT = 8 _py_version = ' (%s)' % platform.python_version() +darwin = sys.platform == 'darwin' def _sphinx_version(): "Format sys.version_info to produce the Sphinx version string used to install the chm docs" @@ -49,7 +50,7 @@ class EditorWindow(object): from idlelib.undo import UndoDelegator from idlelib.iomenu import IOBinding, encoding from idlelib import mainmenu - from tkinter import Toplevel + from tkinter import Toplevel, EventType from idlelib.statusbar import MultiStatusBar from idlelib.autocomplete import AutoComplete from idlelib.autoexpand import AutoExpand @@ -147,6 +148,9 @@ class EditorWindow(object): else: # Elsewhere, use right-click for popup menus. text.bind("<3>",self.right_menu_event) + text.bind('', self.mousescroll) + text.bind('', self.mousescroll) + text.bind('', self.mousescroll) text.bind("<>", self.cut) text.bind("<>", self.copy) text.bind("<>", self.paste) @@ -193,7 +197,7 @@ class EditorWindow(object): text.bind("<>", self.open_turtle_demo) self.set_status_bar() - vbar['command'] = text.yview + vbar['command'] = self.handle_yview vbar.pack(side=RIGHT, fill=Y) text['yscrollcommand'] = vbar.set text['font'] = idleConf.GetFont(self.root, 'main', 'EditorWindow') @@ -441,6 +445,27 @@ class EditorWindow(object): menu.delete(self.wmenu_end+1, end) windows.add_windows_to_menu(menu) + def handle_yview(self, event, *args): + "Handle scrollbar." + if event == 'moveto': + fraction = float(args[0]) + lines = (round(self.getlineno('end') * fraction) - + self.getlineno('@0,0')) + event = 'scroll' + args = (lines, 'units') + self.text.yview(event, *args) + return 'break' + + def mousescroll(self, event): + "Handle scroll wheel." + up = {EventType.MouseWheel: event.delta >= 0 == darwin, + EventType.Button: event.num == 4} + lines = 5 + if up[event.type]: + lines = -lines + self.text.yview_scroll(lines, 'units') + return 'break' + rmenu = None def right_menu_event(self, event): diff --git a/Misc/NEWS.d/next/IDLE/2018-06-03-09-13-28.bpo-33664.PZzQyL.rst b/Misc/NEWS.d/next/IDLE/2018-06-03-09-13-28.bpo-33664.PZzQyL.rst new file mode 100644 index 00000000000..48f602f641c --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2018-06-03-09-13-28.bpo-33664.PZzQyL.rst @@ -0,0 +1,5 @@ +Scroll IDLE editor text by lines. +Previously, the mouse wheel and scrollbar slider moved text by a fixed +number of pixels, resulting in partial lines at the top of the editor +box. The change also applies to the shell and grep output windows, +but not to read-only text views.