From d89cea15ad37e873003fc74ec2c77660ab620b00 Mon Sep 17 00:00:00 2001 From: Daniel Andersson Date: Wed, 13 Nov 2019 10:03:45 +0100 Subject: [PATCH] bpo-38781: Clear buffer in MemoryHandler flush (GH-17132) This makes it easier to use a custom buffer when subclassing MemoryHandler (by avoiding the explicity empty list literal assignment in the flush method). For example, collection.deque can now be used without any modifications to MemoryHandler.flush. The same applies to BufferingHandler. --- Lib/logging/handlers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index c1aec9880d7..ea14541e1e5 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -1254,7 +1254,7 @@ class BufferingHandler(logging.Handler): """ self.acquire() try: - self.buffer = [] + self.buffer.clear() finally: self.release() @@ -1321,7 +1321,7 @@ class MemoryHandler(BufferingHandler): if self.target: for record in self.buffer: self.target.handle(record) - self.buffer = [] + self.buffer.clear() finally: self.release()