traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue #14815: Bugfix: the PyLong fed into the seed generator must be unsigned.

This commit is contained in:
Larry Hastings 2012-06-24 02:52:21 -07:00
parent 50c4000685
commit d60cd4295c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Modules/_randommodule.c
View File

@ -228,16 +228,17 @@ random_seed(RandomObject *self, PyObject *args)
Py_INCREF(Py_None);
return Py_None;
}
/* If the arg is an int or long, use its absolute value; else use
* the absolute value of its hash code.
/* This algorithm relies on the number being unsigned.
* So: if the arg is a PyLong, use its absolute value.
* Otherwise use its hash value, cast to unsigned.
*/
if (PyLong_Check(arg))
n = PyNumber_Absolute(arg);
else {
Py_ssize_t hash = PyObject_Hash(arg);
Py_hash_t hash = PyObject_Hash(arg);
if (hash == -1)
goto Done;
n = PyLong_FromSsize_t(hash);
n = PyLong_FromSize_t((size_t)hash);
}
if (n == NULL)
goto Done;