bpo-41056: Fix reference to deallocated stack in pathconfig (Coverity) (GH-21013)
Reported by Coverity. (CID 1457554 RETURN_LOCAL)
path0 is assigned as a pointer to this right before it goes out of scope.
(cherry picked from commit 81328f3070
)
Co-authored-by: Gregory P. Smith <greg@krypto.org>
This commit is contained in:
parent
14195597b3
commit
d5ee9b9940
|
@ -0,0 +1 @@
|
|||
Fixes a reference to deallocated stack space during startup when constructing sys.path involving a relative symlink when code was supplied via -c. (discovered via Coverity)
|
|
@ -679,6 +679,7 @@ _PyPathConfig_ComputeSysPath0(const PyWideStringList *argv, PyObject **path0_p)
|
|||
#ifdef HAVE_READLINK
|
||||
wchar_t link[MAXPATHLEN + 1];
|
||||
int nr = 0;
|
||||
wchar_t path0copy[2 * MAXPATHLEN + 1];
|
||||
|
||||
if (have_script_arg) {
|
||||
nr = _Py_wreadlink(path0, link, Py_ARRAY_LENGTH(link));
|
||||
|
@ -701,7 +702,6 @@ _PyPathConfig_ComputeSysPath0(const PyWideStringList *argv, PyObject **path0_p)
|
|||
}
|
||||
else {
|
||||
/* Must make a copy, path0copy has room for 2 * MAXPATHLEN */
|
||||
wchar_t path0copy[2 * MAXPATHLEN + 1];
|
||||
wcsncpy(path0copy, path0, MAXPATHLEN);
|
||||
q = wcsrchr(path0copy, SEP);
|
||||
wcsncpy(q+1, link, MAXPATHLEN);
|
||||
|
|
Loading…
Reference in New Issue