traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555)

This commit is contained in:
Berker Peksag 2018-04-23 02:48:11 +03:00 committed by GitHub
parent b81ca28b37
commit d5a2377c3d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/http/cookies.py
View File

@ -408,6 +408,8 @@ class Morsel(dict):
append("%s=%s" % (self._reserved[key], _getdate(value))) append("%s=%s" % (self._reserved[key], _getdate(value)))
elif key == "max-age" and isinstance(value, int): elif key == "max-age" and isinstance(value, int):
append("%s=%d" % (self._reserved[key], value)) append("%s=%d" % (self._reserved[key], value))
elif key == "comment" and isinstance(value, str):
append("%s=%s" % (self._reserved[key], _quote(value)))
elif key in self._flags: elif key in self._flags:
if value: if value:
append(str(self._reserved[key])) append(str(self._reserved[key]))

10
Lib/test/test_http_cookies.py
View File

@ -220,6 +220,16 @@ class CookieTests(unittest.TestCase):
with self.assertRaises(cookies.CookieError): with self.assertRaises(cookies.CookieError):
C.load(rawdata) C.load(rawdata)
def test_comment_quoting(self):
c = cookies.SimpleCookie()
c['foo'] = '\N{COPYRIGHT SIGN}'
self.assertEqual(str(c['foo']), 'Set-Cookie: foo="\\251"')
c['foo']['comment'] = 'comment \N{COPYRIGHT SIGN}'
self.assertEqual(
str(c['foo']),
'Set-Cookie: foo="\\251"; Comment="comment \\251"'
)
class MorselTests(unittest.TestCase): class MorselTests(unittest.TestCase):
"""Tests for the Morsel object.""" """Tests for the Morsel object."""

1
Misc/NEWS.d/next/Library/2018-04-21-00-24-08.bpo-991266.h93TP_.rst Normal file
View File

@ -0,0 +1 @@
Fix quoting of the ``Comment`` attribute of :class:`http.cookies.SimpleCookie`.