From 04d4229719055c9536da6d4b58033981ef86d0d2 Mon Sep 17 00:00:00 2001 From: Berker Peksag Date: Fri, 11 Mar 2016 23:07:27 +0200 Subject: [PATCH] Issue #20589: Invoking Path.owner() and Path.group() on Windows now raise NotImplementedError instead of ImportError. --- Lib/pathlib.py | 6 ++++++ Lib/test/test_pathlib.py | 9 +++++++++ Misc/NEWS | 3 +++ 3 files changed, 18 insertions(+) diff --git a/Lib/pathlib.py b/Lib/pathlib.py index 5169ff5e633..ed31ddb8dd8 100644 --- a/Lib/pathlib.py +++ b/Lib/pathlib.py @@ -1425,3 +1425,9 @@ class PosixPath(Path, PurePosixPath): class WindowsPath(Path, PureWindowsPath): __slots__ = () + + def owner(self): + raise NotImplementedError("Path.owner() is unsupported on this system") + + def group(self): + raise NotImplementedError("Path.group() is unsupported on this system") diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py index b03fee018f3..8ba9c8f3a79 100644 --- a/Lib/test/test_pathlib.py +++ b/Lib/test/test_pathlib.py @@ -1156,6 +1156,15 @@ class PureWindowsPathTest(_BasePurePathTest, unittest.TestCase): # UNC paths are never reserved self.assertIs(False, P('//my/share/nul/con/aux').is_reserved()) + def test_owner(self): + P = self.cls + with self.assertRaises(NotImplementedError): + P('c:/').owner() + + def test_group(self): + P = self.cls + with self.assertRaises(NotImplementedError): + P('c:/').group() class PurePathTest(_BasePurePathTest, unittest.TestCase): cls = pathlib.PurePath diff --git a/Misc/NEWS b/Misc/NEWS index b9641816efd..3d9a78735cc 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -91,6 +91,9 @@ Core and Builtins Library ------- +- Issue #20589: Invoking Path.owner() and Path.group() on Windows now raise + NotImplementedError instead of ImportError. + - Issue #26177: Fixed the keys() method for Canvas and Scrollbar widgets. - Issue #15068: Got rid of excessive buffering in the fileinput module.