bpo-34019: Fix wrong arguments for Opera Browser (GH-8047)

The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL.
(cherry picked from commit 3cf1f154ed)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
This commit is contained in:
Miss Islington (bot) 2018-07-03 05:17:28 -07:00 committed by GitHub
parent 42b2f84a85
commit cee7b2261f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 12 deletions

View File

@ -170,23 +170,23 @@ class OperaCommandTest(CommandTestMixin, unittest.TestCase):
def test_open(self):
self._test('open',
options=['-remote'],
arguments=['openURL({})'.format(URL)])
options=[],
arguments=[URL])
def test_open_with_autoraise_false(self):
self._test('open', kw=dict(autoraise=False),
options=['-remote', '-noraise'],
arguments=['openURL({})'.format(URL)])
options=[],
arguments=[URL])
def test_open_new(self):
self._test('open_new',
options=['-remote'],
arguments=['openURL({},new-window)'.format(URL)])
options=['--new-window'],
arguments=[URL])
def test_open_new_tab(self):
self._test('open_new_tab',
options=['-remote'],
arguments=['openURL({},new-page)'.format(URL)])
options=[],
arguments=[URL])
class ELinksCommandTest(CommandTestMixin, unittest.TestCase):

View File

@ -308,11 +308,10 @@ Chromium = Chrome
class Opera(UnixBrowser):
"Launcher class for Opera browser."
raise_opts = ["-noraise", ""]
remote_args = ['-remote', 'openURL(%s%action)']
remote_args = ['%action', '%s']
remote_action = ""
remote_action_newwin = ",new-window"
remote_action_newtab = ",new-page"
remote_action_newwin = "--new-window"
remote_action_newtab = ""
background = True

View File

@ -0,0 +1,2 @@
webbrowser: Correct the arguments passed to Opera Browser when opening a new URL
using the ``webbrowser`` module. Patch by Bumsik Kim.