Merged revisions 72100-72101 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk ........ r72100 | r.david.murray | 2009-04-29 09:17:37 -0400 (Wed, 29 Apr 2009) | 7 lines Fix issue 2245. aifc now skips any chunk type it doesn't actually process instead of throwing errors for anything not in an explicit skip list. This is per this spec: http://www.cnpbagwell.com/aiff-c.txt. Spec reference and test sound file provided by Santiago Peresón, fix based on patch by Hiroaki Kawai. ........ r72101 | r.david.murray | 2009-04-29 09:51:44 -0400 (Wed, 29 Apr 2009) | 2 lines Now that we've got a test_aifc, add a few tests. ........
This commit is contained in:
parent
dda50a8171
commit
cecc3a0083
|
@ -144,9 +144,6 @@ class Error(Exception):
|
|||
|
||||
_AIFC_version = 0xA2805140L # Version 1 of AIFF-C
|
||||
|
||||
_skiplist = 'COMT', 'INST', 'MIDI', 'AESD', \
|
||||
'APPL', 'NAME', 'AUTH', '(c) ', 'ANNO'
|
||||
|
||||
def _read_long(file):
|
||||
try:
|
||||
return struct.unpack('>l', file.read(4))[0]
|
||||
|
@ -314,10 +311,6 @@ class Aifc_read:
|
|||
self._version = _read_ulong(chunk)
|
||||
elif chunkname == 'MARK':
|
||||
self._readmark(chunk)
|
||||
elif chunkname in _skiplist:
|
||||
pass
|
||||
else:
|
||||
raise Error, 'unrecognized chunk type '+chunk.chunkname
|
||||
chunk.skip()
|
||||
if not self._comm_chunk_read or not self._ssnd_chunk:
|
||||
raise Error, 'COMM chunk and/or SSND chunk missing'
|
||||
|
|
Binary file not shown.
|
@ -0,0 +1,54 @@
|
|||
from test.test_support import findfile, run_unittest
|
||||
import unittest
|
||||
|
||||
import aifc
|
||||
|
||||
|
||||
class AIFCTest(unittest.TestCase):
|
||||
|
||||
def setUp(self):
|
||||
self.sndfilepath = findfile('Sine-1000Hz-300ms.aif')
|
||||
|
||||
def test_skipunknown(self):
|
||||
#Issue 2245
|
||||
#This file contains chunk types aifc doesn't recognize.
|
||||
f = aifc.open(self.sndfilepath)
|
||||
f.close()
|
||||
|
||||
def test_params(self):
|
||||
f = aifc.open(self.sndfilepath)
|
||||
self.assertEqual(f.getnchannels(), 2)
|
||||
self.assertEqual(f.getsampwidth(), 2)
|
||||
self.assertEqual(f.getframerate(), 48000)
|
||||
self.assertEqual(f.getnframes(), 14400)
|
||||
self.assertEqual(f.getcomptype(), 'NONE')
|
||||
self.assertEqual(f.getcompname(), 'not compressed')
|
||||
self.assertEqual(f.getparams(), (2, 2, 48000, 14400, 'NONE', 'not compressed'))
|
||||
f.close()
|
||||
|
||||
def test_read(self):
|
||||
f = aifc.open(self.sndfilepath)
|
||||
self.assertEqual(f.tell(), 0)
|
||||
self.assertEqual(f.readframes(2), '\x00\x00\x00\x00\x0b\xd4\x0b\xd4')
|
||||
f.rewind()
|
||||
pos0 = f.tell()
|
||||
self.assertEqual(pos0, 0)
|
||||
self.assertEqual(f.readframes(2), '\x00\x00\x00\x00\x0b\xd4\x0b\xd4')
|
||||
pos2 = f.tell()
|
||||
self.assertEqual(pos2, 2)
|
||||
self.assertEqual(f.readframes(2), '\x17t\x17t"\xad"\xad')
|
||||
f.setpos(pos2)
|
||||
self.assertEqual(f.readframes(2), '\x17t\x17t"\xad"\xad')
|
||||
f.setpos(pos0)
|
||||
self.assertEqual(f.readframes(2), '\x00\x00\x00\x00\x0b\xd4\x0b\xd4')
|
||||
f.close()
|
||||
|
||||
#XXX Need more tests!
|
||||
|
||||
|
||||
def test_main():
|
||||
run_unittest(AIFCTest)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
|
@ -10,7 +10,6 @@ class TestUntestedModules(unittest.TestCase):
|
|||
def test_at_least_import_untested_modules(self):
|
||||
with warnings.catch_warnings():
|
||||
import CGIHTTPServer
|
||||
import aifc
|
||||
import audiodev
|
||||
import bdb
|
||||
import cgitb
|
||||
|
|
|
@ -362,6 +362,7 @@ Tamito Kajiyama
|
|||
Peter van Kampen
|
||||
Jacob Kaplan-Moss
|
||||
Lou Kates
|
||||
Hiroaki Kawai
|
||||
Sebastien Keim
|
||||
Robert Kern
|
||||
Randall Kern
|
||||
|
@ -527,6 +528,7 @@ Randy Pausch
|
|||
Samuele Pedroni
|
||||
Marcel van der Peijl
|
||||
Steven Pemberton
|
||||
Santiago Peresón
|
||||
Mark Perrego
|
||||
Trevor Perrin
|
||||
Tim Peters
|
||||
|
|
Loading…
Reference in New Issue