From c760e86184b9ff269e5c0f00ac374665224cde5f Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Thu, 28 Jan 2010 01:31:13 +0000 Subject: [PATCH] revert r77790. it requires a new-style class change --- Lib/UserDict.py | 2 +- Lib/abc.py | 2 +- Lib/test/test_abc.py | 5 ----- Misc/NEWS | 2 -- 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a/Lib/UserDict.py b/Lib/UserDict.py index df5f7fbe49e..0d9591a9667 100644 --- a/Lib/UserDict.py +++ b/Lib/UserDict.py @@ -1,6 +1,6 @@ """A more or less complete user-defined wrapper around dictionary objects.""" -class UserDict(object): +class UserDict: def __init__(self, dict=None, **kwargs): self.data = {} if dict is not None: diff --git a/Lib/abc.py b/Lib/abc.py index 8aeb2af6169..95126d8a18a 100644 --- a/Lib/abc.py +++ b/Lib/abc.py @@ -96,7 +96,7 @@ class ABCMeta(type): def register(cls, subclass): """Register a virtual subclass of an ABC.""" - if not isinstance(subclass, type): + if not isinstance(cls, type): raise TypeError("Can only register classes") if issubclass(subclass, cls): return # Already a subclass diff --git a/Lib/test/test_abc.py b/Lib/test/test_abc.py index fa20173df1e..3e0955fd75f 100644 --- a/Lib/test/test_abc.py +++ b/Lib/test/test_abc.py @@ -149,11 +149,6 @@ class TestABC(unittest.TestCase): self.assertRaises(RuntimeError, C.register, A) # cycles not allowed C.register(B) # ok - def test_register_non_class(self): - class A(object): - __metaclass__ = abc.ABCMeta - self.assertRaises(TypeError, A.register, 4) - def test_registration_transitiveness(self): class A: __metaclass__ = abc.ABCMeta diff --git a/Misc/NEWS b/Misc/NEWS index 6c15fe6c71d..d518010a39a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -58,8 +58,6 @@ Library file position to the given argument, which goes against the tradition of ftruncate() and other truncation APIs. Patch by Pascal Chambon. -- Issue #7792: Registering non-classes to ABCs raised an obscure error. - - Issue #7773: Fix an UnboundLocalError in platform.linux_distribution() when the release file is empty.