traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixing the issue4860. Escaping embedded '"' character in js_output() method of Morsel.

This commit is contained in:
Senthil Kumaran 2009-04-02 03:00:34 +00:00
parent 985951df7f
commit c730a6a123
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/Cookie.py
View File

@ -477,7 +477,7 @@ class Morsel(dict):
document.cookie = \"%s\"; document.cookie = \"%s\";
// end hiding --> // end hiding -->
</script> </script>
""" % ( self.OutputString(attrs), ) """ % ( self.OutputString(attrs).replace('"',r'\"'), )
# end js_output() # end js_output()
def OutputString(self, attrs=None): def OutputString(self, attrs=None):

8
Lib/test/test_cookie.py
View File

@ -51,17 +51,17 @@ class CookieTests(unittest.TestCase):
self.assertEqual(C.output(['path']), self.assertEqual(C.output(['path']),
'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme') 'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
self.assertEqual(C.js_output(), """ self.assertEqual(C.js_output(), r"""
<script type="text/javascript"> <script type="text/javascript">
<!-- begin hiding <!-- begin hiding
document.cookie = "Customer="WILE_E_COYOTE"; Path=/acme; Version=1"; document.cookie = "Customer=\"WILE_E_COYOTE\"; Path=/acme; Version=1";
// end hiding --> // end hiding -->
</script> </script>
""") """)
self.assertEqual(C.js_output(['path']), """ self.assertEqual(C.js_output(['path']), r"""
<script type="text/javascript"> <script type="text/javascript">
<!-- begin hiding <!-- begin hiding
document.cookie = "Customer="WILE_E_COYOTE"; Path=/acme"; document.cookie = "Customer=\"WILE_E_COYOTE\"; Path=/acme";
// end hiding --> // end hiding -->
</script> </script>
""") """)