From c730a6a1237a31d0ce89ab8fee2dea9af450a6ee Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Thu, 2 Apr 2009 03:00:34 +0000 Subject: [PATCH] Fixing the issue4860. Escaping embedded '"' character in js_output() method of Morsel. --- Lib/Cookie.py | 2 +- Lib/test/test_cookie.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Lib/Cookie.py b/Lib/Cookie.py index b2f7427aa94..1ccfd160a49 100644 --- a/Lib/Cookie.py +++ b/Lib/Cookie.py @@ -477,7 +477,7 @@ class Morsel(dict): document.cookie = \"%s\"; // end hiding --> - """ % ( self.OutputString(attrs), ) + """ % ( self.OutputString(attrs).replace('"',r'\"'), ) # end js_output() def OutputString(self, attrs=None): diff --git a/Lib/test/test_cookie.py b/Lib/test/test_cookie.py index e7c0cf1cccb..1cd538ce40d 100644 --- a/Lib/test/test_cookie.py +++ b/Lib/test/test_cookie.py @@ -51,17 +51,17 @@ class CookieTests(unittest.TestCase): self.assertEqual(C.output(['path']), 'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme') - self.assertEqual(C.js_output(), """ + self.assertEqual(C.js_output(), r""" """) - self.assertEqual(C.js_output(['path']), """ + self.assertEqual(C.js_output(['path']), r""" """)