traverseda
/
cpython
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Issue #23618: Cleanup internal_connect() in socketmodule.c 

On Windows, it looks like using the C type socklen_t for getsockopt() (instead
of int) is fine, it was already used in socket.getsockopt().
This commit is contained in:
Victor Stinner 2015-03-31 21:23:10 +02:00
parent 41290a68ba
commit c4e819a54f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Modules/socketmodule.c
View File

@ -2485,7 +2485,7 @@ internal_connect(PySocketSockObject *s, struct sockaddr *addr, int addrlen,
else if (timeout == 0) {
socklen_t res_size = sizeof res;
if (!getsockopt(s->sock_fd, SOL_SOCKET, SO_ERROR,
(char*)&res, &res_size)) {
(void *)&res, &res_size)) {
if (res == EISCONN)
res = 0;
err = res;
@ -2533,8 +2533,6 @@ sock_connect(PySocketSockObject *s, PyObject *addro)
return NULL;
if (res != 0) {
#ifdef MS_WINDOWS
/* getsockopt also clears WSAGetLastError,
so reset it back. */
WSASetLastError(res);
#else
errno = res;