From c3c3062169fad11e0e74aa85ff1f3d69c0170d42 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Tue, 5 Sep 2017 21:43:19 -0700 Subject: [PATCH] [3.6] _pickle: Fix whichmodule() (GH-3358) (#3361) _PyUnicode_FromId() can return NULL: replace Py_INCREF() with Py_XINCREF(). Fix coverity report: CID 1417269. (cherry picked from commit af46eb8) --- Modules/_pickle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/_pickle.c b/Modules/_pickle.c index 920b46fc285..ef0a03b1079 100644 --- a/Modules/_pickle.c +++ b/Modules/_pickle.c @@ -1705,7 +1705,7 @@ whichmodule(PyObject *global, PyObject *dotted_path) /* If no module is found, use __main__. */ module_name = _PyUnicode_FromId(&PyId___main__); - Py_INCREF(module_name); + Py_XINCREF(module_name); return module_name; }