From c20830804df99535b5566e93a4e56afd16cf0e99 Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Sat, 28 Feb 2015 23:29:16 -0800 Subject: [PATCH] Need a (size_t) cast instead of (unsigned) to be big enough for a Py_ssize_t. --- Modules/_collectionsmodule.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c index 908cfd2f3e1..0ca9be1df5b 100644 --- a/Modules/_collectionsmodule.c +++ b/Modules/_collectionsmodule.c @@ -1,6 +1,12 @@ #include "Python.h" #include "structmember.h" +#ifdef STDC_HEADERS +#include +#else +#include /* For size_t */ +#endif + /* collections module implementation of a deque() datatype Written and maintained by Raymond D. Hettinger Copyright (c) 2004-2015 Python Software Foundation. @@ -780,15 +786,15 @@ deque_item(dequeobject *deque, Py_ssize_t i) b = deque->rightblock; } else { i += deque->leftindex; - n = (Py_ssize_t)((unsigned) i / BLOCKLEN); - i = (Py_ssize_t)((unsigned) i % BLOCKLEN); + n = (Py_ssize_t)((size_t) i / BLOCKLEN); + i = (Py_ssize_t)((size_t) i % BLOCKLEN); if (index < (Py_SIZE(deque) >> 1)) { b = deque->leftblock; while (n--) b = b->rightlink; } else { n = (Py_ssize_t)( - ((unsigned)(deque->leftindex + Py_SIZE(deque) - 1)) + ((size_t)(deque->leftindex + Py_SIZE(deque) - 1)) / BLOCKLEN - n); b = deque->rightblock; while (n--) @@ -839,15 +845,15 @@ deque_ass_item(dequeobject *deque, Py_ssize_t i, PyObject *v) return deque_del_item(deque, i); i += deque->leftindex; - n = (Py_ssize_t)((unsigned) i / BLOCKLEN); - i = (Py_ssize_t)((unsigned) i % BLOCKLEN); + n = (Py_ssize_t)((size_t) i / BLOCKLEN); + i = (Py_ssize_t)((size_t) i % BLOCKLEN); if (index <= halflen) { b = deque->leftblock; while (n--) b = b->rightlink; } else { n = (Py_ssize_t)( - ((unsigned)(deque->leftindex + Py_SIZE(deque) - 1)) + ((size_t)(deque->leftindex + Py_SIZE(deque) - 1)) / BLOCKLEN - n); b = deque->rightblock; while (n--)