Packaging tests: don’t let an internal cache grow indefinitely.
Victor Stinner diagnosed on #12167 that some reference leaks came from util._path_created, a set used for caching; there are two tests that cause additions to this set, so now they clear it in tearDown, avoiding 17 refleaks. (My tests show that it’s necessary to clear the set in only one test, clearing it in both does not stop more refleaks, but there’s no harm in doing it.)
This commit is contained in:
parent
d2c7e3fe96
commit
c06f46f74c
|
@ -1,6 +1,7 @@
|
|||
"""Tests for distutils.command.bdist_dumb."""
|
||||
|
||||
import os
|
||||
import packaging.util
|
||||
|
||||
from packaging.dist import Distribution
|
||||
from packaging.command.bdist_dumb import bdist_dumb
|
||||
|
@ -18,6 +19,7 @@ class BuildDumbTestCase(support.TempdirManager,
|
|||
|
||||
def tearDown(self):
|
||||
os.chdir(self.old_location)
|
||||
packaging.util._path_created.clear()
|
||||
super(BuildDumbTestCase, self).tearDown()
|
||||
|
||||
@requires_zlib
|
||||
|
|
|
@ -3,6 +3,7 @@ import os
|
|||
import sys
|
||||
from io import StringIO
|
||||
import stat
|
||||
import packaging.util
|
||||
|
||||
from packaging.database import disable_cache, enable_cache
|
||||
from packaging.run import main
|
||||
|
@ -43,6 +44,7 @@ class UninstallTestCase(support.TempdirManager,
|
|||
|
||||
def tearDown(self):
|
||||
os.chdir(self.cwd)
|
||||
packaging.util._path_created.clear()
|
||||
super(UninstallTestCase, self).tearDown()
|
||||
|
||||
def run_setup(self, *args):
|
||||
|
|
Loading…
Reference in New Issue