From bf272983643776e9842cad6d1885f1b92f5eb67f Mon Sep 17 00:00:00 2001 From: Fred Drake Date: Fri, 3 Dec 1999 17:15:30 +0000 Subject: [PATCH] Correct the docstring for byteswap(); error noted by Bernhard Reiter . Added a check that no parameters were passed to byteswap(); previously allowed any parameters you happened to pass. --- Modules/arraymodule.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Modules/arraymodule.c b/Modules/arraymodule.c index 6b47e0c76ec..fc7bf074615 100644 --- a/Modules/arraymodule.c +++ b/Modules/arraymodule.c @@ -759,6 +759,10 @@ array_byteswap(self, args) { char *p; int i; + + if (!PyArg_ParseTuple(args, ":byteswap")) + return NULL; + switch (self->ob_descr->itemsize) { case 1: break; @@ -805,10 +809,10 @@ array_byteswap(self, args) } static char byteswap_doc [] = -"byteswap(x)\n\ +"byteswap()\n\ \n\ -Byteswap all items of the array. This is only supported for integer\n\ -values of x, which determines the size of the blocks swapped."; +Byteswap all items of the array. If the items in the array are not 1, 2,\n\ +4, or 8 bytes in size, RuntimeError is raised."; static PyObject * array_reverse(self, args) @@ -1139,7 +1143,8 @@ representation."; PyMethodDef array_methods[] = { {"append", (PyCFunction)array_append, 0, append_doc}, {"buffer_info", (PyCFunction)array_buffer_info, 0, buffer_info_doc}, - {"byteswap", (PyCFunction)array_byteswap, 0, byteswap_doc}, + {"byteswap", (PyCFunction)array_byteswap, METH_VARARGS, + byteswap_doc}, /* {"count", (method)array_count},*/ {"fromfile", (PyCFunction)array_fromfile, 0, fromfile_doc}, {"fromlist", (PyCFunction)array_fromlist, 0, fromlist_doc},