Issue #24732, #23834: Fix sock_accept_impl() on Windows

accept() returns INVALID_SOCKET on error, it's not necessary a negative number.
2015-07-27 23:37:11 +02:00 · 2015-07-27 23:37:11 +02:00 · bea232a15f
parent 0659c43d73
commit bea232a15f
1 changed files with 5 additions and 0 deletions
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@ -2211,7 +2211,12 @@ sock_accept_impl(PySocketSockObject *s, void *data)
 #else
    ctx->result = accept(s->sock_fd, SAS2SA(ctx->addrbuf), ctx->addrlen);
 #endif
+
+#ifdef MS_WINDOWS
+    return (ctx->result != INVALID_SOCKET);
+#else
    return (ctx->result >= 0);
+#endif
 }

 /* s._accept() -> (fd, address) */